[
https://issues.jboss.org/browse/WELD-1084?page=com.atlassian.jira.plugin....
]
Marko Lukša updated WELD-1084:
------------------------------
Summary: Introduce class InterceptorBindingType (was: Introduce class
InterceptorBinding)
Description:
Currently, there is no special class representing interceptor bindings. The bindings are
represented as {{Annotation}}. Thus it is impossible to know whether
{{Set<Annotation>}} contains only annotations representing interceptor bindings or
other annotations also.
Also, Annotation instances are proxied and their {{equals}} is broken, so that
{{annotation1.equals(annotation2)}} will return false even if both annotation1 and
annotation2 represent the same annotation (e.g. @MyAnnotation).
Furthermore, when considering if two interceptor bindings are equal, all the non-binding
members of the annotation should be ignored.
If instead of just passing around {{Annotation}}s, we passed {{InterceptorBindingType}}s,
a lot of the code would be clearer and we'd also probably have no bugs related to the
proxy.equals bug.
was:
Currently, there is no special class representing interceptor bindings. The bindings are
represented as {{Annotation}}. Thus it is impossible to know whether
{{Set<Annotation>}} contains only annotations representing interceptor bindings or
other annotations also.
Also, Annotation instances are proxied and their {{equals}} is broken, so that
{{annotation1.equals(annotation2)}} will return false even if both annotation1 and
annotation2 represent the same annotation (e.g. @MyAnnotation).
Furthermore, when considering if two interceptor bindings are equal, all the non-binding
members of the annotation should be ignored.
If instead of just passing around {{Annotation}}s, we passed {{InterceptorBinding}}s, a
lot of the code would be clearer and we'd also probably have no bugs related to the
proxy.equals bug.
Introduce class InterceptorBindingType
--------------------------------------
Key: WELD-1084
URL:
https://issues.jboss.org/browse/WELD-1084
Project: Weld
Issue Type: Task
Reporter: Marko Lukša
Assignee: Marko Lukša
Currently, there is no special class representing interceptor bindings. The bindings are
represented as {{Annotation}}. Thus it is impossible to know whether
{{Set<Annotation>}} contains only annotations representing interceptor bindings or
other annotations also.
Also, Annotation instances are proxied and their {{equals}} is broken, so that
{{annotation1.equals(annotation2)}} will return false even if both annotation1 and
annotation2 represent the same annotation (e.g. @MyAnnotation).
Furthermore, when considering if two interceptor bindings are equal, all the non-binding
members of the annotation should be ignored.
If instead of just passing around {{Annotation}}s, we passed {{InterceptorBindingType}}s,
a lot of the code would be clearer and we'd also probably have no bugs related to the
proxy.equals bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira