[weld-issues] [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont commented on WELD-549:
-------------------------------------
Isn't the point of the h:link tag to enhance bookmarkability, so you can share links
make your site easier for spiders etc. If the default is to propagate the conversation you
have at best created yourself a memory leak and bugs from conflicting state. At worst you
will start writing your application around this propagation and will have lost all the
benefits of the new tag anyway and make a poor web site for your users.
Whilst understanding you are the JSF experts not me, I really think the default should be
not to propagate.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira