[JBoss JIRA] (WELD-1131) Weld Proxies (for instance created by Producer-Method) loose Annotations put ontop of Methods of source class
9:51 a.m.
P Huber created WELD-1131:
-----------------------------
Summary: Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get a
set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Ales Justin commented on WELD-1131:
-----------------------------------
Can you create an Arquillian test for this?
e.g. are you sure you have the right meta-data annotations on your annotation?
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:45 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber commented on WELD-1131:
-------------------------------
This is the original Annotation which has Retention "Runtime" from the begining
(but good you've asked...I admittetly forgot that in the past on several occasions
;-)
@Target({ METHOD, FIELD })
@Retention(RUNTIME)
@Documented
public @interface PredicateDef {
String value();
}
And the use of it is
@PredicateDef("...")
public String getFirstName() {
return firstName;
}
And I found a workaround in the meantime which works for me
I had used this, which *does NOT* work:
final BeanInfo bi = Introspector.getBeanInfo(selectedCustomer.getClass());
and replaced it with this *working* version:
final BeanInfo bi =
Introspector.getBeanInfo(selectedCustomer.getClass().getSuperClass());
---
Arquillian: I'm not yet into Arquillian, but I can try to do a simple sample with
standalone WELD CDI. It guess it should be possible to mimik the issue, though I cannot
promise.
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber edited comment on WELD-1131 at 5/9/12 11:46 AM:
--------------------------------------------------------
This is the original Annotation which has Retention "Runtime" from the begining
(but good you've asked...I admittetly forgot that in the past on several occasions
;-)
@Target({ METHOD, FIELD })
@Retention(RUNTIME)
@Documented
public @interface PredicateDef {
String value();
}
And the use of it is
@PredicateDef("...")
public String getFirstName() {
return firstName;
}
And I found a workaround in the meantime which works for me
I had used this, which *does NOT* work:
final BeanInfo bi = Introspector.getBeanInfo(selectedCustomer.getClass());
and replaced it with this *working* version:
final BeanInfo bi =
Introspector.getBeanInfo(selectedCustomer.getClass().getSuperClass());
---
Arquillian: I'm not yet into Arquillian, but I can try to do a simple sample with
standalone WELD CDI. It guess it should be possible to reproduce the issue, though I
cannot promise.
was (Author: huberp):
This is the original Annotation which has Retention "Runtime" from the
begining (but good you've asked...I admittetly forgot that in the past on several
occasions ;-)
@Target({ METHOD, FIELD })
@Retention(RUNTIME)
@Documented
public @interface PredicateDef {
String value();
}
And the use of it is
@PredicateDef("...")
public String getFirstName() {
return firstName;
}
And I found a workaround in the meantime which works for me
I had used this, which *does NOT* work:
final BeanInfo bi = Introspector.getBeanInfo(selectedCustomer.getClass());
and replaced it with this *working* version:
final BeanInfo bi =
Introspector.getBeanInfo(selectedCustomer.getClass().getSuperClass());
---
Arquillian: I'm not yet into Arquillian, but I can try to do a simple sample with
standalone WELD CDI. It guess it should be possible to mimik the issue, though I cannot
promise.
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Ales Justin reassigned WELD-1131:
---------------------------------
Assignee: Marko Lukša
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:10 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber updated WELD-1131:
--------------------------
Attachment: weld-forgets-annotation_WELD-1131.7z
Little progi (eclipse project) that demonstrates the behaviour.
Run Main Class:
/weld-forgets-annotation/src/main/java/com/msg/xt/jee/cdi/jira_weld_1131/StartupCDI.java
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Marko Lukša commented on WELD-1131:
-----------------------------------
P Huber, I've tried your demo with Weld 2.0.0.Alpha2 and it works, since weld 2.0 is
creating proxies differently than 1.0. So I suggest upgrading to 2.0. We're probably
not going to be fixing this in 1.x.
Aleš, please close this issue if you agree.
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:32 p.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Marko Lukša updated WELD-1131:
------------------------------
Fix Version/s: 2.0.0.Alpha2
Affects Version/s: 1.1.8.Final
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:17 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber commented on WELD-1131:
-------------------------------
Thanks for the feedback - Problem is, that I for sure can upgrade weld in my standalone
example, but not in it's original env which is glassfish 3.1.2. I'm not going to
fiddle with alpha versions there, sorry...
But I can live with it, I have a my workaround in place. Probably you can talk to the gf
guys that they are aware of the problem and that they should consider update, too and
maybe it's an good idea to document my workaround "somewhere" in the
faq/known issues/workarounds
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:19 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber edited comment on WELD-1131 at 5/10/12 4:18 AM:
--------------------------------------------------------
Thanks for the feedback - Problem is, that I for sure can upgrade weld in my standalone
example, but not in it's original env which is glassfish 3.1.2. I'm not going to
fiddle with alpha versions there, sorry...And just be be sure - You have tried the version
of my example without getSuperClass() right?
But I can live with it, I have a my workaround in place. Probably you can talk to the gf
guys that they are aware of the problem and that they should consider an update, too and
maybe it's an good idea to document my workaround "somewhere" in the
faq/known issues/workarounds
was (Author: huberp):
Thanks for the feedback - Problem is, that I for sure can upgrade weld in my
standalone example, but not in it's original env which is glassfish 3.1.2. I'm not
going to fiddle with alpha versions there, sorry...
But I can live with it, I have a my workaround in place. Probably you can talk to the gf
guys that they are aware of the problem and that they should consider update, too and
maybe it's an good idea to document my workaround "somewhere" in the
faq/known issues/workarounds
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:19 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber edited comment on WELD-1131 at 5/10/12 4:19 AM:
--------------------------------------------------------
Thanks for the feedback - Problem is, that I for sure can upgrade weld in my standalone
example, but not in it's original env which is glassfish 3.1.2. I'm not going to
fiddle with alpha versions there, sorry...And just to be sure - You have tried the version
of my example without getSuperClass() right?
But I can live with it, I have a my workaround in place. Probably you can talk to the gf
guys that they are aware of the problem and that they should consider an update, too and
maybe it's an good idea to document my workaround "somewhere" in the
faq/known issues/workarounds
was (Author: huberp):
Thanks for the feedback - Problem is, that I for sure can upgrade weld in my
standalone example, but not in it's original env which is glassfish 3.1.2. I'm not
going to fiddle with alpha versions there, sorry...And just be be sure - You have tried
the version of my example without getSuperClass() right?
But I can live with it, I have a my workaround in place. Probably you can talk to the gf
guys that they are aware of the problem and that they should consider an update, too and
maybe it's an good idea to document my workaround "somewhere" in the
faq/known issues/workarounds
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:24 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Marko Lukša commented on WELD-1131:
-----------------------------------
Yes, I've tested the version with
{{Introspector.getBeanInfo(injectField.getClass())}}. If I change the weld version to
2.0.0.Alpha2 it works, and if I change it back to your original version, it doesn't.
I've also stripped your example down to the bare minimum and created an arquillian
test from it (see
https://github.com/luksa/weld-core/commit/b991898647178d5cfebc3a6d237f386... )
The thing is, if you use reflection, you will (probably?) always need to know that there
are proxies involved and handle them appropriately.
Simply copying all the annotations to the proxy probably wouldn't solve all the
problems. Imagine having an annotation on class A and on its subclass B. If we create a
proxy for B, should we only copy annotations from B or also from A? If we copy only those
from B, then you'd still have to know that the class you're dealing with is a
proxy, and to get to annotations declared on A, you'd have to use
bProxy.getSuperClass().getSuperClass().getAnnotations() (instead of simply
b.getSuperClass().getAnnotations()).
Actually, I'm not sure how this is handled in Weld 2.0.
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:38 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
P Huber commented on WELD-1131:
-------------------------------
You're completely right - if copying the annotations from the produced class to the
proxy then the "gap" is just put to another place in the inheritance
hierarchie.
That would be for a proxied object that annotations of getClass() and
getClass().getSuperclass() are equal, what might be source of some suprise, too ;-)
But actually then this should be documented somewhere and hopefully there's some API
that I can find out if I handle a proxied object or not (same class can be proxied or not
- depends on produce method scope, maybe one time with @RequestScoped and second time with
@Singelton) so that I can handle it straightforward, maybe like: Class<T> c =
BeanManager.getSourceClass(ofProbablyProxiedObject); Is there such a method?
---
If I start to think about it on larger context - the problem is inherently there with all
that on the fly proxying - what if I CDI-produce (proxy level 2) a JPA entity (proxy level
1) which is proxied by JPA-Runtime ;-). Probably there should be some Standard on
JEE-level for all those instrumentation/on-the-fly-proxy creating libs that allow a
central API to handle getting the "original" Class back...
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Marko Lukša commented on WELD-1131:
-----------------------------------
I have checked how Weld 2.0 handles this. While method annotations are visible through
{{bProxy.getClass().getMethod("foo").getAnnotations()}}, class annotations
aren't. So you still have to obtain the annotations through the proxy's
superclass.
AFAIK there is no method in CDI that would allow you to get the actual class. You can
submit a proposal for such a method to the cdi-dev mailing list, and we'll see what
the experts say about it.
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Fix For: 2.0.0.Alpha2
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 a.m.
[
https://issues.jboss.org/browse/WELD-1131?page=com.atlassian.jira.plugin....
]
Marko Lukša resolved WELD-1131.
-------------------------------
Fix Version/s: (was: 2.0.0.Alpha2)
Resolution: Deferred
Weld Proxies (for instance created by Producer-Method) loose
Annotations put ontop of Methods of source class
-------------------------------------------------------------------------------------------------------------
Key: WELD-1131
URL: https://issues.jboss.org/browse/WELD-1131
Project: Weld
Issue Type: Bug
Components: Reflection layer
Affects Versions: 1.1.8.Final
Environment: glassfish 3.1.2
Reporter: P Huber
Assignee: Marko Lukša
Attachments: weld-forgets-annotation_WELD-1131.7z
I have project specific Annotations ontop of public Methods of a class.
class Customer {
@MyProjectSpecificAnnotation
public String getFirstName() {
return firstName;
}
}
When producing Objects of such an annotated class, like with
class Example {
@Produce
Customer producerField;
}
Then at the Injection Side the Annotations "MyProjectSpecificAnnotation" is no
longer available, because WELD injects a byte-code created proxy.
class InjectionSide {
@Inject
Customer injectField; // here we get the WELD-Proxy of unpronouncable name...and no
Annotations
}
I've used BeanIntrospector to reflect the injected Instance of class Customer. I get
a set of PropertyDescriptors with a write/read Method each.
But as allready said, none of them has the "MyProjectSpecificAnnotation".
Could be due to the fact, that when subclassing a class, the Annotations of the super
class are not available at sub class directly - But in Case of a "transparent"
WELD proxy I'd expect they should be there. Probably you have to simply copy
annotations during on-the-fly byte-code creation of the Proxy. The Problem is btw also
true for javas built in Dynamic Proxy: using it you also loose Annotations.
Hope you can fix that
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4594
days inactive
4601
days old
14 comments
3 participants
participants (3)
-
Ales Justin (JIRA) -
Marko Lukša (JIRA)
-
P Huber (JIRA)