10:06 p.m.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:06 p.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont updated WELD-549:
--------------------------------
Attachment: CdiConvoBug.war
Demo that runs on Glassfish of h:link conversation propagation
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:10 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont commented on WELD-549:
-------------------------------------
Also see:
http://seamframework.org/Community/ApparentInaccuraciesInConversationDocu...
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:59 p.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir updated WELD-549:
---------------------------
Assignee: Nicklas Karlsson
Fix Version/s: 1.0.2.CR1
Nik, could you take a look. I do believe that putting an empty <f:param
name="cid" value="" /> should override conversation propagation.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:10 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont commented on WELD-549:
-------------------------------------
Isn't the point of the h:link tag to enhance bookmarkability, so you can share links
make your site easier for spiders etc. If the default is to propagate the conversation you
have at best created yourself a memory leak and bugs from conflicting state. At worst you
will start writing your application around this propagation and will have lost all the
benefits of the new tag anyway and make a poor web site for your users.
Whilst understanding you are the JSF experts not me, I really think the default should be
not to propagate.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:14 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
Actually, David, yes you are right. Thanks for pointing that out!
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Nicklas Karlsson commented on WELD-549:
---------------------------------------
Dan appears to have been thinking about this at some point. From the header block of
ConversationAwareViewHandler:
* QUESTION should we do the same for getResourceURL?
* TODO we should enable a way to disable conversation propagation by URL
*
* @author Dan Allen
*/
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Nicklas Karlsson commented on WELD-549:
---------------------------------------
So does this essentially mean that we drop the ConversationAwareViewHandler and ask users
to do a <f:param name="cid"
value="#{javax.enterprise.context.conversation}"/> (which will be
automatically appended by JSF?)
Or should we keep the CAVH and add the cid only for non-transient conversations?
Or something else?
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Nicklas Karlsson commented on WELD-549:
---------------------------------------
#{javax.enterprise.context.conversation.id} in the previous comment
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
The spec requires an explicit f:param for h:link.
Automatic add should be part of the Seam navigation system.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:54 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont commented on WELD-549:
-------------------------------------
I think changing the behaviour according to whether there is a long-running conversation
would be confusing. Imagine a navigation bar with h:links to different parts of your site
that is stored in a template or otherwise included into the current view. On views where
there is not a long-running conversation these links would not include the cid; On views
where there is, the cid parameter would be automatically added, possibly changing how the
target page of the h:link functions.
Suppose a site has a search list page and an entity home page. The entity home page has a
long-running conversation so users can save changes. This means that an h:link back to the
list page propagates the conversation. The user then clicks on a second entity, but is
very confused to see the first entity they just looked at again, because the conversation
has propagated right round a loop of views. Since I am waiting for a working JBAS6 to test
on, my understanding of how you would write a CDI crud application is probably lacking.
Changing the behaviour with Seam would be a bit strange too - adding Seam to your CDI
application could make it function differently, perhaps wrongly, without having changed a
single line of code.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:49 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
Of course, you would need to tell Seam to add the cid propagation automatically :-)
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
David Beaumont commented on WELD-549:
-------------------------------------
Ah, that sounds perfect. Thanks Pete.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.0.2.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:19 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
Nik, any updates to this?
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.1.0.BETA1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:06 a.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir updated WELD-549:
---------------------------
Fix Version/s: 1.1.0.BETA2
(was: 1.1.0.BETA1)
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Nicklas Karlsson
Fix For: 1.1.0.BETA2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:51 a.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir updated WELD-549:
---------------------------
Assignee: (was: Nicklas Karlsson)
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Fix For: 1.1.0.BETA2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:10 a.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir updated WELD-549:
---------------------------
Priority: Critical (was: Major)
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Priority: Critical
Fix For: 1.1.0.BETA2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:19 p.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Marcel Kolsteren commented on WELD-549:
---------------------------------------
Just a comment related to the possibility of dropping the ConversationAwareViewHandler.
The getActionURL method now covers four cases:
1. form actions
2. link hrefs
3. Ajax calls, and
4. redirect URLs
According the the Weld documentation (5.3.2. Conversation propagation), the conversation
is automatically propagated in all cases except 2. So I think dropping the
ConversationAwareViewHandler is only possible if there is another solution for covering 1,
3 and 4.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:35 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Marcel Kolsteren commented on WELD-549:
---------------------------------------
Some more analysis. The JSF 2.0 version of the ViewHandler class has two new methods for
generating bookmarkable and redirect URLs, which are not in JSF 1.2. In JSF 2.0, the four
cases of my previous post map to the following ViewHandler methods:
1. getActionURL
2. getBookmarkableURL
3. getActionURL
4. getRedirectURL
Remark that in Mojorra's view handler implementation (MultiViewHandler), both
getBookmarkableURL and getRedirectURL call getActionURL on the installed view handler.
That's why Dan could cover all four cases, by only overriding the getActionURL method
(I hope this is portable to other JSF implementations).
How to prevent that getBookmarkableURL adds the cid parameter? I think that a solution
would be to change ConversationAwareViewHandler so that it not only overrides
getActionURL, but also getBookmarkableURL. The ConversationAwareViewHandler could be a
copy of MultiViewHandler.getBookmarkableURL, where getActionURL is called on the delegate
instead of on the installed view handler.
Unfortunately, there is a difficulty: the Weld core is built against the JSF 1.2 API,
which doesn't contain the getBookmarkableURL method, so how to override it?
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Marcel Kolsteren edited comment on WELD-549 at 9/16/10 3:36 PM:
----------------------------------------------------------------
Some more analysis. The JSF 2.0 version of the ViewHandler class has two new methods for
generating bookmarkable and redirect URLs, which are not in JSF 1.2. In JSF 2.0, the four
cases of my previous post map to the following ViewHandler methods:
1. getActionURL
2. getBookmarkableURL
3. getActionURL
4. getRedirectURL
Remark that in Mojorra's view handler implementation (MultiViewHandler), both
getBookmarkableURL and getRedirectURL call getActionURL on the installed view handler.
That's why Dan could cover all four cases, by only overriding the getActionURL method
(I hope this is portable to other JSF implementations).
How to prevent that getBookmarkableURL adds the cid parameter? I think that a solution
would be to change ConversationAwareViewHandler so that it not only overrides
getActionURL, but also getBookmarkableURL. This override could be a copy of
MultiViewHandler.getBookmarkableURL, where getActionURL is called on the delegate instead
of on the installed view handler.
Unfortunately, there is a difficulty: the Weld core is built against the JSF 1.2 API,
which doesn't contain the getBookmarkableURL method, so how to override it?
was (Author: marcelkolsteren):
Some more analysis. The JSF 2.0 version of the ViewHandler class has two new methods
for generating bookmarkable and redirect URLs, which are not in JSF 1.2. In JSF 2.0, the
four cases of my previous post map to the following ViewHandler methods:
1. getActionURL
2. getBookmarkableURL
3. getActionURL
4. getRedirectURL
Remark that in Mojorra's view handler implementation (MultiViewHandler), both
getBookmarkableURL and getRedirectURL call getActionURL on the installed view handler.
That's why Dan could cover all four cases, by only overriding the getActionURL method
(I hope this is portable to other JSF implementations).
How to prevent that getBookmarkableURL adds the cid parameter? I think that a solution
would be to change ConversationAwareViewHandler so that it not only overrides
getActionURL, but also getBookmarkableURL. The ConversationAwareViewHandler could be a
copy of MultiViewHandler.getBookmarkableURL, where getActionURL is called on the delegate
instead of on the installed view handler.
Unfortunately, there is a difficulty: the Weld core is built against the JSF 1.2 API,
which doesn't contain the getBookmarkableURL method, so how to override it?
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
We can still add the method to the view handler, it will be ignored in JSF 1.2
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 a.m.
New subject: [JBoss JIRA] Assigned: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir reassigned WELD-549:
------------------------------
Assignee: Pete Muir
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Pete Muir
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Marcel Kolsteren commented on WELD-549:
---------------------------------------
Didn't think of that. Just without an @Override, that should work indeed. Cool!
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Pete Muir
Priority: Critical
Fix For: 1.1.0.Beta2
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:57 p.m.
New subject: [JBoss JIRA] Updated: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir updated WELD-549:
---------------------------
Fix Version/s: 1.1.0.CR1
(was: 1.1.0.Beta2)
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Pete Muir
Priority: Critical
Fix For: 1.1.0.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 a.m.
New subject: [JBoss JIRA] Commented: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir commented on WELD-549:
--------------------------------
Initial work at https://github.com/pmuir/weld-core/tree/WELD-549
Unfortunately this is not sufficient as it interferes with redirect URLs, and we can't
revert to Seam 2 behavior as we need conversations active during restore view.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Pete Muir
Priority: Critical
Fix For: 1.1.0.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:39 a.m.
New subject: [JBoss JIRA] Assigned: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir reassigned WELD-549:
------------------------------
Assignee: Dan Allen (was: Pete Muir)
Dan, can you take a look at this? the new test
org.jboss.weld.tests.contexts.conversation.ClientConversationContextTest.testConversationNotPropagatedByHLink()
needs to pass.
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Dan Allen
Priority: Critical
Fix For: 1.1.0.CR1
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:08 a.m.
New subject: [JBoss JIRA] Closed: (WELD-549) Conversation propagated by default with h:link
[
https://jira.jboss.org/browse/WELD-549?page=com.atlassian.jira.plugin.sys...
]
Pete Muir closed WELD-549.
--------------------------
Assignee: Pete Muir (was: Dan Allen)
Fix Version/s: 1.1.0.Beta3
(was: 1.1.0.CR1)
Resolution: Done
Conversation propagated by default with h:link
----------------------------------------------
Key: WELD-549
URL: https://jira.jboss.org/browse/WELD-549
Project: Weld
Issue Type: Bug
Components: Web Tier integration (JSF, JSP, EL and Servlet)
Affects Versions: 1.0.1.Final
Environment: GlassFish Server Open Source Edition 3.0.1 on Mac OS 10.6 and
Windows 7. WELD-000900 1.0.1 (SP2)
Reporter: David Beaumont
Assignee: Pete Muir
Priority: Critical
Fix For: 1.1.0.Beta3
Attachments: CdiConvoBug.war
I created a long running conversation by running a method on a conversation scoped bean:
private boolean initialized;
public void init() {
if(initialized) return;
conversation.begin();
initialized = true;
}
From a facelets page using the JSF2 event system:
<f:metadata>
<f:event type="preRenderView" listener="#{convoBean.init}" />
</f:metadata>
If a conversation has been made long-running, the h:link tag will produce links with the
conversation query parameter, thereby propagating the conversation whether that was what
you wanted or not.
I.e:
<p>Link: <h:link outcome="page2.xhtml" value="a link"
/></p>
produces
<p>Link: <a href="/CdiConvoBug/page2.jsf?cid=3">a
link</a></p>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4901
days inactive
5082
days old
26 comments
4 participants
participants (4)
-
David Beaumont (JIRA) -
Marcel Kolsteren (JIRA)
-
Nicklas Karlsson (JIRA)
-
Pete Muir (JIRA)