Re: [wildfly-dev] Powershell scripts
On Tue, Sep 29, 2015 at 10:37 PM, James Perkins <jperkins(a)redhat.com> wrote:
The one concern I do have is with the --background bit. We do create a PID
file for the LAUNCH_IN_BACKGROUND, but it doesn't make sense to me why we
do. That's off topic for this though :) We don't seem to use these files
for anything so I just don't see the point in creating them.
Anyway, the whole PID thing I think needs to be thought about. With the
current behavior in the bash scripts it doesn't exit until the background
process has been stopped. I can't really tell what the PS scripts do with
the launch in background. Does the script exit or pause until the process
is exited?
the LAUNCH_IN_BACKGROUND & --background do the same thing, only difference
is that one is command line parameter other is in the config file.
We use pid file to check if the process is already running and complain if
is instead of starting the server directly.
Powershell script does exit after background process is started, which
feels like proper behavior.
The current behavior in bash scripts looks bit erratic as Rosta figured out
today that .sh script doesn't exit after it is running in background,
confusing/strangely behaving part of is related to cleaning up the pid
file, which is done bit differently in ps scripts...
But anyhow, lets discuss details on hipchat,
Tomaz
Attachments:
- attachment.html (text/html — 2.0 KB)