On Tue, Sep 29, 2015 at 4:06 PM, Tomaž Cerar <tomaz.cerar(a)gmail.com> wrote:
On Tue, Sep 29, 2015 at 10:37 PM, James Perkins <jperkins(a)redhat.com> wrote:
> The one concern I do have is with the --background bit. We do create a PID file for
the LAUNCH_IN_BACKGROUND, but it doesn't make sense to me why we do. That's off
topic for this though :) We don't seem to use these files for anything so I just
don't see the point in creating them.
> Anyway, the whole PID thing I think needs to be thought about. With the current
behavior in the bash scripts it doesn't exit until the background process has been
stopped. I can't really tell what the PS scripts do with the launch in background.
Does the script exit or pause until the process is exited?
the LAUNCH_IN_BACKGROUND & --background do the same thing, only difference is that
one is command line parameter other is in the config file.
We use pid file to check if the process is already running and complain if is instead of
starting the server directly.
Powershell script does exit after background process is started, which feels like proper
We need to understand why the bash scripts don't exit after a new
process is launched. Yes it feels wrong to me which is why I was
complaining about it on Friday :) That doesn't mean the behavior is
wrong though. It also may make sense to have the bash scripts not exit
and the Powershell scripts exit. We need to try to figure out why it
might be setup like that first before assuming we just need to exit.
The current behavior in bash scripts looks bit erratic as Rosta figured out today that
.sh script doesn't exit after it is running in background,
confusing/strangely behaving part of is related to cleaning up the pid file, which is
done bit differently in ps scripts...
Right this is my concern. The behavior is different as the bash
scripts don't exit. They wait for the process to end. Maybe it's
correct to be different, I don't know.
But anyhow, lets discuss details on hipchat,
James R. Perkins
JBoss by Red Hat