3:54 a.m.
Generated an app as ...
mvn archetype:generate -DgroupId=test -DartifactId=test
-DarchetypeGroupId=org.wildfly.archetype
-DarchetypeArtifactId=wildfly-javaee7-webapp-blank-archetype
-DarchetypeVersion=8.1.0.Final
The app has the following files:
./src/main/webapp/WEB-INF/beans.xml
./src/main/webapp/WEB-INF/faces-config.xml
./src/main/webapp/WEB-INF/test-ds.xml
- beans.xml and faces-config.xml are using java.sun.com-style
namespaces instead of xmlns.jcp.org-style namespaces.
Filed as https://issues.jboss.org/browse/WFLY-4030
- What is the purpose of test-ds.xml ? It contains:
<datasources xmlns="http://www.jboss.org/ironjacamar/schema"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.jboss.org/ironjacamar/schema
http://docs.jboss.org/ironjacamar/schema/datasources_1_0.xsd">
<!-- The datasource is bound into JNDI at this location. We reference
this in META-INF/persistence.xml -->
<datasource jndi-name="java:jboss/datasources/testDS"
pool-name="test" enabled="true"
use-java-context="true">
<connection-url>jdbc:h2:mem:test;DB_CLOSE_ON_EXIT=FALSE;DB_CLOSE_DELAY=-1</connection-url>
<driver>h2</driver>
<security>
<user-name>sa</user-name>
<password>sa</password>
</security>
</datasource>
</datasources>
This is anyway the default Java EE 7 data source in WildFly.
- src/main/META-INF/persistence.xml refers to this datasource. That
can be removed as well because of the default Java EE 7 data source.
Seems like these are left overs from previous time ?
Can this be cleaned up ? Xavier and I are planning to use this
archetype for our talk at Devoxx in the next few days and would like a
cleaner generated app.
Arun
--
http://blog.arungupta.me
http://twitter.com/arungupta
5:28 p.m.
Hey
I would like to volunteer for WFLY-4030 and a Quickstarts change: WFLY-4031.
However I'm not sure about removing test-ds.xml. Maybe the point is to
show how to add DataSources bundled with the application?
On the other hand if this is not the point - I think we should change it
to ExampleDS.
What's your opinion on that?
Best regards
Sebastian
On 10/29/2014 07:54 PM, Arun Gupta wrote:
- What is the purpose of test-ds.xml ? It contains:
This is anyway the default Java EE 7 data source in WildFly.
9:04 p.m.
For Java EE 7, a default data source is available if none is specified
in persistence.xml. In WildFly, this is mapped to ExampleDS already.
Does test-ds.xml create a new data source, or map to an existing one ?
Arun
On Thu, Oct 30, 2014 at 1:28 AM, Sebastian Łaskawiec
<slaskawi(a)redhat.com> wrote:
Hey
I would like to volunteer for WFLY-4030 and a Quickstarts change: WFLY-4031.
However I'm not sure about removing test-ds.xml. Maybe the point is to
show how to add DataSources bundled with the application?
On the other hand if this is not the point - I think we should change it
to ExampleDS.
What's your opinion on that?
Best regards
Sebastian
On 10/29/2014 07:54 PM, Arun Gupta wrote:
> - What is the purpose of test-ds.xml ? It contains:
> This is anyway the default Java EE 7 data source in WildFly.
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
http://blog.arungupta.me
http://twitter.com/arungupta
10:01 p.m.
Hi Arun!
Wildfly archetypes are created based on Quickstarts (just as Rafael
mentioned here [1]).
In case of *wildfly-**javaee7-webapp-blank-archetype* it is *kitchensink*
[1]. Quickstarts are designed in such a way, that they can be deployed all
together (this is why they need separate datasources).
So, test-ds.xml is a design consequence of how Quickstarts are embedded
into archetypes. In my opinion we won't be able to get rid of it.
Alternatively we could refactor all quickstarts to use default database -
which might be pretty time consuming.
Best regards
Sebastian
[1] https://issues.jboss.org/browse/WFLY-4030?focusedCommentId=13016156
[2] https://github.com/wildfly/quickstart/tree/master/kitchensink
2014-10-30 13:04 GMT+01:00 Arun Gupta <arun.gupta(a)gmail.com>:
For Java EE 7, a default data source is available if none is
specified
in persistence.xml. In WildFly, this is mapped to ExampleDS already.
Does test-ds.xml create a new data source, or map to an existing one ?
Arun
On Thu, Oct 30, 2014 at 1:28 AM, Sebastian Łaskawiec
<slaskawi(a)redhat.com> wrote:
> Hey
>
> I would like to volunteer for WFLY-4030 and a Quickstarts change:
WFLY-4031.
>
> However I'm not sure about removing test-ds.xml. Maybe the point is to
> show how to add DataSources bundled with the application?
> On the other hand if this is not the point - I think we should change it
> to ExampleDS.
>
> What's your opinion on that?
>
> Best regards
> Sebastian
>
> On 10/29/2014 07:54 PM, Arun Gupta wrote:
>> - What is the purpose of test-ds.xml ? It contains:
>> This is anyway the default Java EE 7 data source in WildFly.
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
http://blog.arungupta.me
http://twitter.com/arungupta
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
Sebastian Łaskawiec
10:07 p.m.
Default data sources is one of the new features of Java EE 7 and I think
its worth showcasing how apps can be simplified with that. I'll let you
decide upon resource/time but its useful IMHO.
Arun
On Fri Oct 31 2014 at 6:01:34 AM Sebastian Łaskawiec <
sebastian.laskawiec(a)gmail.com> wrote:
Hi Arun!
Wildfly archetypes are created based on Quickstarts (just as Rafael
mentioned here [1]).
In case of *wildfly-**javaee7-webapp-blank-archetype* it is *kitchensink*
[1]. Quickstarts are designed in such a way, that they can be deployed all
together (this is why they need separate datasources).
So, test-ds.xml is a design consequence of how Quickstarts are embedded
into archetypes. In my opinion we won't be able to get rid of it.
Alternatively we could refactor all quickstarts to use default database -
which might be pretty time consuming.
Best regards
Sebastian
[1] https://issues.jboss.org/browse/WFLY-4030?focusedCommentId=13016156
[2] https://github.com/wildfly/quickstart/tree/master/kitchensink
2014-10-30 13:04 GMT+01:00 Arun Gupta <arun.gupta(a)gmail.com>:
> For Java EE 7, a default data source is available if none is specified
> in persistence.xml. In WildFly, this is mapped to ExampleDS already.
>
> Does test-ds.xml create a new data source, or map to an existing one ?
>
> Arun
>
> On Thu, Oct 30, 2014 at 1:28 AM, Sebastian Łaskawiec
> <slaskawi(a)redhat.com> wrote:
> > Hey
> >
> > I would like to volunteer for WFLY-4030 and a Quickstarts change:
> WFLY-4031.
> >
> > However I'm not sure about removing test-ds.xml. Maybe the point is to
> > show how to add DataSources bundled with the application?
> > On the other hand if this is not the point - I think we should change it
> > to ExampleDS.
> >
> > What's your opinion on that?
> >
> > Best regards
> > Sebastian
> >
> > On 10/29/2014 07:54 PM, Arun Gupta wrote:
> >> - What is the purpose of test-ds.xml ? It contains:
> >> This is anyway the default Java EE 7 data source in WildFly.
> >
> > _______________________________________________
> > wildfly-dev mailing list
> > wildfly-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>
> --
> http://blog.arungupta.me
> http://twitter.com/arungupta
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
--
Sebastian Łaskawiec
6:23 p.m.
I would consider it best practice that you have a way to separate what
database you run against and what database you test against.
Using -test.ds.xml is a way to achieve that in a way that works in all
cases without requiring property replacement magic doing development
afair.
/max
Default data sources is one of the new features of Java EE 7 and I
think
its worth showcasing how apps can be simplified with that. I'll let
you
decide upon resource/time but its useful IMHO.
Arun
On Fri Oct 31 2014 at 6:01:34 AM Sebastian Łaskawiec <
sebastian.laskawiec(a)gmail.com> wrote:
> Hi Arun!
>
> Wildfly archetypes are created based on Quickstarts (just as Rafael
> mentioned here [1]).
> In case of *wildfly-**javaee7-webapp-blank-archetype* it is
> *kitchensink*
> [1]. Quickstarts are designed in such a way, that they can be
> deployed all
> together (this is why they need separate datasources).
>
> So, test-ds.xml is a design consequence of how Quickstarts are
> embedded
> into archetypes. In my opinion we won't be able to get rid of it.
> Alternatively we could refactor all quickstarts to use default
> database -
> which might be pretty time consuming.
>
> Best regards
> Sebastian
>
> [1]
> https://issues.jboss.org/browse/WFLY-4030?focusedCommentId=13016156
> [2] https://github.com/wildfly/quickstart/tree/master/kitchensink
>
>
> 2014-10-30 13:04 GMT+01:00 Arun Gupta <arun.gupta(a)gmail.com>:
>
>> For Java EE 7, a default data source is available if none is
>> specified
>> in persistence.xml. In WildFly, this is mapped to ExampleDS already.
>>
>> Does test-ds.xml create a new data source, or map to an existing one
>> ?
>>
>> Arun
>>
>> On Thu, Oct 30, 2014 at 1:28 AM, Sebastian Łaskawiec
>> <slaskawi(a)redhat.com> wrote:
>>> Hey
>>>
>>> I would like to volunteer for WFLY-4030 and a Quickstarts change:
>> WFLY-4031.
>>>
>>> However I'm not sure about removing test-ds.xml. Maybe the point is
>>> to
>>> show how to add DataSources bundled with the application?
>>> On the other hand if this is not the point - I think we should
>>> change it
>>> to ExampleDS.
>>>
>>> What's your opinion on that?
>>>
>>> Best regards
>>> Sebastian
>>>
>>> On 10/29/2014 07:54 PM, Arun Gupta wrote:
>>>> - What is the purpose of test-ds.xml ? It contains:
>>>> This is anyway the default Java EE 7 data source in WildFly.
>>>
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>>
>>
>> --
>> http://blog.arungupta.me
>> http://twitter.com/arungupta
>>
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>
>
>
> --
> Sebastian Łaskawiec
>
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
/max
http://about.me/maxandersen
8:48 a.m.
I don't think people are going to want to run (non toy) apps against our
built in h2 server, which means they will want to define their own
datasource. Leaving this file in the quickstart provides them with an easy
template to work from.
Stuart
On Sat, Nov 1, 2014 at 12:07 AM, Arun Gupta <arun.gupta(a)gmail.com> wrote:
Default data sources is one of the new features of Java EE 7 and I
think
its worth showcasing how apps can be simplified with that. I'll let you
decide upon resource/time but its useful IMHO.
Arun
On Fri Oct 31 2014 at 6:01:34 AM Sebastian Łaskawiec <
sebastian.laskawiec(a)gmail.com> wrote:
> Hi Arun!
>
> Wildfly archetypes are created based on Quickstarts (just as Rafael
> mentioned here [1]).
> In case of *wildfly-**javaee7-webapp-blank-archetype* it is *kitchensink*
> [1]. Quickstarts are designed in such a way, that they can be deployed all
> together (this is why they need separate datasources).
>
> So, test-ds.xml is a design consequence of how Quickstarts are embedded
> into archetypes. In my opinion we won't be able to get rid of it.
> Alternatively we could refactor all quickstarts to use default database -
> which might be pretty time consuming.
>
> Best regards
> Sebastian
>
> [1] https://issues.jboss.org/browse/WFLY-4030?focusedCommentId=13016156
> [2] https://github.com/wildfly/quickstart/tree/master/kitchensink
>
>
> 2014-10-30 13:04 GMT+01:00 Arun Gupta <arun.gupta(a)gmail.com>:
>
>> For Java EE 7, a default data source is available if none is specified
>> in persistence.xml. In WildFly, this is mapped to ExampleDS already.
>>
>> Does test-ds.xml create a new data source, or map to an existing one ?
>>
>> Arun
>>
>> On Thu, Oct 30, 2014 at 1:28 AM, Sebastian Łaskawiec
>> <slaskawi(a)redhat.com> wrote:
>> > Hey
>> >
>> > I would like to volunteer for WFLY-4030 and a Quickstarts change:
>> WFLY-4031.
>> >
>> > However I'm not sure about removing test-ds.xml. Maybe the point is to
>> > show how to add DataSources bundled with the application?
>> > On the other hand if this is not the point - I think we should change
>> it
>> > to ExampleDS.
>> >
>> > What's your opinion on that?
>> >
>> > Best regards
>> > Sebastian
>> >
>> > On 10/29/2014 07:54 PM, Arun Gupta wrote:
>> >> - What is the purpose of test-ds.xml ? It contains:
>> >> This is anyway the default Java EE 7 data source in WildFly.
>> >
>> > _______________________________________________
>> > wildfly-dev mailing list
>> > wildfly-dev(a)lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>>
>>
>> --
>> http://blog.arungupta.me
>> http://twitter.com/arungupta
>>
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>
>
>
> --
> Sebastian Łaskawiec
>
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
3474
days inactive
3478
days old
6 comments
5 participants
participants (5)
-
Arun Gupta -
Max Rydahl Andersen -
Sebastian Łaskawiec -
Sebastian Łaskawiec -
Stuart Douglas