4:58 p.m.
Hey guys,
just wondering if wildfly-arquillian-container-embedded was discontinued
with split of 9.x:
https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
When working on a re-enablement, I found out that even though arq adapter
now depends on wildfly-core/embedded, particularly
on EmbeddedServerFactory, this class has its counterpart in
wildfly/embedded as well.
Question is, should be embedded arquillian container still available for
9.x?
If yes, I can continue and provide a PR, just I will need a bit of guidance
with what EmbeddedServerFactory it should actually use (if that matters).
Cheers,
~ Lukas
--
Lukas Fryc
AeroGear Core Developer
Red Hat
3:47 p.m.
Hi Lukas,
On 4/29/15 9:58 AM, Lukas Fryc wrote:
Hey guys,
just wondering if wildfly-arquillian-container-embedded was discontinued
with split of 9.x:
https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
avoid a circular dependency) and WildFly Core didn't have an embedding
module.
When working on a re-enablement, I found out that even though arq
adapter now depends on wildfly-core/embedded, particularly
on EmbeddedServerFactory, this class has its counterpart in
wildfly/embedded as well.
I added the wildfly-core/embedded module in order to support the Offline
CLI.[1] At this point I consider it to be an internal module, not
public API. I expect that will soften over time, but for WildFly Core
1.0 / WildFly Full 9.0 at least, that's what it is.
[1] http://wildfly.org/news/2015/03/13/Offline-CLI/
Question is, should be embedded arquillian container still available
for
9.x?
Jason Greene would need to rule on that, but I know we were ok with
dropping it before. Is there much use of it?
If yes, I can continue and provide a PR, just I will need a bit of
guidance with what EmbeddedServerFactory it should actually use (if that
matters).
What API would it need from wildfly-core/embedded? Is the
StandaloneServer API there adequate?
Cheers,
~ Lukas
--
Lukas Fryc
AeroGear Core Developer
Red Hat
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
7:57 p.m.
Hi,
Am 30.04.2015 um 15:47 schrieb Brian Stansberry
<brian.stansberry(a)redhat.com>:
[1] http://wildfly.org/news/2015/03/13/Offline-CLI/
<http://wildfly.org/news/2015/03/13/Offline-CLI/>
> Question is, should be embedded arquillian container still available for
> 9.x?
>
Jason Greene would need to rule on that, but I know we were ok with
dropping it before. Is there much use of it?
One thing I use the embedded module is for our jenkins build because we have no access to
a managed or remote WildFly instance on that machine, so yeah I would like to see a
working plugin for future versions of WildFly, otherwise I either need to drop my
integration tests or stick with 8.2 instead.
Regards,
Daniel
8:05 p.m.
If you're using maven you could download the wildfly-dist ZIP and unzip
it into a directory. This would have the advantage of using the correct
target runtime you're using too.
Example:
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-wildfly</id>
<phase>process-test-classes</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.wildfly</groupId>
<artifactId>wildfly-dist</artifactId>
<version>${version.org.wildfly.dist}</version>
<type>zip</type>
<!-- overwrite to clean any previous
deployments -->
<overWrite>true</overWrite>
<outputDirectory>${project.build.directory}</outputDirectory>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
On 04/30/2015 10:57 AM, Daniel Kreuter wrote:
Hi,
> Am 30.04.2015 um 15:47 schrieb Brian Stansberry
> <brian.stansberry(a)redhat.com <mailto:brian.stansberry@redhat.com>>:
>
>
> [1]http://wildfly.org/news/2015/03/13/Offline-CLI/
>
>> Question is, should be embedded arquillian container still available for
>> 9.x?
>>
>
> Jason Greene would need to rule on that, but I know we were ok with
> dropping it before. Is there much use of it?
One thing I use the embedded module is for our jenkins build because
we have no access to a managed or remote WildFly instance on that
machine, so yeah I would like to see a working plugin for future
versions of WildFly, otherwise I either need to drop my integration
tests or stick with 8.2 instead.
Regards,
Daniel
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
James R. Perkins
JBoss by Red Hat
8:06 p.m.
On 4/30/15 12:57 PM, Daniel Kreuter wrote:
Hi,
> Am 30.04.2015 um 15:47 schrieb Brian Stansberry
> <brian.stansberry(a)redhat.com <mailto:brian.stansberry@redhat.com>>:
>
>
> [1]http://wildfly.org/news/2015/03/13/Offline-CLI/
>
>> Question is, should be embedded arquillian container still available for
>> 9.x?
>>
>
> Jason Greene would need to rule on that, but I know we were ok with
> dropping it before. Is there much use of it?
One thing I use the embedded module is for our jenkins build because we
have no access to a managed or remote WildFly instance on that machine,
I'm curious why not. A maven-based testsuite can spin up a managed
container.
so yeah I would like to see a working plugin for future versions of
WildFly, otherwise I either need to drop my integration tests or stick
with 8.2 instead.
Regards,
Daniel
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
11:28 a.m.
An only embedded container's advantage over managed container is a simpler
test debugging - no special setup required.
I'm fine with dropping it, just in case it wasn't intentional decision to
remove embedded container, we can re-introduce it.
~ Lukas
On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry <
brian.stansberry(a)redhat.com> wrote:
Hi Lukas,
On 4/29/15 9:58 AM, Lukas Fryc wrote:
> Hey guys,
>
> just wondering if wildfly-arquillian-container-embedded was discontinued
> with split of 9.x:
>
> https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>
It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
avoid a circular dependency) and WildFly Core didn't have an embedding
module.
>
> When working on a re-enablement, I found out that even though arq
> adapter now depends on wildfly-core/embedded, particularly
> on EmbeddedServerFactory, this class has its counterpart in
> wildfly/embedded as well.
>
I added the wildfly-core/embedded module in order to support the Offline
CLI.[1] At this point I consider it to be an internal module, not
public API. I expect that will soften over time, but for WildFly Core
1.0 / WildFly Full 9.0 at least, that's what it is.
[1] http://wildfly.org/news/2015/03/13/Offline-CLI/
> Question is, should be embedded arquillian container still available for
> 9.x?
>
Jason Greene would need to rule on that, but I know we were ok with
dropping it before. Is there much use of it?
> If yes, I can continue and provide a PR, just I will need a bit of
> guidance with what EmbeddedServerFactory it should actually use (if that
> matters).
>
What API would it need from wildfly-core/embedded? Is the
StandaloneServer API there adequate?
>
> Cheers,
>
> ~ Lukas
>
> --
> Lukas Fryc
> AeroGear Core Developer
> Red Hat
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
1:35 p.m.
Is there a good example published somewhere for users who want to use a
managed container within a CI like Travis?
This is becoming an increasingly pretty popular configuration, and the
easier for the users to get started and update from release to release the
better.
-C
On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com> wrote:
An only embedded container's advantage over managed container is
a simpler
test debugging - no special setup required.
I'm fine with dropping it, just in case it wasn't intentional decision to
remove embedded container, we can re-introduce it.
~ Lukas
On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry <
brian.stansberry(a)redhat.com> wrote:
> Hi Lukas,
>
> On 4/29/15 9:58 AM, Lukas Fryc wrote:
> > Hey guys,
> >
> > just wondering if wildfly-arquillian-container-embedded was discontinued
> > with split of 9.x:
> >
> > https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
> >
>
> It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
> avoid a circular dependency) and WildFly Core didn't have an embedding
> module.
> >
> > When working on a re-enablement, I found out that even though arq
> > adapter now depends on wildfly-core/embedded, particularly
> > on EmbeddedServerFactory, this class has its counterpart in
> > wildfly/embedded as well.
> >
>
> I added the wildfly-core/embedded module in order to support the Offline
> CLI.[1] At this point I consider it to be an internal module, not
> public API. I expect that will soften over time, but for WildFly Core
> 1.0 / WildFly Full 9.0 at least, that's what it is.
>
> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>
> > Question is, should be embedded arquillian container still available for
> > 9.x?
> >
>
> Jason Greene would need to rule on that, but I know we were ok with
> dropping it before. Is there much use of it?
>
> > If yes, I can continue and provide a PR, just I will need a bit of
> > guidance with what EmbeddedServerFactory it should actually use (if that
> > matters).
> >
>
> What API would it need from wildfly-core/embedded? Is the
> StandaloneServer API there adequate?
>
> >
> > Cheers,
> >
> > ~ Lukas
> >
> > --
> > Lukas Fryc
> > AeroGear Core Developer
> > Red Hat
> >
> >
> > _______________________________________________
> > wildfly-dev mailing list
> > wildfly-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
> >
>
>
> --
> Brian Stansberry
> Senior Principal Software Engineer
> JBoss by Red Hat
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
1:58 p.m.
Hey Cody,
I know Aslak and Alex Soto work on a "proxy container" that will allow you
to seamlessly switch between EAP/JBossAS/WildFly:
https://github.com/lordofthejars/arquillian-container-proxy
That impl should auto-download configured container and run in managed mode.
Btw the name is not set in stone yet.. :-)
On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum(a)gmail.com> wrote:
Is there a good example published somewhere for users who want to use
a
managed container within a CI like Travis?
This is becoming an increasingly pretty popular configuration, and the
easier for the users to get started and update from release to release the
better.
-C
On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com> wrote:
> An only embedded container's advantage over managed container is a
> simpler test debugging - no special setup required.
>
> I'm fine with dropping it, just in case it wasn't intentional decision to
> remove embedded container, we can re-introduce it.
>
> ~ Lukas
>
> On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry <
> brian.stansberry(a)redhat.com> wrote:
>
>> Hi Lukas,
>>
>> On 4/29/15 9:58 AM, Lukas Fryc wrote:
>> > Hey guys,
>> >
>> > just wondering if wildfly-arquillian-container-embedded was
>> discontinued
>> > with split of 9.x:
>> >
>> > https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>> >
>>
>> It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
>> avoid a circular dependency) and WildFly Core didn't have an embedding
>> module.
>> >
>> > When working on a re-enablement, I found out that even though arq
>> > adapter now depends on wildfly-core/embedded, particularly
>> > on EmbeddedServerFactory, this class has its counterpart in
>> > wildfly/embedded as well.
>> >
>>
>> I added the wildfly-core/embedded module in order to support the Offline
>> CLI.[1] At this point I consider it to be an internal module, not
>> public API. I expect that will soften over time, but for WildFly Core
>> 1.0 / WildFly Full 9.0 at least, that's what it is.
>>
>> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>>
>> > Question is, should be embedded arquillian container still available
>> for
>> > 9.x?
>> >
>>
>> Jason Greene would need to rule on that, but I know we were ok with
>> dropping it before. Is there much use of it?
>>
>> > If yes, I can continue and provide a PR, just I will need a bit of
>> > guidance with what EmbeddedServerFactory it should actually use (if
>> that
>> > matters).
>> >
>>
>> What API would it need from wildfly-core/embedded? Is the
>> StandaloneServer API there adequate?
>>
>> >
>> > Cheers,
>> >
>> > ~ Lukas
>> >
>> > --
>> > Lukas Fryc
>> > AeroGear Core Developer
>> > Red Hat
>> >
>> >
>> > _______________________________________________
>> > wildfly-dev mailing list
>> > wildfly-dev(a)lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>> >
>>
>>
>> --
>> Brian Stansberry
>> Senior Principal Software Engineer
>> JBoss by Red Hat
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
2:34 p.m.
Guys,
I've sent PR https://github.com/wildfly/wildfly-arquillian/pull/18 that
adds back embedded arquillian container
which uses wildfly-core embedded api.
--
tomaz
On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum(a)gmail.com> wrote:
Is there a good example published somewhere for users who want to use
a
managed container within a CI like Travis?
This is becoming an increasingly pretty popular configuration, and the
easier for the users to get started and update from release to release the
better.
-C
On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com> wrote:
> An only embedded container's advantage over managed container is a
> simpler test debugging - no special setup required.
>
> I'm fine with dropping it, just in case it wasn't intentional decision to
> remove embedded container, we can re-introduce it.
>
> ~ Lukas
>
> On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry <
> brian.stansberry(a)redhat.com> wrote:
>
>> Hi Lukas,
>>
>> On 4/29/15 9:58 AM, Lukas Fryc wrote:
>> > Hey guys,
>> >
>> > just wondering if wildfly-arquillian-container-embedded was
>> discontinued
>> > with split of 9.x:
>> >
>> > https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>> >
>>
>> It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
>> avoid a circular dependency) and WildFly Core didn't have an embedding
>> module.
>> >
>> > When working on a re-enablement, I found out that even though arq
>> > adapter now depends on wildfly-core/embedded, particularly
>> > on EmbeddedServerFactory, this class has its counterpart in
>> > wildfly/embedded as well.
>> >
>>
>> I added the wildfly-core/embedded module in order to support the Offline
>> CLI.[1] At this point I consider it to be an internal module, not
>> public API. I expect that will soften over time, but for WildFly Core
>> 1.0 / WildFly Full 9.0 at least, that's what it is.
>>
>> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>>
>> > Question is, should be embedded arquillian container still available
>> for
>> > 9.x?
>> >
>>
>> Jason Greene would need to rule on that, but I know we were ok with
>> dropping it before. Is there much use of it?
>>
>> > If yes, I can continue and provide a PR, just I will need a bit of
>> > guidance with what EmbeddedServerFactory it should actually use (if
>> that
>> > matters).
>> >
>>
>> What API would it need from wildfly-core/embedded? Is the
>> StandaloneServer API there adequate?
>>
>> >
>> > Cheers,
>> >
>> > ~ Lukas
>> >
>> > --
>> > Lukas Fryc
>> > AeroGear Core Developer
>> > Red Hat
>> >
>> >
>> > _______________________________________________
>> > wildfly-dev mailing list
>> > wildfly-dev(a)lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>> >
>>
>>
>> --
>> Brian Stansberry
>> Senior Principal Software Engineer
>> JBoss by Red Hat
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
4:11 p.m.
Very interesting. This could greatly simplify users maven builds for CI.
-C
On Mon, May 4, 2015 at 5:58 AM, Lukas Fryc <lfryc(a)redhat.com> wrote:
Hey Cody,
I know Aslak and Alex Soto work on a "proxy container" that will allow you
to seamlessly switch between EAP/JBossAS/WildFly:
https://github.com/lordofthejars/arquillian-container-proxy
That impl should auto-download configured container and run in managed mode.
Btw the name is not set in stone yet.. :-)
On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum(a)gmail.com> wrote:
>
> Is there a good example published somewhere for users who want to use a
> managed container within a CI like Travis?
>
> This is becoming an increasingly pretty popular configuration, and the
> easier for the users to get started and update from release to release the
> better.
>
> -C
>
> On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com> wrote:
>>
>> An only embedded container's advantage over managed container is a
>> simpler test debugging - no special setup required.
>>
>> I'm fine with dropping it, just in case it wasn't intentional decision
to
>> remove embedded container, we can re-introduce it.
>>
>> ~ Lukas
>>
>> On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry
>> <brian.stansberry(a)redhat.com> wrote:
>>>
>>> Hi Lukas,
>>>
>>> On 4/29/15 9:58 AM, Lukas Fryc wrote:
>>> > Hey guys,
>>> >
>>> > just wondering if wildfly-arquillian-container-embedded was
>>> > discontinued
>>> > with split of 9.x:
>>> >
>>> > https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>>> >
>>>
>>> It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
>>> avoid a circular dependency) and WildFly Core didn't have an embedding
>>> module.
>>> >
>>> > When working on a re-enablement, I found out that even though arq
>>> > adapter now depends on wildfly-core/embedded, particularly
>>> > on EmbeddedServerFactory, this class has its counterpart in
>>> > wildfly/embedded as well.
>>> >
>>>
>>> I added the wildfly-core/embedded module in order to support the Offline
>>> CLI.[1] At this point I consider it to be an internal module, not
>>> public API. I expect that will soften over time, but for WildFly Core
>>> 1.0 / WildFly Full 9.0 at least, that's what it is.
>>>
>>> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>>>
>>> > Question is, should be embedded arquillian container still available
>>> > for
>>> > 9.x?
>>> >
>>>
>>> Jason Greene would need to rule on that, but I know we were ok with
>>> dropping it before. Is there much use of it?
>>>
>>> > If yes, I can continue and provide a PR, just I will need a bit of
>>> > guidance with what EmbeddedServerFactory it should actually use (if
>>> > that
>>> > matters).
>>> >
>>>
>>> What API would it need from wildfly-core/embedded? Is the
>>> StandaloneServer API there adequate?
>>>
>>> >
>>> > Cheers,
>>> >
>>> > ~ Lukas
>>> >
>>> > --
>>> > Lukas Fryc
>>> > AeroGear Core Developer
>>> > Red Hat
>>> >
>>> >
>>> > _______________________________________________
>>> > wildfly-dev mailing list
>>> > wildfly-dev(a)lists.jboss.org
>>> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>> >
>>>
>>>
>>> --
>>> Brian Stansberry
>>> Senior Principal Software Engineer
>>> JBoss by Red Hat
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>>
>>
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
9:06 a.m.
The embedded container works great with your PR!
Personally I'd say: ship it! :-)
Can someone review and merge?
On Mon, May 4, 2015 at 2:34 PM, Tomaž Cerar <tomaz.cerar(a)gmail.com> wrote:
Guys,
I've sent PR https://github.com/wildfly/wildfly-arquillian/pull/18 that
adds back embedded arquillian container
which uses wildfly-core embedded api.
--
tomaz
On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum(a)gmail.com> wrote:
> Is there a good example published somewhere for users who want to use a
> managed container within a CI like Travis?
>
> This is becoming an increasingly pretty popular configuration, and the
> easier for the users to get started and update from release to release the
> better.
>
> -C
> On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com> wrote:
>
>> An only embedded container's advantage over managed container is a
>> simpler test debugging - no special setup required.
>>
>> I'm fine with dropping it, just in case it wasn't intentional decision
>> to remove embedded container, we can re-introduce it.
>>
>> ~ Lukas
>>
>> On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry <
>> brian.stansberry(a)redhat.com> wrote:
>>
>>> Hi Lukas,
>>>
>>> On 4/29/15 9:58 AM, Lukas Fryc wrote:
>>> > Hey guys,
>>> >
>>> > just wondering if wildfly-arquillian-container-embedded was
>>> discontinued
>>> > with split of 9.x:
>>> >
>>> > https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>>> >
>>>
>>> It was, yes, as wildfly-arquillian shouldn't depend on WildFly Full (to
>>> avoid a circular dependency) and WildFly Core didn't have an embedding
>>> module.
>>> >
>>> > When working on a re-enablement, I found out that even though arq
>>> > adapter now depends on wildfly-core/embedded, particularly
>>> > on EmbeddedServerFactory, this class has its counterpart in
>>> > wildfly/embedded as well.
>>> >
>>>
>>> I added the wildfly-core/embedded module in order to support the Offline
>>> CLI.[1] At this point I consider it to be an internal module, not
>>> public API. I expect that will soften over time, but for WildFly Core
>>> 1.0 / WildFly Full 9.0 at least, that's what it is.
>>>
>>> [1] http://wildfly.org/news/2015/03/13/Offline-CLI/
>>>
>>> > Question is, should be embedded arquillian container still available
>>> for
>>> > 9.x?
>>> >
>>>
>>> Jason Greene would need to rule on that, but I know we were ok with
>>> dropping it before. Is there much use of it?
>>>
>>> > If yes, I can continue and provide a PR, just I will need a bit of
>>> > guidance with what EmbeddedServerFactory it should actually use (if
>>> that
>>> > matters).
>>> >
>>>
>>> What API would it need from wildfly-core/embedded? Is the
>>> StandaloneServer API there adequate?
>>>
>>> >
>>> > Cheers,
>>> >
>>> > ~ Lukas
>>> >
>>> > --
>>> > Lukas Fryc
>>> > AeroGear Core Developer
>>> > Red Hat
>>> >
>>> >
>>> > _______________________________________________
>>> > wildfly-dev mailing list
>>> > wildfly-dev(a)lists.jboss.org
>>> > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>> >
>>>
>>>
>>> --
>>> Brian Stansberry
>>> Senior Principal Software Engineer
>>> JBoss by Red Hat
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>
>>
>>
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
6:10 p.m.
On 5/6/15 2:06 AM, Lukas Fryc wrote:
The embedded container works great with your PR!
Personally I'd say: ship it! :-)
Can someone review and merge?
I'll need to get https://issues.jboss.org/browse/WFCORE-677 into WildFly
Core 1.0.0.CR2. And once that's there, Tomaz (or someone), please add a
commit getting rid of the "bundlePath" property from
https://github.com/wildfly/wildfly-arquillian/blob/master/container-embed...
Thanks.
On Mon, May 4, 2015 at 2:34 PM, Tomaž Cerar
<tomaz.cerar(a)gmail.com
<mailto:tomaz.cerar@gmail.com>> wrote:
Guys,
I've sent PR https://github.com/wildfly/wildfly-arquillian/pull/18
that adds back embedded arquillian container
which uses wildfly-core embedded api.
--
tomaz
On Mon, May 4, 2015 at 1:35 PM, Cody Lerum <cody.lerum(a)gmail.com
<mailto:cody.lerum@gmail.com>> wrote:
Is there a good example published somewhere for users who want
to use a managed container within a CI like Travis?
This is becoming an increasingly pretty popular configuration,
and the easier for the users to get started and update from
release to release the better.
-C
On May 4, 2015 3:28 AM, "Lukas Fryc" <lfryc(a)redhat.com
<mailto:lfryc@redhat.com>> wrote:
An only embedded container's advantage over managed
container is a simpler test debugging - no special setup
required.
I'm fine with dropping it, just in case it wasn't
intentional decision to remove embedded container, we can
re-introduce it.
~ Lukas
On Thu, Apr 30, 2015 at 3:47 PM, Brian Stansberry
<brian.stansberry(a)redhat.com
<mailto:brian.stansberry@redhat.com>> wrote:
Hi Lukas,
On 4/29/15 9:58 AM, Lukas Fryc wrote:
> Hey guys,
>
> just wondering if wildfly-arquillian-container-embedded was
discontinued
> with split of 9.x:
>
>https://github.com/wildfly/wildfly-arquillian/blob/master/pom.xml#L96
>
It was, yes, as wildfly-arquillian shouldn't depend on
WildFly Full (to
avoid a circular dependency) and WildFly Core didn't
have an embedding
module.
>
> When working on a re-enablement, I found out that even though arq
> adapter now depends on wildfly-core/embedded, particularly
> on EmbeddedServerFactory, this class has its counterpart in
> wildfly/embedded as well.
>
I added the wildfly-core/embedded module in order to
support the Offline
CLI.[1] At this point I consider it to be an internal
module, not
public API. I expect that will soften over time, but for
WildFly Core
1.0 / WildFly Full 9.0 at least, that's what it is.
[1] http://wildfly.org/news/2015/03/13/Offline-CLI/
> Question is, should be embedded arquillian container still available
for
> 9.x?
>
Jason Greene would need to rule on that, but I know we
were ok with
dropping it before. Is there much use of it?
> If yes, I can continue and provide a PR, just I will need a bit of
> guidance with what EmbeddedServerFactory it should actually use (if
that
> matters).
>
What API would it need from wildfly-core/embedded? Is the
StandaloneServer API there adequate?
>
> Cheers,
>
> ~ Lukas
>
> --
> Lukas Fryc
> AeroGear Core Developer
> Red Hat
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev(a)lists.jboss.org
<mailto:wildfly-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
<mailto:wildfly-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/wildfly-dev
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
Brian Stansberry
Senior Principal Software Engineer
JBoss by Red Hat
3278
days inactive
3285
days old
11 comments
6 participants
participants (6)
-
Brian Stansberry -
Cody Lerum -
Daniel Kreuter -
James R. Perkins -
Lukas Fryc -
Tomaž Cerar