6:42 a.m.
Hello,
I'd like to ask about the policy we want to use for the versioning schema. I've
raised a PR [1] that will check the project version and fails the build if it's wrong.
This should catch the releases with malformed versions. It's aligned with the JBoss
project versioning [2], however, it's not clear how to use the "-SNAPSHOT"
suffix. Peter has a good point in the PR comment that some use the x.y.z.Final-SNAPSHOT
(final can be also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when releasing, we
add the Final/Alpha, etc.
Looking into wildfly repo, they use the former method. Is this what we want? I personally
consider the latter method more natural and we use it in the inventory, despite the fact
the hawkular/hawkular uses the x.y.z.AlphaN-SNAPSHOT.
jk
[1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
[2]: https://developer.jboss.org/wiki/JBossProjectVersioning
7:57 a.m.
I like and use x.y.z.Final-SNAPSHOT if only because the mvn release plugin sets that all
automatically for you. You just hit <enter> at the prompts and go. If you use
x.y.x-SNAPSHOT you have to remember to change the value of the version at the mvn release
plugin prompt, which can lead to typos/fat-fingering the version string ;)
Make it easy on ourselves - just use x.y.z.ABC-SNAPSHOT - and let the mvn release plugin
automatically determine the versions for us.
----- Original Message -----
Hello,
I'd like to ask about the policy we want to use for the versioning schema.
I've raised a PR [1] that will check the project version and fails the
build if it's wrong. This should catch the releases with malformed
versions. It's aligned with the JBoss project versioning [2], however,
it's not clear how to use the "-SNAPSHOT" suffix. Peter has a good point
in the PR comment that some use the x.y.z.Final-SNAPSHOT (final can be
also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when releasing, we
add the Final/Alpha, etc.
Looking into wildfly repo, they use the former method. Is this what we want?
I personally consider the latter method more natural and we use it in the
inventory, despite the fact the hawkular/hawkular uses the
x.y.z.AlphaN-SNAPSHOT.
jk
[1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
[2]: https://developer.jboss.org/wiki/JBossProjectVersioning
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
8:36 a.m.
The mentioned link does not mention .Final-SNAPSHOT anywhere.
Either x.y.z-SNAPSHOT (which has other issues, as discussed)
or x.y.z-Final.
(but then it does not even mention SNAPSHOT :-).
On 11 Nov 2015, at 14:57, John Mazzitelli wrote:
I like and use x.y.z.Final-SNAPSHOT if only because the mvn release
plugin sets that all automatically for you. You just hit <enter> at
the prompts and go. If you use x.y.x-SNAPSHOT you have to remember to
change the value of the version at the mvn release plugin prompt,
which can lead to typos/fat-fingering the version string ;)
Make it easy on ourselves - just use x.y.z.ABC-SNAPSHOT - and let the
mvn release plugin automatically determine the versions for us.
----- Original Message -----
> Hello,
> I'd like to ask about the policy we want to use for the versioning
> schema.
> I've raised a PR [1] that will check the project version and fails
> the
> build if it's wrong. This should catch the releases with malformed
> versions. It's aligned with the JBoss project versioning [2],
> however,
> it's not clear how to use the "-SNAPSHOT" suffix. Peter has a good
> point
> in the PR comment that some use the x.y.z.Final-SNAPSHOT (final can
> be
> also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when
> releasing, we
> add the Final/Alpha, etc.
>
> Looking into wildfly repo, they use the former method. Is this what
> we want?
> I personally consider the latter method more natural and we use it in
> the
> inventory, despite the fact the hawkular/hawkular uses the
> x.y.z.AlphaN-SNAPSHOT.
>
> jk
>
>
> [1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
> [2]: https://developer.jboss.org/wiki/JBossProjectVersioning
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
--
Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
Handelsregister: Amtsgericht München HRB 153243
Geschäftsführer: Charles Cachera, Michael Cunningham, Paul Hickey,
Charlie Peters
9:37 a.m.
Hello,
Sorry for the late reply but .Final-SNAPSHOT is not good for many reasons. First, the page
below [1] has an implicit version for -SNAPSHOT by the virtue of
"major.minor.micro.TIMESTAMP-Mn". .Final or any other moniker added (eg. .Beta)
after the actual version and before -SNAPSHOT, will break the versioning for the timed
snapshots. Second, it really makes the -SNAPSHOT moniker obsolete, because we will never
have .Beta-SNAPSHOT (or if we do we will confuse absolutely everybody). So we might as
well not use .SNAPSHOT at all and switch to use exclusively the labels in the document.
And third, it just makes the version unnecessarily long since it does not provide any more
context to potential users.
I totally agree with mandating the released version numbers to be in accordance with the
JBoss standards. But let's keep the -SNAPSHOT version as short as possible
(x.y.z-SNAPSHOT).
[1] https://developer.jboss.org/wiki/JBossProjectVersioning
----- Original Message -----
From: "Heiko W.Rupp" <hrupp(a)redhat.com>
To: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Sent: Wednesday, November 11, 2015 8:36:30 AM
Subject: Re: [Hawkular-dev] versioning schema
The mentioned link does not mention .Final-SNAPSHOT anywhere.
Either x.y.z-SNAPSHOT (which has other issues, as discussed)
or x.y.z-Final.
(but then it does not even mention SNAPSHOT :-).
On 11 Nov 2015, at 14:57, John Mazzitelli wrote:
> I like and use x.y.z.Final-SNAPSHOT if only because the mvn release
> plugin sets that all automatically for you. You just hit <enter> at
> the prompts and go. If you use x.y.x-SNAPSHOT you have to remember to
> change the value of the version at the mvn release plugin prompt,
> which can lead to typos/fat-fingering the version string ;)
>
> Make it easy on ourselves - just use x.y.z.ABC-SNAPSHOT - and let the
> mvn release plugin automatically determine the versions for us.
>
> ----- Original Message -----
>> Hello,
>> I'd like to ask about the policy we want to use for the versioning
>> schema.
>> I've raised a PR [1] that will check the project version and fails
>> the
>> build if it's wrong. This should catch the releases with malformed
>> versions. It's aligned with the JBoss project versioning [2],
>> however,
>> it's not clear how to use the "-SNAPSHOT" suffix. Peter has a
good
>> point
>> in the PR comment that some use the x.y.z.Final-SNAPSHOT (final can
>> be
>> also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when
>> releasing, we
>> add the Final/Alpha, etc.
>>
>> Looking into wildfly repo, they use the former method. Is this what
>> we want?
>> I personally consider the latter method more natural and we use it in
>> the
>> inventory, despite the fact the hawkular/hawkular uses the
>> x.y.z.AlphaN-SNAPSHOT.
>>
>> jk
>>
>>
>> [1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
>> [2]: https://developer.jboss.org/wiki/JBossProjectVersioning
>> _______________________________________________
>> hawkular-dev mailing list
>> hawkular-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>>
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
--
Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
Handelsregister: Amtsgericht München HRB 153243
Geschäftsführer: Charles Cachera, Michael Cunningham, Paul Hickey,
Charlie Peters
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
5:57 p.m.
Hi Stefan, inline...
On 2015-12-18 16:37, Stefan Negrea wrote:
Hello,
Sorry for the late reply but .Final-SNAPSHOT is not good for many reasons.
Three is not many ;)
First, the page below [1] has an implicit version for -SNAPSHOT by
the virtue of "major.minor.micro.TIMESTAMP-Mn". .Final or any other moniker
added (eg. .Beta) after the actual version and before -SNAPSHOT, will break the versioning
for the timed snapshots.
My curiosity: What are timed SNAPSHOTs good for? Are you using them for
something?
Second, it really makes the -SNAPSHOT moniker obsolete, because we
will never have .Beta-SNAPSHOT (or if we do we will confuse absolutely everybody).
Assuming "we" is the whole Hawkular (rather than Metrics alone):
(1) we can well have .BetaN-SNAPSHOT, I have no problem with that.
(2) 1.2.3.Beta1-SNAPSHOT is not confusing at all. It sets the proper
expectation what the next release will be. It will namely be 1.2.3.Beta1
which says something important about the delivered quality.
So we might as well not use .SNAPSHOT at all and switch to use
exclusively the labels in the document. And third, it just makes the version unnecessarily
long since it does not provide any more context to potential users.
It does add more info to potential users: It makes clear what the next
release will be.
I totally agree with mandating the released version numbers to be in
accordance with the JBoss standards. But let's keep the -SNAPSHOT version as short as
possible (x.y.z-SNAPSHOT).
The bottom line is, that the Alpha|Beta|CR|Final part was made optional
for SNAPSHOT versions in HK parent [2]. I have no plans to propose to
revert that change because what matters is the naming scheme for
releases, which is defined separately [3] and that one is just OK.
To add some context for those ones curious why I did [2]: There is a
perf job at QA's Jenkins that expects .Final-less version strings in
Metrics and I wanted my PR [4] not to be blocked by that and there
seemed to exist nobody to fix the Jenkins job fast enough.
[2]
https://github.com/hawkular/hawkular-parent-pom/commit/aa917af4c2628a5660...
[3] https://github.com/hawkular/hawkular-parent-pom/blob/31/pom.xml#L1046
[4] https://github.com/hawkular/hawkular-metrics/pull/418
-- P
[1] https://developer.jboss.org/wiki/JBossProjectVersioning
----- Original Message -----
> From: "Heiko W.Rupp" <hrupp(a)redhat.com>
> To: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
> Sent: Wednesday, November 11, 2015 8:36:30 AM
> Subject: Re: [Hawkular-dev] versioning schema
>
> The mentioned link does not mention .Final-SNAPSHOT anywhere.
> Either x.y.z-SNAPSHOT (which has other issues, as discussed)
> or x.y.z-Final.
> (but then it does not even mention SNAPSHOT :-).
>
>
> On 11 Nov 2015, at 14:57, John Mazzitelli wrote:
>
>> I like and use x.y.z.Final-SNAPSHOT if only because the mvn release
>> plugin sets that all automatically for you. You just hit <enter> at
>> the prompts and go. If you use x.y.x-SNAPSHOT you have to remember to
>> change the value of the version at the mvn release plugin prompt,
>> which can lead to typos/fat-fingering the version string ;)
>>
>> Make it easy on ourselves - just use x.y.z.ABC-SNAPSHOT - and let the
>> mvn release plugin automatically determine the versions for us.
>>
>> ----- Original Message -----
>>> Hello,
>>> I'd like to ask about the policy we want to use for the versioning
>>> schema.
>>> I've raised a PR [1] that will check the project version and fails
>>> the
>>> build if it's wrong. This should catch the releases with malformed
>>> versions. It's aligned with the JBoss project versioning [2],
>>> however,
>>> it's not clear how to use the "-SNAPSHOT" suffix. Peter has a
good
>>> point
>>> in the PR comment that some use the x.y.z.Final-SNAPSHOT (final can
>>> be
>>> also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when
>>> releasing, we
>>> add the Final/Alpha, etc.
>>>
>>> Looking into wildfly repo, they use the former method. Is this what
>>> we want?
>>> I personally consider the latter method more natural and we use it in
>>> the
>>> inventory, despite the fact the hawkular/hawkular uses the
>>> x.y.z.AlphaN-SNAPSHOT.
>>>
>>> jk
>>>
>>>
>>> [1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
>>> [2]: https://developer.jboss.org/wiki/JBossProjectVersioning
>>> _______________________________________________
>>> hawkular-dev mailing list
>>> hawkular-dev(a)lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>>>
>> _______________________________________________
>> hawkular-dev mailing list
>> hawkular-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
>
> --
> Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
> Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
> Handelsregister: Amtsgericht München HRB 153243
> Geschäftsführer: Charles Cachera, Michael Cunningham, Paul Hickey,
> Charlie Peters
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
9:41 a.m.
I personally don't care about snapshots at all. Over the time I've leaned
towards Mazz's "least amount of work needed to get a release out" and just
go
with ".Final-SNAPSHOT" in inventory. It enables me to go mindlessly "next-
next-finish" during the release process, which is a good thing - my mind cares
much more about other things than the release numbers - and I don't have to
type any with this approach.
My experience with -SNAPSHOT is that it is not useful for anything but
relating to other artifacts in between versions LOCALLY. Even using server-
side timed snapshots is problematic IMHO and we're much better off using
srcdeps for that.
A -SNAPSHOT version IMHO doesn't even say what's the next version gonna be,
because it would require the developers to know the future - it merely says
what the devs think the next version might be.
So in another words, I've lost too much time on this already. There's a much
bigger fish to fry than -SNAPHOSTs.
On Friday, December 18, 2015 10:37:02 Stefan Negrea wrote:
Hello,
Sorry for the late reply but .Final-SNAPSHOT is not good for many reasons.
First, the page below [1] has an implicit version for -SNAPSHOT by the
virtue of "major.minor.micro.TIMESTAMP-Mn". .Final or any other moniker
added (eg. .Beta) after the actual version and before -SNAPSHOT, will break
the versioning for the timed snapshots. Second, it really makes the
-SNAPSHOT moniker obsolete, because we will never have .Beta-SNAPSHOT (or
if we do we will confuse absolutely everybody). So we might as well not use
.SNAPSHOT at all and switch to use exclusively the labels in the document.
And third, it just makes the version unnecessarily long since it does not
provide any more context to potential users.
I totally agree with mandating the released version numbers to be in
accordance with the JBoss standards. But let's keep the -SNAPSHOT version
as short as possible (x.y.z-SNAPSHOT).
[1] https://developer.jboss.org/wiki/JBossProjectVersioning
----- Original Message -----
> From: "Heiko W.Rupp" <hrupp(a)redhat.com>
> To: "Discussions around Hawkular development"
> <hawkular-dev(a)lists.jboss.org> Sent: Wednesday, November 11, 2015 8:36:30
> AM
> Subject: Re: [Hawkular-dev] versioning schema
>
> The mentioned link does not mention .Final-SNAPSHOT anywhere.
> Either x.y.z-SNAPSHOT (which has other issues, as discussed)
> or x.y.z-Final.
> (but then it does not even mention SNAPSHOT :-).
>
> On 11 Nov 2015, at 14:57, John Mazzitelli wrote:
> > I like and use x.y.z.Final-SNAPSHOT if only because the mvn release
> > plugin sets that all automatically for you. You just hit <enter> at
> > the prompts and go. If you use x.y.x-SNAPSHOT you have to remember to
> > change the value of the version at the mvn release plugin prompt,
> > which can lead to typos/fat-fingering the version string ;)
> >
> > Make it easy on ourselves - just use x.y.z.ABC-SNAPSHOT - and let the
> > mvn release plugin automatically determine the versions for us.
> >
> > ----- Original Message -----
> >
> >> Hello,
> >> I'd like to ask about the policy we want to use for the versioning
> >> schema.
> >> I've raised a PR [1] that will check the project version and fails
> >> the
> >> build if it's wrong. This should catch the releases with malformed
> >> versions. It's aligned with the JBoss project versioning [2],
> >> however,
> >> it's not clear how to use the "-SNAPSHOT" suffix. Peter has a
good
> >> point
> >> in the PR comment that some use the x.y.z.Final-SNAPSHOT (final can
> >> be
> >> also AlphaN, BetaN and CRN) and some x.y.z-SNAPSHOT and when
> >> releasing, we
> >> add the Final/Alpha, etc.
> >>
> >> Looking into wildfly repo, they use the former method. Is this what
> >> we want?
> >> I personally consider the latter method more natural and we use it in
> >> the
> >> inventory, despite the fact the hawkular/hawkular uses the
> >> x.y.z.AlphaN-SNAPSHOT.
> >>
> >> jk
> >>
> >>
> >> [1]: https://github.com/hawkular/hawkular-parent-pom/pull/54
> >> [2]: https://developer.jboss.org/wiki/JBossProjectVersioning
> >> _______________________________________________
> >> hawkular-dev mailing list
> >> hawkular-dev(a)lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/hawkular-dev
> >
> > _______________________________________________
> > hawkular-dev mailing list
> > hawkular-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
> --
> Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
> Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
> Handelsregister: Amtsgericht München HRB 153243
> Geschäftsführer: Charles Cachera, Michael Cunningham, Paul Hickey,
> Charlie Peters
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
3271
days inactive
3311
days old
6 comments
6 participants
participants (6)
-
Heiko W.Rupp -
Jiri Kremser -
John Mazzitelli -
Lukas Krejci -
Peter Palaga -
Stefan Negrea