September 2011 - hibernate-issues

[Hibernate-JIRA] Created: (HHH-6165) HqlLexer can cause ClassNotFound in OSGi environment

by Jonathan Calvert (JIRA)

HqlLexer can cause ClassNotFound in OSGi environment ---------------------------------------------------- Key: HHH-6165 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6165 Project: Hibernate Core Issue Type: Patch Components: core Affects Versions: 3.6.2, 3.6.1, 3.6.0, 3.6.0.CR2, 3.6.0.CR1, 3.5.6, 3.6.0.Beta4, 3.6.0.Beta3, 3.5.5, 3.6.0.Beta2, 3.6.0.Beta1, 3.5.4, 3.5.3, 3.5.2, 3.5.1, 3.5.0-Final, 3.5.0-CR-2, 3.5.0-CR-1, 3.5.0-Beta-4, 3.5.0-Beta-3, 3.5.0-Beta-2, 3.5.0.Beta-1, 3.3.2 Environment: At least from 3.3.2 on, and at least on Postgres and Derby Reporter: Jonathan Calvert Priority: Minor Attachments: hqllexer.patch org.hibernate.hql.ast.HqlLexer can cause a ClassNotFound exception in an OSGi environment with a stacktrace like {code} org.hibernate.QueryException: ClassNotFoundException: org.hibernate.hql.ast.HqlToken [hql query here] at org.hibernate.hql.ast.HqlLexer.panic(HqlLexer.java:80) at antlr.CharScanner.setTokenObjectClass(CharScanner.java:338) at org.hibernate.hql.ast.HqlLexer.setTokenObjectClass(HqlLexer.java:54) ... {code} The HqlLexer class has antlr.CharScanner as a superclass, as evidenced by the stacktrace. The contents of the method are: {code} public void setTokenObjectClass(String cl) { // Ignore the token class name parameter, and use a specific token class. super.setTokenObjectClass( HqlToken.class.getName() ); } {code} It passes the name of the HqlToken class as a string to CharScanner, which then ultimately attempts to find HqlToken via antlr.Utils. The tokenObjectClass is a protected field. The code can be simplified by simply setting the field directly to HqlToken.class which is obviously already available to the HqlLexer class. The reason this causes the exception in an OSGi environment is that the context class loader available to ANTLR is limited to what is explicitly declared in the ANTLR bundle. Since ANTLR cannot (and should not) have to know about all the classes that it may be passed, it does not declare an import on the org.hibernate.hql.ast package. By passing the class directly, the lookup is avoided from within the ANTLR package. {code} public void setTokenObjectClass(String cl) { // Ignore the token class name parameter, and use a specific token class. tokenObjectClass = HqlToken.class; } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

3
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-191) Introduce a addEntityNode() method to the fluent node builder API

by Emmanuel Bernard (JIRA)

Introduce a addEntityNode() method to the fluent node builder API ----------------------------------------------------------------- Key: BVAL-191 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-191 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.0 final Reporter: Emmanuel Bernard In the current, model, to represent "persons[0]", we need to do constraintValidatorContext .buildConstraintViolationWithTemplate("constraints.CompatiblePersons.gender.message") .addNode("persons") .addNode(null).inIterable().atIndex(0) .addConstraintViolation(); this could be made cleaner with constraintValidatorContext .buildConstraintViolationWithTemplate("constraints.CompatiblePersons.gender.message") .addNode("persons") .addEntityNode().inIterable().atIndex(0) .addConstraintViolation(); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

3
13
0 / 0

[Hibernate-JIRA] Created: (BVAL-237) Expose validated bean via ConstraintValidatorContext

by Gunnar Morling (JIRA)

Expose validated bean via ConstraintValidatorContext ---------------------------------------------------- Key: BVAL-237 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-237 Project: Bean Validation Issue Type: New Feature Components: spec-general Affects Versions: 1.0 final Reporter: Gunnar Morling Fix For: 1.1 In the feedback forum a user [suggested|https://forum.hibernate.org/viewtopic.php?f=26&t=1012111] to expose the currently validated bean via {{javax.validation.ConstraintValidatorContext}}. IMO that's a good addition as it would people allow to create custom cross-field constraints more easily. I'm not sure whether access should be restricted to the current leaf bean or whether also the root bean should be accessible. In the latter case some methods from {{ConstraintViolation}} might just be offered on {{ConstraintValidatorContext}} as well: {code:java} getConstraintDescriptor() getLeafBean() getPropertyPath() getRootBean() getRootBeanClass() {code} Another idea would be to have an {{unwrap()}} method on {{ConstraintValidatorContext}} which would allow for BV providers to expose additional functionality. WDYT? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

4
11
0 / 0

[Hibernate-JIRA] Created: (HHH-5951) Guess appropriate JtaPlatform based on environment if an explicit one not specified.

by Steve Ebersole (JIRA)

Guess appropriate JtaPlatform based on environment if an explicit one not specified. ------------------------------------------------------------------------------------ Key: HHH-5951 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5951 Project: Hibernate Core Issue Type: Improvement Components: core Reporter: Steve Ebersole Assignee: Steve Ebersole Fix For: 4.0.0.Alpha1 If the user does not explicitly specify a JtaPlatform to use, try to guess the appropriate one to use based on the execution environment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

1
8
0 / 0

[Hibernate-JIRA] Created: (BVAL-221) The constraint violation builder cannot put constraint on a top level map key

by Emmanuel Bernard (JIRA)

The constraint violation builder cannot put constraint on a top level map key ----------------------------------------------------------------------------- Key: BVAL-221 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-221 Project: Bean Validation Issue Type: Bug Components: spec-general Reporter: Emmanuel Bernard Fix For: 1.1 >From Logan This is a minor thing and maybe tunnel-visioned (I don't know much about the other beans-related specs), but if I do something like this in a ConstraintValidator: {code} public boolean isValid(Map<String, String> target, ConstraintValidatorContext context) { context.buildConstraintViolationWithTemplate("oh noes") .addNode(somekey) .addConstraintViolation(); return false; } {code} It would be nice if that resulted in a violation at path someobject.mapproperty[somekey] rather than someobject.mapproperty.somekey. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

2
5
0 / 0

[Hibernate-JIRA] Created: (HHH-2647) Problems with OR parenthesis in HQL

by Dennis Fleurbaaij (JIRA)

Problems with OR parenthesis in HQL ----------------------------------- Key: HHH-2647 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2647 Project: Hibernate3 Issue Type: Bug Components: query-hql Affects Versions: 3.2.1 Environment: Hibernate 3.2.1, postgresql 8.2, jboss 5 embedded beta 2 Reporter: Dennis Fleurbaaij Given the following (part) of a query in HQL (where 1 to 6 are comparisons of different types (=, <=, is null), but irrelevant for the problem posted here ): AND ( ( 1 AND 2 ) OR ( 3 AND 4 ) OR ( 5 AND 6 ) ) will be balanced to: and ( ( 1 ) and 2 or 3 and ( 4 ) or 5 and 6 ) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

12
23
0 / 0

[Hibernate-JIRA] Created: (BVAL-217) Sperate the notion of message resolver vs message interpolator

by Emmanuel Bernard (JIRA)

Sperate the notion of message resolver vs message interpolator -------------------------------------------------------------- Key: BVAL-217 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-217 Project: Bean Validation Issue Type: Improvement Components: spec-general Reporter: Emmanuel Bernard -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

2
4
0 / 0

[Hibernate-JIRA] Created: (BVAL-233) Provide additional including custom variables for message interpolation

by Emmanuel Bernard (JIRA)

Provide additional including custom variables for message interpolation ----------------------------------------------------------------------- Key: BVAL-233 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-233 Project: Bean Validation Issue Type: New Feature Components: spec-general Environment: See https://forum.hibernate.org/viewtopic.php?f=26&t=1011431 Reporter: Emmanuel Bernard -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

5
12
0 / 0

[Hibernate-JIRA] Created: (HV-514) Expose validated bean via ConstraintValidatorContext (implement BVAL-237)

by Vivian Steller (JIRA)

Expose validated bean via ConstraintValidatorContext (implement BVAL-237) ------------------------------------------------------------------------- Key: HV-514 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-514 Project: Hibernate Validator Issue Type: Improvement Components: engine Affects Versions: 4.2.0.Final Environment: any Reporter: Vivian Steller Attachments: export-validated-bean-via-cvc.patch Allow accessing leafBean & rootBean through ConstraintValidatorContext; this would greatly improve implementing cross-property-validators. Feature is requested for BVAL 1.1, see https://hibernate.onjira.com/browse/BVAL-237 Patch for Hibernate 4.2 included. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

3
7
0 / 0

[Hibernate-JIRA] Created: (HV-409) Provide the possibility to specify parameter names for reporting method level constraint violations

by Gunnar Morling (JIRA)

Provide the possibility to specify parameter names for reporting method level constraint violations --------------------------------------------------------------------------------------------------- Key: HV-409 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-409 Project: Hibernate Validator Issue Type: New Feature Components: engine Reporter: Gunnar Morling When reporting a method level constraint violation besides the concerned method the parameter causing the violation is a substantial information. As the Java byte code usually doesn't contain any information on parameter names only the index of the parameter can be returned in the resulting MethodConstraintViolation. In order to produce expressive constraint violations it is desirable to have the possibility to specify parameter names in some way. One approach for this might be to allow parameter names being specified with the help of an appropriate annotation. Using JSR 330's @Named annotation for instance this could look like this: {code:java} someMethod(@Named("param1") @NotNull String param1, @Named("customer") @NotNull @Valid Customer customer) { //... } {code} In case any of the method's constraints is violated the resulting MethodConstraintViolation would refer to this name in getName() and getPropertyPath(): {code:java} assertEquals( constraintViolation.getParameterName(), "customer" ); assertEquals( constraintViolation.getPropertyPath().toString(), "SomeType#someMethod(customer).name" ); {code} This approach was prototyped in https://github.com/gunnarmorling/hibernate-validator/commits/method-level... but was removed for HV 4.2 with [e7e3c5f6e97d850b65579fc542599d4c9241048d|https://github.com/gunnarmorling...] and [8fbc2cca1481563309a03f58ccb4037134772801|https://github.com/gunnarmorling...] to have time for some more considerations. In especially an algorithm for retrieving the effective name of a method parameter has to be defined. This might look like this: * If the validated method doesn't override any method from a super type the parameter names are taken from this method (if given) * If the validated method does override a method from a super type, the closest names found up in the inheritance tree are taken (e.g. when validating A#foo() overriding B#foo() in turn overriding C#foo() and both B and C provide parameter names for foo(), then the names from B#foo() are taken) * If the name for a parameter is given in two or more equally distant types, the names of any from the closest types are taken, from which of this is not defined (e.g. when validating A#foo() implementing B#foo() and C#foo() and both B and C specify parameter names for foo(), the names either from B or C are taken) When implementing this feature HV should not require new strict dependencies; so if for instance working with @Named, javax.inject-1.jar should be added in optional scope and the type javax.inject.Named should be accessed only using reflection. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 10 months

3
6
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues September 2011