November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15743) Querying with empty parameter list fails

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15743 ( https://hibernate.atlassian.net/browse/HHH-15743?atlOrigin=eyJpIjoiOWMyMj... ) Re: Querying with empty parameter list fails ( https://hibernate.atlassian.net/browse/HHH-15743?atlOrigin=eyJpIjoiOWMyMj... ) > > > > The widely used Spring Framework and its module Spring Data JPA encourage > using queries the way I described > > That’s new to me. Can you show me a reference where this is explicitly stated? > > > > This repository method generates a Hibernate query and makes providing departments > mandatory (empty list returns 0 result, null returns > IllegalArgumentException). > > Because this implies that nobody encourages this kind of usage. > > > > Spring 5 (with Hibernate 5) made it easy to provide optional departments : > > > I’m sorry you based part of your application on something unspecified which just happened to work in this particular case, but like I wrote before, this kind of query is very inefficient. Don’t use that. Go the extra mile and implement proper conditional filtering. > > > > With Spring 6 (including Hibernate 6) I have to implement it via Criteria > API and Custom Repositories ( > https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repos... > ) , which is more costlier and verbose > > You don’t. I’d suggest everyone to use Spring Data Specification here for this purpose. @Repository public interface UserRepository extends JpaRepository<User, Long> { @Query("from User u " + "where COALESCE(:departments) is null or u.department in (:departments)") default List<User> findAllByOptionalDepartmentIn( @Param("departments") List<Department> departments, Sort sort) { return findAllByOptionalDepartmentIn( (root, query, cb) -> { return departments.isEmpty() ? null : root.get("department").in(departments) }, sort ); } List<User> findAllByOptionalDepartmentIn( Specification<User> spec, Sort sort); } ( https://hibernate.atlassian.net/browse/HHH-15743#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15743#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15718) Polymorphic queries with condition do not work

by Andrea Boriero (JIRA)

2 years, 10 months

1
0
0 / 0

[JIRA] (HSEARCH-3654) Upgrade to JUnit 5

by Marko Bekhta (JIRA)

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15743) Querying with empty parameter list fails

by Robert Rittwag (JIRA)

Robert Rittwag ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15743 ( https://hibernate.atlassian.net/browse/HHH-15743?atlOrigin=eyJpIjoiYjg0Mz... ) Re: Querying with empty parameter list fails ( https://hibernate.atlassian.net/browse/HHH-15743?atlOrigin=eyJpIjoiYjg0Mz... ) I get your point. And I respect it. In my former comment I forgot a third and quite important aspect: The widely used Spring Framework and its module Spring Data JPA encourage using queries the way I described. Because of their mechanism of generated repositories ( https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repos... ) it is quite easy to implement a query this way: @Repository public interface UserRepository extends JpaRepository<User, Long > { List<User> findAllByDepartmentIn( @Param( "deparment" ) List<Department> departments, Sort sort); } This repository method generates a Hibernate query and makes providing departments mandatory (empty list returns 0 result, null returns IllegalArgumentException). Spring 5 (with Hibernate 5) made it easy to provide optional departments : @Repository public interface UserRepository extends JpaRepository<User, Long > { @Query( "from User u " + "where COALESCE(:departments) is null or u.department in (:departments)" ) List<User> findAllByOptionalDepartmentIn( @Param( "departments" ) List<Department> departments, Sort sort); } With Spring 6 (including Hibernate 6) I have to implement it via Criteria API and Custom Repositories ( https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#repos... ) , which is more costlier and verbose: interface CustomizedUserRepository { List<User> findAllByOptionalDepartmentIn(List<Department> departments, Sort sort); } public class CustomizedUserRepositoryImpl implements CustomizedUserRepository { @Autowired private EntityManager em; @Override public List<User> findAllByOptionalDepartmentIn( @Param( "departments" ) List<Department> departments, Sort sort) { CriteriaBuilder cb = em.getCriteriaBuilder(); CriteriaQuery<User> cr = cb.createQuery(User.class); Root<User> root = cr.from(User.class); if (departments != null && !departments.isEmpty()) cr.select(root).where(root.get( "department" ).in(departments)); // TODO: add some sort magic return em.createQuery(cr).getResultList(); } } @Repository public interface UserRepository extends JpaRepository<User, Long >, CustomizedUserRepository { } My point is: The newly released Spring 6 leaves a lot of Spring 5 users asking why and how to migrate their simple queries. That's why I created this issue … and was talking about shady "workaround solutions" 🙂 . ( https://hibernate.atlassian.net/browse/HHH-15743#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15743#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15711) ArgumentTypesValidator doesn't support enums in string functions

by Andrea Boriero (JIRA)

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15606) @OneToOne(mappedBy = ..., fetch = LAZY) in embedded leads to IllegalArgumentException: Can not set [...] to LazyPropertyInitializer$1

by Andrea Boriero (JIRA)

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15711) ArgumentTypesValidator doesn't support enums in string functions

by Andrea Boriero (JIRA)

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15746) Add back MutableIdentifierGeneratorFactory

by Davide D'Alto (JIRA)

Davide D'Alto ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOTkyOTkxYTIx... ) / New Feature ( https://hibernate.atlassian.net/browse/HHH-15746?atlOrigin=eyJpIjoiOTkyOT... ) HHH-15746 ( https://hibernate.atlassian.net/browse/HHH-15746?atlOrigin=eyJpIjoiOTkyOT... ) Add back MutableIdentifierGeneratorFactory ( https://hibernate.atlassian.net/browse/HHH-15746?atlOrigin=eyJpIjoiOTkyOT... ) Issue Type: New Feature Assignee: Davide D'Alto ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 22/Nov/2022 06:23 AM Priority: Major Reporter: Davide D'Alto ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In Hibernate Reactive we need to plug in our own generators. In ORM 5, we did it using the MutableIdentifierGeneratorFactory, but it seems it has been removed since ORM 6. I’m not sure if it’s by design but I’m going to add it back. I can implement a differnt SPI later if we decide to change it. ( https://hibernate.atlassian.net/browse/HHH-15746#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15746#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15745) IllegalArgumentException while executing Like query with Escapes

by Andrei Nikulin (JIRA)

Andrei Nikulin ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiODUzMjhmZTcx... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15745?atlOrigin=eyJpIjoiODUzMj... ) HHH-15745 ( https://hibernate.atlassian.net/browse/HHH-15745?atlOrigin=eyJpIjoiODUzMj... ) IllegalArgumentException while executing Like query with Escapes ( https://hibernate.atlassian.net/browse/HHH-15745?atlOrigin=eyJpIjoiODUzMj... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Created: 22/Nov/2022 06:21 AM Priority: Major Reporter: Andrei Nikulin ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Found possible regression. It is somehow related to Like queries and Escape characters. If I execute a query : from User user where user.name like ?1 escape '\' or user in ( select distinct trans.classifier from UserTranslation trans where trans.translation like ?2 escape '\' ) then I get an error: java.lang.IllegalArgumentException: org.hibernate.query.sqm.InterpretationException: Error interpreting query [from UserTranslation where classifier.id=?1]; this may indicate a semantic (user query) problem or a bug in the parser [from UserTranslation where classifier.id=?1] Passing test with Hibernate 5 dependency: h5-passing ( https://github.com/NikulinAndrei/spring-boot-3-test/tree/h5-passing ) Failing test with Hibernate 6 dependency: h6-escape-failing ( https://github.com/NikulinAndrei/spring-boot-3-test/tree/h6-escape-failing ) Failing test is *shouldQueryTranslationLike* ( https://hibernate.atlassian.net/browse/HHH-15745#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15745#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:eab5823 )

2 years, 10 months

1
0
0 / 0

[JIRA] (HHH-15699) HibernateException: Found shared references to a collection when ShareCacheMode.All or ShareCacheMode.DISABLE_SELECTIVE

by Andrea Boriero (JIRA)

2 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022