[Hibernate-JIRA] Created: (HHH-6735) Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
8:13 p.m.
Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
--------------------------------------------------------------------------------------
Key: HHH-6735
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735
Project: Hibernate Core
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Emmanuel Bernard
Fix For: 4.0.0.next
Attachments: HibernateCore Hot spots.tar.gz
The method
{code}org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class){code}
is invoked frequently at runtime, creating a significant performance bottleneck; I'm
attaching the profiling report from a synthetic micro benchmark which is unlikely to be
representative of a real world case, but able to show a waste of 27% of CPU time in this
method only.
From previous discussion:{quote}>
This is something we should fix in Core; it should be possible to
associate a "isInstrumented" flag to the Entity, so that we don't need
to check the class hierarchy at each invocation? I think this should
reside in the EntityMetamodel, and the
FieldInterceptionHelper.isInstrumented be invoked only once per type.
Yes, I think it's a good idea. We will still need
FieldInterceptionHelper.isInstrumented in some situations where the SessionFActory is
unknown but that will help in all the common Hibernate operations.{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:39 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-6735) Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735?page=c...
]
Emmanuel Bernard resolved HHH-6735.
-----------------------------------
Resolution: Fixed
Performance hostpot in
FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
--------------------------------------------------------------------------------------
Key: HHH-6735
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735
Project: Hibernate Core
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Emmanuel Bernard
Fix For: 4.0.0.next
Attachments: HibernateCore Hot spots.tar.gz
The method
{code}org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class){code}
is invoked frequently at runtime, creating a significant performance bottleneck; I'm
attaching the profiling report from a synthetic micro benchmark which is unlikely to be
representative of a real world case, but able to show a waste of 27% of CPU time in this
method only.
From previous discussion:{quote}>
> This is something we should fix in Core; it should be possible to
> associate a "isInstrumented" flag to the Entity, so that we don't
need
> to check the class hierarchy at each invocation? I think this should
> reside in the EntityMetamodel, and the
> FieldInterceptionHelper.isInstrumented be invoked only once per type.
Yes, I think it's a good idea. We will still need
FieldInterceptionHelper.isInstrumented in some situations where the SessionFActory is
unknown but that will help in all the common Hibernate operations.{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:33 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6735) Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735?page=c...
]
Steve Ebersole commented on HHH-6735:
-------------------------------------
Hmm, I think this issue might have been easier to fix than what was done here unless I am
misunderstanding something.
Why not just delegate to {{org.hibernate.persister.entity.EntityPersister#isInstrumented}}
? Seems you are duplicating that information here in this
{{org.hibernate.service.instrumentation.internal.CachingInstrumentationService#isInstrumentedCache}}
cache.
Performance hostpot in
FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
--------------------------------------------------------------------------------------
Key: HHH-6735
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735
Project: Hibernate Core
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Emmanuel Bernard
Fix For: 4.0.0.CR5
Attachments: HibernateCore Hot spots.tar.gz
The method
{code}org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class){code}
is invoked frequently at runtime, creating a significant performance bottleneck; I'm
attaching the profiling report from a synthetic micro benchmark which is unlikely to be
representative of a real world case, but able to show a waste of 27% of CPU time in this
method only.
From previous discussion:{quote}>
> This is something we should fix in Core; it should be possible to
> associate a "isInstrumented" flag to the Entity, so that we don't
need
> to check the class hierarchy at each invocation? I think this should
> reside in the EntityMetamodel, and the
> FieldInterceptionHelper.isInstrumented be invoked only once per type.
Yes, I think it's a good idea. We will still need
FieldInterceptionHelper.isInstrumented in some situations where the SessionFActory is
unknown but that will help in all the common Hibernate operations.{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:42 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6735) Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735?page=c...
]
Steve Ebersole commented on HHH-6735:
-------------------------------------
For example, I see this changeset includes a change to
{{org.hibernate.event.internal.AbstractSaveEventListener#markInterceptorDirty}}
(https://fisheye2.atlassian.com/viewrep/Hibernate-Core/hibernate-core/src/...)
which changes:
{code}
private void markInterceptorDirty(Object entity, EntityPersister persister, EventSource
source) {
if ( FieldInterceptionHelper.isInstrumented( entity ) ) {
FieldInterceptor interceptor = FieldInterceptionHelper.injectFieldInterceptor(
entity,
persister.getEntityName(),
null,
source
);
interceptor.dirty();
}
}
{code}
to:
{code}
private void markInterceptorDirty(Object entity, EntityPersister persister, EventSource
source) {
InstrumentationService instrumentationService = persister.getFactory()
.getServiceRegistry()
.getService( InstrumentationService.class );
if ( instrumentationService.isInstrumented( entity ) ) {
FieldInterceptor interceptor = FieldInterceptionHelper.injectFieldInterceptor(
entity,
persister.getEntityName(),
null,
source
);
interceptor.dirty();
}
}
{code}
but why not just change that to:
{code}
private void markInterceptorDirty(Object entity, EntityPersister persister, EventSource
source) {
if ( persister.isInstrumented() ) {
FieldInterceptor interceptor = FieldInterceptionHelper.injectFieldInterceptor(
entity,
persister.getEntityName(),
null,
source
);
interceptor.dirty();
}
}
{code}
I have not looked through all the changes, but I cannot imagine there is a time where you
have access to this service but do not have access to the {{EntityPersister}} especially
since the change here states that use of this service is expected only from a
{{SessionFactory}}
Performance hostpot in
FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
--------------------------------------------------------------------------------------
Key: HHH-6735
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735
Project: Hibernate Core
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Emmanuel Bernard
Fix For: 4.0.0.CR5
Attachments: HibernateCore Hot spots.tar.gz
The method
{code}org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class){code}
is invoked frequently at runtime, creating a significant performance bottleneck; I'm
attaching the profiling report from a synthetic micro benchmark which is unlikely to be
representative of a real world case, but able to show a waste of 27% of CPU time in this
method only.
From previous discussion:{quote}>
> This is something we should fix in Core; it should be possible to
> associate a "isInstrumented" flag to the Entity, so that we don't
need
> to check the class hierarchy at each invocation? I think this should
> reside in the EntityMetamodel, and the
> FieldInterceptionHelper.isInstrumented be invoked only once per type.
Yes, I think it's a good idea. We will still need
FieldInterceptionHelper.isInstrumented in some situations where the SessionFActory is
unknown but that will help in all the common Hibernate operations.{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:15 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-6735) Performance hostpot in FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735?page=c...
]
Steve Ebersole commented on HHH-6735:
-------------------------------------
Another (probably better) option would be to expose something like
{{org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.Delegate}} from
{{org.hibernate.tuple.entity.EntityTuplizer}}/{{org.hibernate.persister.entity.EntityPersister}},
but have it be (1) BytecodeProvider-specific and (2) class-specific. Something like:
{code:title=EntityFieldInterceptionDelegate.java|borderStyle=solid}
/**
* Entity-specific delegate for handling bytecode provider field interception calls.
*/
public interface EntityFieldInterceptionDelegate {
/**
* Has the entity class been bytecode instrumented?
*/
public boolean isInstrumented();
/**
* Extract the field interceptor instance from the instrumented entity.
*/
public FieldInterceptor extractInterceptor(Object entity) throws
NotInstrumentedException;
/**
* Inject a field interceptor instance into the instrumented entity.
*/
public FieldInterceptor injectInterceptor(
Object entity,
String entityName,
Set uninitializedFieldNames,
SessionImplementor session) throws NotInstrumentedException;
}
{code}
{code:title=BytecodeProvider.java|borderStyle=solid}
public interface BytecodeProvider {
...
public EntityFieldInterceptionDelegate resolveEntityFieldInterceptionDelegate(Class
entityClass);
}
{code}
etc...
Performance hostpot in
FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class)
--------------------------------------------------------------------------------------
Key: HHH-6735
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6735
Project: Hibernate Core
Issue Type: Improvement
Reporter: Sanne Grinovero
Assignee: Emmanuel Bernard
Fix For: 4.0.0.CR5
Attachments: HibernateCore Hot spots.tar.gz
The method
{code}org.hibernate.bytecode.instrumentation.internal.FieldInterceptionHelper.JavassistDelegate.isInstrumented(Class){code}
is invoked frequently at runtime, creating a significant performance bottleneck; I'm
attaching the profiling report from a synthetic micro benchmark which is unlikely to be
representative of a real world case, but able to show a waste of 27% of CPU time in this
method only.
From previous discussion:{quote}>
> This is something we should fix in Core; it should be possible to
> associate a "isInstrumented" flag to the Entity, so that we don't
need
> to check the class hierarchy at each invocation? I think this should
> reside in the EntityMetamodel, and the
> FieldInterceptionHelper.isInstrumented be invoked only once per type.
Yes, I think it's a good idea. We will still need
FieldInterceptionHelper.isInstrumented in some situations where the SessionFActory is
unknown but that will help in all the common Hibernate operations.{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4755
days inactive
4829
days old
hibernate-issues@lists.jboss.org
4 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
Sanne Grinovero (JIRA)
-
Steve Ebersole (JIRA)