[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5500?page=c... ] Erik-Berndt Scheper commented on HHH-5500: ------------------------------------------ I propose to add the following extra method {code:title=org.hibernate.envers.AuditReader.java|borderStyle=solid} /** * Find the entities with a certain primary key, at the given revisions. * @param cls Class of the entity. * @param primaryKey Primary key of the entity. * @param revisions Revision numbers for which to get the entity. * @return A map containing the revision numbers and the entity instance at this revision * @throws IllegalArgumentException If cls or primaryKey is null or revision is less or equal to 0. * @throws NotAuditedException When entities of the given class are not audited. * @throws IllegalStateException If the associated entity manager is closed. */ <T> Map<Number, T> findEntities(Class<T> cls, Object primaryKey, Set<Number> revisions) throws IllegalArgumentException, NotAuditedException, IllegalStateException; {code} However, I believe this query is only feasible after HHH-5372 (improve Envers query performance by using new REVEND column) is implemented in trunk, and subqueries are no longer needed (using the ValidAuditTimeStrategy). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5500?page=c... ] Adam Warski updated HHH-5500: ----------------------------- Summary: Extend AuditReader interface with findEntities() method (was: Extend AuditReader interface with findRevisions() method) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5500?page=c... ] Lukasz Antoniak commented on HHH-5500: -------------------------------------- Erik, could you provide a business scenario where this functionality would be desired? More or less the same can be achieved with {{AuditReader.createQuery().forRevisionsOfEntity()}} query. Please review {{org.hibernate.envers.test.integration.query.RevisionConstraintQuery}} class and the following test method: {code:title=org.hibernate.envers.test.integration.query.RevisionConstraintQuery|borderStyle=solid} @Test public void testMultipleRevisionsOfEntity() { List results = getAuditReader().createQuery() .forRevisionsOfEntity(StrIntTestEntity.class, true, true) .add(AuditEntity.id().eq(id1)) .add(AuditEntity.revisionNumber().in(new Integer[] {1, 3})) .getResultList(); assert results.size() == 2; assert results.get(0).equals(new StrIntTestEntity("a", 10, id1)); assert results.get(1).equals(new StrIntTestEntity("d", 1, id1)); } {code} SQL query generated by Envers: {code:title=SQL query|borderStyle=solid} select strinttest0_.id as id3103_, strinttest0_.REV as REV3103_, strinttest0_.REVTYPE as REVTYPE3103_, strinttest0_.REVEND as REVEND3103_, strinttest0_.number as number3103_, strinttest0_.str1 as str6_3103_ from StrIntTestEntity_AUD strinttest0_ where strinttest0_.id=? and ( strinttest0_.REV in ( ? , ? ) ) order by strinttest0_.REV asc {code} The only difference between existing {{AuditReader.createQuery().forRevisionsOfEntity()}} and proposed {{AuditReader.findEntities()}} method would be the "calculation" of appropriate revision number when entity has been last modified. If an entity of {{StrIntTestEntity}} type was updated during revisions 1, 3, and 5, {{AuditReader.createQuery().forRevisionsOfEntity()}} would return no results for revisions 2 and 4. Proposed {{AuditReader.findEntities()}} shall return snapshot of entity at revision 1 (for passed argument 2), and 3 (for passed argument 4). Adam, maybe this functionality would be useful? Regards, Łukasz Antoniak -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5500?page=c... ] Adam Warski commented on HHH-5500: ---------------------------------- Right, I think asking for entities between revisions should suffice - why would you want to pick only some? And how would you know their numbers in the first place? Adam -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira