[Hibernate-JIRA] Created: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
6:04 p.m.
Using row_number with the SQLServerDialect makes select distinct useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Yoryos Valotassios commented on HHH-5715:
-----------------------------------------
I've created a branch with the test cases:
https://github.com/valotas/hibernate-core/tree/HHH-5715. I've also done a pull
request.
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Strong Liu reassigned HHH-5715:
-------------------------------
Assignee: Strong Liu
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Yoryos Valotassios commented on HHH-5715:
-----------------------------------------
The head of https://github.com/valotas/hibernate-core/tree/HHH-5715 should also contain a
fix. Actually I'm replacing the distinct select with the equivalent group by statement
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:04 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Strong Liu resolved HHH-5715.
-----------------------------
Resolution: Fixed
Fix Version/s: 3.x
3.6.1
nice work, patch applied, thanks
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1, 3.x
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:21 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Maros Bajtos commented on HHH-5715:
-----------------------------------
I think the fix doesn't work correctly for this case:
select count(distinct person.name) from Person person
Calling getSingleResult on this query will result in SqlException, since resulting query
will have count function in group by clause.
The problem is in method SQLServerDialect.replaceDistinctWithGroupBy - this should replace
'distinct' by group by only in case that distinct keyword is not in aggregation
function.
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1, 3.x
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:44 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Strong Liu commented on HHH-5715:
---------------------------------
Maros, can you provide a test case, so i can easier to test it, thanks (and it is much
better if you have a patch to fix it, then go ahead an create a pull request)
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1, 3.x
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Yoryos Valotassios commented on HHH-5715:
-----------------------------------------
@Maros: you are right. I'm just checking for a distinct keyword with in the select
statement. I think there is the easy workaround to search for the "select
distinct" phrase with in the sql query in order to fire the replacement. @Strong:
Pull request is on the way, but should I open a new issue first?
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1, 3.x
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:02 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Strong Liu commented on HHH-5715:
---------------------------------
yep, Yoryos, a new one please (since this is closed), thanks
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1, 3.x
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Steve Ebersole closed HHH-5715.
-------------------------------
Resolution: Fixed
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 p.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Steve Ebersole reopened HHH-5715:
---------------------------------
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:50 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5715) Using row_number with the SQLServerDialect makes select distinct useless
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715?page=c...
]
Steve Ebersole updated HHH-5715:
--------------------------------
Fix Version/s: (was: 3.x)
Using row_number with the SQLServerDialect makes select distinct
useless
------------------------------------------------------------------------
Key: HHH-5715
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5715
Project: Hibernate Core
Issue Type: Bug
Components: core
Reporter: Yoryos Valotassios
Assignee: Strong Liu
Fix For: 3.6.1
Given class A with one to many relations to class B, when trying to get paginated data
with SQLServerDialect from class A with a join clause to class B will dublicated A
instances. That is because the row_number function will introduce another value to the
select statement which will alway be different for each row. I found a work around using
group by. Did not have time finish the test cases yet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4744
days inactive
5163
days old
hibernate-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Maros Bajtos (JIRA) -
Steve Ebersole (JIRA)
-
Strong Liu (JIRA)
-
Yoryos Valotassios (JIRA)