[Hibernate-JIRA] Created: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
12:05 p.m.
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which then
internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory() ending in
NULL pointer exception because proxy factory is null as mine is a greedy loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:32 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Erik-Berndt Scheper commented on HHH-3854:
------------------------------------------
I see the same NPE with JPA / annotations, but only if the persistent object is a final
class.
The reason behind this is that the proxyFactory is null (as above), because the
constructor of EntityMetaModel.class (in hibernate core) then declares it as non-lazy
(line 267-271 in EntityMetaModel.java, hibernate-core-3.3.2.GA):
lazy = persistentClass.isLazy() && (
// TODO: this disables laziness even in non-pojo entity modes:
!persistentClass.hasPojoRepresentation() ||
!ReflectHelper.isFinalClass( persistentClass.getProxyInterface() )
);
Becayse the entityMetamodel is NOT lazy for final classes the constructor of the
AbstractEntityTuplizer (i.e. any tuplizer) will set the proxyFactory to null (line 150-158
in AbstractEntityTuplizer .java, hibernate-core-3.3.2.GA):
if ( entityMetamodel.isLazy() ) {
proxyFactory = buildProxyFactory( mappingInfo, idGetter, idSetter );
if (proxyFactory == null) {
entityMetamodel.setLazy( false );
}
}
else {
proxyFactory = null;
}
This all eventually leads to a NPE in hibernate envers ToOneIdMapper.class
java.lang.NullPointerException
at
org.hibernate.tuple.entity.AbstractEntityTuplizer.createProxy(AbstractEntityTuplizer.java:394)
at
org.hibernate.persister.entity.AbstractEntityPersister.createProxy(AbstractEntityPersister.java:3469)
at
org.hibernate.envers.entities.mapper.relation.ToOneIdMapper.mapToEntityFromMap(ToOneIdMapper.java:84)
at
org.hibernate.envers.entities.mapper.MultiPropertyMapper.mapToEntityFromMap(MultiPropertyMapper.java:117)
at
org.hibernate.envers.entities.EntityInstantiator.createInstanceFromVersionsEntity(EntityInstantiator.java:93)
at
org.hibernate.envers.entities.EntityInstantiator.addInstancesFromVersionsEntities(EntityInstantiator.java:103)
at
org.hibernate.envers.query.impl.EntitiesAtRevisionQuery.list(EntitiesAtRevisionQuery.java:90)
at
org.hibernate.envers.query.impl.AbstractAuditQuery.getSingleResult(AbstractAuditQuery.java:104)
at org.hibernate.envers.reader.AuditReaderImpl.find(AuditReaderImpl.java:104)
<rest of trace skipped>
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Erik-Berndt Scheper updated HHH-3854:
-------------------------------------
Attachment: envers-HHH-3854-testcases.patch
Attached patch file containing tests to reproduce problem both as HBM, and using
annotations.
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Daniel Bleisteiner commented on HHH-3854:
-----------------------------------------
The same error occurs when a class is annotated with @Proxy(lazy=false)!
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Robin Gersabeck commented on HHH-3854:
--------------------------------------
Just signed up to say that this is still very much an issue in Hibernate-3.5.2-Final. I
use HBM.
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:14 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Robin Gersabeck commented on HHH-3854:
--------------------------------------
A patch that seems to work for me is to just change the line that says "proxyFactory
= null;" (Line176 in Hibernate 3.5.4's AbstractEntityTuplizer.java) to say
"proxyFactory = buildProxyFactory( mappingInfo, idGetter, idSetter );". Not sure
if this has side effects. See https://community.jboss.org/message/555452#555452
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:34 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
HG commented on HHH-3854:
-------------------------
I did face this problem as well. But as we were not auditing the relations and just the
individual entities, I just replaced the line :
//value =
versionsReader.getSessionImplementor().getFactory().getEntityPersister(referencedEntityName).createProxy((Serializable)
entityId, new ToOneDelegateSessionImplementor(versionsReader, entityClass, entityId,
revision, verCfg));
with value = null;
in the method mapToEntityFromMap(...)
This insures that no null pointer occured in evaluating 'value'.
This workaround works when you dont need to audit relations, i.e. only in cases where you
need to audit just the individual entities.
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:47 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Oliver Thallmair commented on HHH-3854:
---------------------------------------
I discovered this problem in my project.
The problem as was described above is that AbstractEntityTuplizer.proxyFactory == null. I
think a solution is to decide in ToOneIdMapper.mapToEntityFromMap
whether a proxy can be used or not. This can be achieved by asking the persister.
In *ToOneIdMapper.mapToEntityFromMap*:
{noformat}
else {
EntityConfiguration entCfg = verCfg.getEntCfg().get(referencedEntityName);
if(entCfg == null) {
// a relation marked as RelationTargetAuditMode.NOT_AUDITED
entCfg = verCfg.getEntCfg().getNotVersionEntityConfiguration(referencedEntityName);
}
Class<?> entityClass = ReflectionTools.loadClass(entCfg.getEntityClassName());
// THIS IS THE CHANGE:
// get the persister and ask for a proxy
// if there is one get the proxy otherwise get the object directly
EntityPersister persister =
versionsReader.getSessionImplementor().getFactory().getEntityPersister(referencedEntityName);
if(persister.hasProxy()) {
value = persister.createProxy((Serializable)entityId,
new ToOneDelegateSessionImplementor(versionsReader, entityClass, entityId,
revision, verCfg));
} else {
// get the object directly (code from ToOneDelegateSessionImplementor)
if(verCfg.getEntCfg().getNotVersionEntityConfiguration(referencedEntityName) ==
null){
// audited relation, look up entity with envers
value = versionsReader.find(entityClass, referencedEntityName, entityId, revision);
} else {
// notAudited relation, look up entity with hibernate
value =
versionsReader.getSessionImplementor().immediateLoad(referencedEntityName, (Serializable)
entityId);
}
}
}
{noformat}
This code works with the testcase. Can someone please have a look if it is a valid patch?
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:44 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
Erik-Berndt Scheper reassigned HHH-3854:
----------------------------------------
Assignee: Erik-Berndt Scheper
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Assignee: Erik-Berndt Scheper
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
HG commented on HHH-3854:
-------------------------
Hello Oliver Thallmair,
This trick definitely works well. I tested it with some test cases which I have for my
application. Solves my purpose well.
I strongly recommend to have this fix adopted by envers and released through the proper
release cycle. Its kind of cranky to use patched jars.
Could some experts really point out any flaws here ? A feedback would really be
appreciated.
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Assignee: Erik-Berndt Scheper
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:35 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854?page=c...
]
HG commented on HHH-3854:
-------------------------
@Audited(targetAuditMode = RelationTargetAuditMode.NOT_AUDITED)
With the Patch @Audited(targetAuditMode = RelationTargetAuditMode.NOT_AUDITED) does not
works.
As mentioned in the envers docs,
"If you want to audit a relation, where the target entity is not audited (that is the
case for example with dictionary-like entities, which don't change and don't have
to be audited), just annotate it with @Audited(targetAuditMode =
RelationTargetAuditMode.NOT_AUDITED). Then, when reading historic versions of your entity,
the relation will always point to the "current" related entity"
The above is not the behaviour, It behaves as if the relationship is audited. Hence, when
reading historic versions of your entity, the relation will always point to the entity at
the version in question.
But If you are using auditing, then it is not the problem, and everything else works fine
:)
Issue with greedy loading of associations (default-lazy=false )
---------------------------------------------------------------
Key: HHH-3854
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3854
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate-envers (from trunk)
Reporter: Amar Singh
Assignee: Erik-Berndt Scheper
Attachments: envers-HHH-3854-testcases.patch, greedy-loading.zip
I have an Entity GP which has a many to one association to entity CA.
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="native"/>
</id>
<property name="data"/>
<many-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK"
column="BIDIRECTIONAL_REFERENCED_ID"/>
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
</class>
</hibernate-mapping>
With this when I load a previous version of BidirectionalRefIngPK, the loading mechanism
tries to create a proxy for BidirectionalRefEdPK, but in my case lazy is false so an
internal call to createProxy will return NULL hence .
This happens in ToOneIdMapper.java in method mapToEntityFromMap around line 82, which
then internally calls for AbstractEntityTuplizer.java line 395 for getProxyFactory()
ending in NULL pointer exception because proxy factory is null as mine is a greedy
loading.
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zipped folder attached. The zipped file has 4 files:
- GreedyLoading.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- greedyloading.hbm.xml
Please place the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional), couldn't find the
right package so created test case accordingly. Put the greedyloading.hbm.xml in
src/test/resources.
Now when testng runs GreedyLoading.java you should see NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:11 a.m.
New subject: [Hibernate-JIRA] (HHH-3854) Issue with greedy loading of associations (default-lazy=false )
4424
days inactive
5737
days old
hibernate-issues@lists.jboss.org
11 comments
7 participants
participants (7)
-
Amar Singh (JIRA) -
Daniel Bleisteiner (JIRA)
-
Erik-Berndt Scheper (JIRA)
-
HG (JIRA)
-
Lukasz Antoniak (JIRA)
-
Oliver Thallmair (JIRA)
-
Robin Gersabeck (JIRA)