[Hibernate-JIRA] Created: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
12:06 p.m.
hibernate-validator-annotation-processor tests fails when running against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Kevin Pollet commented on HV-531:
---------------------------------
The problem is that the AP is annotated with
{code}
@SupportedSourceVersion(SourceVersion.RELEASE_6)
{code}
One solution might be to define the following method in the AP and remove the annotation.
{code}
@Override
public SourceVersion getSupportedSourceVersion() {
return SourceVersion.latestSupported();
}
{code}
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Kevin Pollet commented on HV-531:
---------------------------------
Another option is to set the source version flag (-source 1.6) when the source file is
compiled in the {{CompilerTestHelper#compile()}} method. By doing that a warning is
generated[1] and has to be disabled (-Xlint:-options) to have the AP tests working on
JDK7.
One drawback is that the AP cannot be used with Java 7 source files.
[1] http://blogs.oracle.com/darcy/entry/bootclasspath_older_source
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Hardy Ferentschik commented on HV-531:
--------------------------------------
Thanks for looking into this :-)
{quote}
One solution might be to define the following method in the AP and remove the annotation.
{code}
@Override
public SourceVersion getSupportedSourceVersion() {
return SourceVersion.latestSupported();
}
{code}
{quote}
That seems to be the nicest solution. Using this approach the full build works under JDK 6
and 7. I am just trying to understand the implications as well. We really want to build
the release then using JDK 7. Source compatibility should then still be to Java 5, but the
annotation processor would also work in a Java 7 environment.
Are there any drawbacks with this approach?
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:34 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Kevin Pollet commented on HV-531:
---------------------------------
I think it will work. If the AP returns {{SourceVersion.latestSupported()}} it will be
usable with Java 5/6/7 source versions and the AP can be used with JDK 7 even if it's
built with JDK 6 (on Java 7 you can run Java 6 code).
From Oracle blog:
{quote}
Have a policy for future language versions: The JSR 269 API models the current language,
but the language will be changing in some future release and annotation processors written
today could be run against new language constructs of the future.
Two basic policies are:
- Write the processor to only work with the current language version.
- Write the processor to cope with unknown future constructs.
The sample processor does the latter. It does this by returning SourceVersion.latest
rather than a particular version constant and by having the visitor's visitUnknown
method be non-fatal if called. The visitUnknown method will be called when encountering a
construct newer than the platform version the visitor was written to.
{quote}
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Hardy Ferentschik commented on HV-531:
--------------------------------------
Seems reasonable to me. Pull request created -
https://github.com/hibernate/hibernate-validator/pull/80
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:40 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-531) hibernate-validator-annotation-processor tests fails when running against JDK7
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-531?page=com...
]
Kevin Pollet resolved HV-531.
-----------------------------
Resolution: Fixed
hibernate-validator-annotation-processor tests fails when running
against JDK7
------------------------------------------------------------------------------
Key: HV-531
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-531
Project: Hibernate Validator
Issue Type: Bug
Components: annotation-processor, tests
Affects Versions: 4.2.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.3.0.next
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4777
days inactive
4778
days old
hibernate-issues@lists.jboss.org
6 comments
2 participants
participants (2)
-
Hardy Ferentschik (JIRA) -
Kevin Pollet (JIRA)