March 2010 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-4808) SessionImpl.initializeCollection() does not release JDBC connection (if outside of a transaction)

by Martin Renner (JIRA)

SessionImpl.initializeCollection() does not release JDBC connection (if outside of a transaction) ------------------------------------------------------------------------------------------------- Key: HHH-4808 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4808 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.2, 3.2.7 Reporter: Martin Renner Priority: Critical With {{ConnectionReleaseMode.AFTER_TRANSACTION}} (the default), Hibernate does not release the JDBC connection when resolving a lazily loaded collection, if this happens *outside* of an active transaction. First, I will describe, what happens if Hibernate executes a query outside of a transaction. Then I will describe how lazy collection loading behaves differently. When the method {{list}} of a query ({{QueryImpl.java}}) is getting called, Hibernate delegates to {{SessionImpl.list()}}. After having loaded the list, {{SessionImpl.list()}} calls {{SessionImpl.afterOperation()}}, which calls {{jdbcContext.afterNontransactionalQuery()}} (as there is no active transaction). This leads to {{ConnectionManager.afterTransaction()}} which releases the JDBC connection. This is exactly what I expect to happen. Now to the lazily loaded collection: {{Hibernate.initialize(collection)}} and {{person.getPets().size()}} both end up in {{SessionImpl.initializeCollection()}}. This call gets dispatched down to {{Loader.doQueryAndInitializeNonLazyCollections()}} and {{Loader.doQuery()}}. The important fact is, that {{ConnectionManager.afterTransaction()}} never gets called (like in the query-example above). The result is, that the JDBC connection is not released. IMHO resolving of a lazily loaded collection should behave like executing a query. {{SessionImpl.initializeCollection()}} should call {{SessionImpl.afterOperation()}} in the same way as {{SessionImpl.list()}} is doing this. I will attach a small demo application which shows the difference (concerning {{ConnectionManager}}) between queries and collections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

2
5
0 / 0

[Hibernate-JIRA] Created: (HHH-3307) HQL query translation in real SQL ignores the dialect class

by Thomas Schilf (JIRA)

HQL query translation in real SQL ignores the dialect class ----------------------------------------------------------- Key: HHH-3307 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3307 Project: Hibernate3 Issue Type: Bug Components: query-hql Affects Versions: 3.2.6 Environment: dialect file with special JoinFragment and a "transformSelectString" step Reporter: Thomas Schilf We're using a special dialect class for a database. In the dialect is defined a own JoinFragment and a "transformSelectString" step. All workes fine by loading objects over a Criteria class. The generated SQL string is wrong by using named queries (HQL). The SQL string is in normal ANSI-SQL. The SqlGenerator and QueryTranslatorImpl classes from hibernate don't use the dialect class. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

2
3
0 / 0

[Hibernate-JIRA] Created: (EJB-361) Query#setParameter(int position, Object value) wrong implementation

by Fabrice Daugan (JIRA)

Query#setParameter(int position, Object value) wrong implementation ------------------------------------------------------------------- Key: EJB-361 URL: http://opensource.atlassian.com/projects/hibernate/browse/EJB-361 Project: Hibernate Entity Manager Issue Type: Bug Components: EntityManager Affects Versions: 3.3.2.GA Reporter: Fabrice Daugan The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value) implementation does not suit to the JPA specicafication. Indeed, the actual integer passed to the operation is converted to String by Hibernate and then used to find the named parameter. Please have a look to the folowing stack trace : java.lang.Thread.run(Thread.java:619) Caused by: java.lang.IllegalArgumentException: org.hibernate.QueryParameterException: could not locate named parameter [1] at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185) at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240) at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316) To repoduce this error : -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

3
4
0 / 0

[Hibernate-JIRA] Created: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

by Igor Vaynberg (JIRA)

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

16
58
0 / 0

[Hibernate-JIRA] Created: (HHH-4699) String mapped ENUMs can't be loaded from CHARs only VARCHARS (fix is trivial)

by Pierce Wetter (JIRA)

String mapped ENUMs can't be loaded from CHARs only VARCHARS (fix is trivial) ----------------------------------------------------------------------------- Key: HHH-4699 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4699 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.5 Environment: all Reporter: Pierce Wetter An enum persisted as a string to a CHAR column comes back with extra spaces appended, so then fails the Enum.valueOf() lookup. Fix is easy: Line 132 of EnumType.java, method nullSafeGet, change: return Enum.valueOf( enumClass, name ); to return Enum.valueOf( enumClass, name.trim() ); Which should be perfectly logical, because spaces are illegal in enum names anyways. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

4
7
0 / 0

[Hibernate-JIRA] Created: (HV-161) Hibernate Validator does not validate several groups in // during one navigation path

by Emmanuel Bernard (JIRA)

Hibernate Validator does not validate several groups in // during one navigation path ------------------------------------------------------------------------------------- Key: HV-161 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-161 Project: Hibernate Validator Issue Type: Improvement Components: engine Affects Versions: 4.0.0.Beta1 Reporter: Emmanuel Bernard Priority: Critical Fix For: 4.0.0.Beta2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

2
8
0 / 0

[Hibernate-JIRA] Created: (HHH-4962) @ManyToOne with @JoinTable fails

by Clint Popetz (JIRA)

@ManyToOne with @JoinTable fails -------------------------------- Key: HHH-4962 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4962 Project: Hibernate Core Issue Type: Bug Components: envers Affects Versions: 3.3.2 Reporter: Clint Popetz $ cat src/main/java/test/User.java package test; import javax.persistence.*; import org.hibernate.envers.Audited; import java.util.Set; The below code fails with "org.hibernate.MappingException: Unable to read the mapped by attribute for widgets in test.User!" but is supported by JPA, at least under hibernate. @Entity @Audited public class User { @Id private long id; @OneToMany(mappedBy="user") private Set<Widget> widgets; } $ cat src/main/java/test/Widget.java package test; import javax.persistence.*; import org.hibernate.envers.Audited; @Entity @Audited public class Widget { @Id private long id; @ManyToOne(fetch=FetchType.LAZY) @JoinTable(name = "widget_to_user", joinColumns = @JoinColumn(name = "widget_id"), inverseJoinColumns = @JoinColumn(name = "user_id")) private User user; } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

6
8
0 / 0

[Hibernate-JIRA] Created: (HV-264) Validation of List of primitives

by Michenaud Laurent (JIRA)

Validation of List of primitives -------------------------------- Key: HV-264 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-264 Project: Hibernate Validator Issue Type: Bug Components: engine Affects Versions: 4.0.1 Environment: Linux Reporter: Michenaud Laurent Hi, I have a list of String in my bean : These strings are email and i want to validate them. So, i did in my bean : @NotEmpty @Email //@Valid <= uncommenting that line doesnot change anything. List<String> emails ; At execution, i've got the error : Exception in thread "main" javax.validation.UnexpectedTypeException: No validator could be found for type: java.util.List<java.lang.String> at org.hibernate.validator.engine.ConstraintTree.verifyResolveWasUnique(ConstraintTree.java:236) at org.hibernate.validator.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:219) at org.hibernate.validator.engine.ConstraintTree.getInitializedValidator(ConstraintTree.java:167) at org.hibernate.validator.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113) at org.hibernate.validator.metadata.MetaConstraint.validateConstraint(MetaConstraint.java:121) at org.hibernate.validator.engine.ValidatorImpl.validateConstraint(ValidatorImpl.java:334) at org.hibernate.validator.engine.ValidatorImpl.validateConstraintsForRedefinedDefaultGroup(ValidatorImpl.java:278) at org.hibernate.validator.engine.ValidatorImpl.validateConstraintsForCurrentGroup(ValidatorImpl.java:260) at org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:213) at org.hibernate.validator.engine.ValidatorImpl.validate(ValidatorImpl.java:119) at com.adeuza.movalys.validation.hibernate.TestMain.main(TestMain.java:75) I don't know if it is a bug in hibernate validator. I have looked at the JSR303 and i have not seen anything about List of primitives. You can validate per example List<Person> with @Valid and it works well because the validator knows about Person class. I have used a little the Oval framework and with it, you can tell if the check applies to the container, or the values inside, or the keys(for map). I don't know if you can do that with JSR303. I'm interesting with your point of view. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

3
12
0 / 0

[Hibernate-JIRA] Created: (HV-270) Verify in the annotation processor that constraints are not stupid

by Emmanuel Bernard (JIRA)

Verify in the annotation processor that constraints are not stupid ------------------------------------------------------------------ Key: HV-270 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-270 Project: Hibernate Validator Issue Type: New Feature Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik For example @Pattern shoudl ahve a valid regular exception @Size should have min <= max etc -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

3
10
0 / 0

[Hibernate-JIRA] Created: (HV-135) Constraints can contains constraint annotations to validate params before initialize is called

by Emmanuel Bernard (JIRA)

Constraints can contains constraint annotations to validate params before initialize is called ---------------------------------------------------------------------------------------------- Key: HV-135 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-135 Project: Hibernate Validator Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard not high priority >From Sebastian Thomschke -------------------------------------- I just had a look through the Hibernate Validator code, what struck me was the way how you validate parameters. E.g. private void validateParameters() { if ( min < 0 ) { throw new ValidationException( "The min parameter cannot be negative." ); } if ( max < 0 ) { throw new ValidationException( "The max paramter cannot be negative." ); } if ( max < min ) { throw new ValidationException( "The length cannot be negative." ); } } I just had the idea, why don't we use the constraint annotations for the built-in constraints themselves? E.g. /** * @return size the element must be higher or equal to */ @Min(0) int min() default 0; /** * @return size the element must be lower or equal to */ @Min(0) int max() default Integer.MAX_VALUE; Then this kind of parameter validation could be done by the framework and must not be repeated in every validator implementation. What do you think? Regards, Seb -------------------------------------- Emmanuel Your idea is interesting. It could lead to infinite recursion if someone does not pay attention but could work. I think it would better be a product feature though instead of a spec feature for this rev at least. We can't have "class" level constraints though as it conflicts with the composition model. WDYT? it seems to me that the ValidationException is wrong in the example you gave. http://opensource.atlassian.com/projects/hibernate/browse/HV-134 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years

2
3
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues March 2010