[Hibernate-JIRA] Created: (HHH-5998) Illegal parenthesis in generated Oracle SQL SELECT clause (when using subselect)
by Thomas Zangerl (JIRA)
Illegal parenthesis in generated Oracle SQL SELECT clause (when using subselect)
--------------------------------------------------------------------------------
Key: HHH-5998
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5998
Project: Hibernate Core
Issue Type: Bug
Components: query-hql
Affects Versions: 3.6.0
Environment: Hibernate 3.6.0.Final (shipped as part of JBoss runtime environment 6), Oracle Database 10g Enterprise Edition Release 10.2.0.1.0 - 64bit
Reporter: Thomas Zangerl
Hi,
when using an HQL subselect with EXISTS where the selected object in the subselect is an entity with a composite primary key (mapping a join-table), Hibernate adds parenthesis to the query-list with the selected columns. Oracle does not accept SELECT statements with parenthesis around the query-list and fails.
Consider the following entities (non-relevant members omitted):
{code:java}
@Entity
@Table(name = "DEMANDE_MODULES")
public class ModulesRequest implements Serializable {
/**
* generated serialVersionUID
*/
private static final long serialVersionUID = -9083049226182530936L;
private Long id;
@Id
@Column(name = "DMD_ID")
@GeneratedValue(strategy=GenerationType.SEQUENCE, generator="demandeSeq")
@SequenceGenerator(name="demandeSeq", sequenceName="S_EVA_DMD_ID", allocationSize = 1)
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
}
{code}
{code:java}
@Entity
@Table(name = "EVALUATION")
public class Evaluation implements Serializable {
/**
* generated serialVersionUID
*/
private static final long serialVersionUID = -7258988774554733242L;
private Long id;
@Id
@Column(name = "EVA_ID")
@GeneratedValue(strategy = GenerationType.SEQUENCE, generator="evaluationSeq")
@SequenceGenerator(name="evaluationSeq", sequenceName="S_EVA_ID", allocationSize = 1)
public Long getId() {
return id;
}
public void setId(Long id) {
this.id = id;
}
}
{code}
{code:java}
@Entity
@Table(name = "DEMANDE_EVALUATION")
@AssociationOverrides({
@AssociationOverride(name = "pk.request", joinColumns=@JoinColumn(name = "DMD_ID")),
@AssociationOverride(name = "pk.evaluation", joinColumns=@JoinColumn(name = "EVA_ID"))
})
public class EvaluationRequest implements Serializable {
/**
* generated serialVersionUID
*/
private static final long serialVersionUID = -7511793462359852575L;
private EvaluationRequestId pk;
public EvaluationRequest() {
this.pk = new EvaluationRequestId();
}
@EmbeddedId
public EvaluationRequestId getPk() {
return pk;
}
public void setPk(EvaluationRequestId pk) {
this.pk = pk;
}
}
{code}
{code:java}
@Embeddable
public class EvaluationRequestId implements Serializable {
/**
* generated serialVersionUID
*/
private static final long serialVersionUID = -2708732283791960577L;
private ModulesRequest request;
private Evaluation evaluation;
public void setRequest(ModulesRequest request) {
this.request = request;
}
@ManyToOne
@ForeignKey(name="FK_DMD_EVA_DMD_EVALUATIONS")
public ModulesRequest getRequest() {
return request;
}
public void setEvaluation(Evaluation evaluation) {
this.evaluation = evaluation;
}
@ManyToOne
@ForeignKey(name="FK_DMD_EVA_EVALUATION")
public Evaluation getEvaluation() {
return evaluation;
}
}
{code}
EvaluationRequest is a join table between Evaluation and ModulesRequest, hence the primary key is the composite of the primary keys of Evaluation and ModulesRequest.
If I now execute the following EJB-QL query
{code:java}
String testQuery = "SELECT request " +
"FROM ModulesRequest request " +
"WHERE EXISTS (" +
" SELECT evRequest " +
" FROM request.evaluationRequests evRequest) ";
Query testq = em.createQuery(testQuery);
testq.getResultList();
{code}
Hibernate generates the following SQL command from the above EJB-QL:
{code:sql}
select
modulesreq0_.DMD_ID as DMD1_145_,
modulesreq0_.COMMENTAIRE as COMMENTA2_145_,
modulesreq0_.SFP_ID as SFP3_145_,
modulesreq0_.SEM_ID as SEM4_145_
from
DEMANDE_MODULES modulesreq0_
where
exists (
select
(evaluation1_.EVA_ID,
evaluation1_.DMD_ID)
from
DEMANDE_EVALUATION evaluation1_
where
modulesreq0_.DMD_ID=evaluation1_.DMD_ID
)
{code}
This SQL fails in the second SELECT because Oracle does not accept parantheses in a select statement:
{code}
14:42:41,706 ERROR [org.hibernate.util.JDBCExceptionReporter] ORA-00907: missing right parenthesis
{code}
The parantheses do not get included if the EJBQL selects directly on EvalauationRequest (and not as a part of a subselect in EXISTS).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months
[Hibernate-JIRA] Created: (HSEARCH-954) BackendQueueProcessor should specify behaviour for the case of null passed to applyWork and applyStream work
by Hardy Ferentschik (JIRA)
BackendQueueProcessor should specify behaviour for the case of null passed to applyWork and applyStream work
------------------------------------------------------------------------------------------------------------
Key: HSEARCH-954
URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-954
Project: Hibernate Search
Issue Type: Bug
Components: engine
Affects Versions: 4.0.0.CR1
Reporter: Hardy Ferentschik
Fix For: 4.0
I think IllegalArgumentException would make sense. A testcase could look like this:
{code}
/*
* JBoss, Home of Professional Open Source
* Copyright 2011 Red Hat Inc. and/or its affiliates and other contributors
* as indicated by the @authors tag. All rights reserved.
* See the copyright.txt in the distribution for a
* full listing of individual contributors.
*
* This copyrighted material is made available to anyone wishing to use,
* modify, copy, or redistribute it subject to the terms and conditions
* of the GNU Lesser General Public License, v. 2.1.
* This program is distributed in the hope that it will be useful, but WITHOUT A
* WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
* PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details.
* You should have received a copy of the GNU Lesser General Public License,
* v.2.1 along with this distribution; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
* MA 02110-1301, USA.
*/
package org.hibernate.search.test.backend;
import javax.persistence.Entity;
import javax.persistence.Id;
import org.junit.Test;
import org.hibernate.search.annotations.Indexed;
import org.hibernate.search.backend.impl.lucene.LuceneBackendQueueProcessor;
import org.hibernate.search.engine.spi.EntityIndexBinder;
import org.hibernate.search.impl.MutableSearchFactory;
import org.hibernate.search.indexes.impl.DirectoryBasedIndexManager;
import org.hibernate.search.indexes.spi.IndexManager;
import org.hibernate.search.test.SearchTestCase;
public class BackQueueProcessorTest extends SearchTestCase {
@Test
public void testNullWorkThrowsIllegalArgumentException() {
LuceneBackendQueueProcessor backend = getBackendQueueProcessor();
try {
backend.applyStreamWork( null );
fail( "Should throw IllegalArgumentException" );
}
catch ( IllegalArgumentException i ) {
// pass
}
try {
backend.applyWork( null );
fail( "Should throw IllegalArgumentException" );
}
catch ( IllegalArgumentException i ) {
// pass
}
}
private LuceneBackendQueueProcessor getBackendQueueProcessor() {
MutableSearchFactory searchFactory = (MutableSearchFactory) getSearchFactory();
EntityIndexBinder indexBindingForEntity = searchFactory.getIndexBindingForEntity( Foo.class );
IndexManager[] indexManagers = indexBindingForEntity.getIndexManagers();
assertEquals( 1, indexManagers.length );
DirectoryBasedIndexManager indexManager = (DirectoryBasedIndexManager) indexManagers[0];
return (LuceneBackendQueueProcessor) indexManager.getBackendQueueProcessor();
}
@Override
protected void configure(org.hibernate.cfg.Configuration cfg) {
super.configure( cfg );
}
@Override
protected Class<?>[] getAnnotatedClasses() {
return new Class[] { Foo.class };
}
@Entity
@Indexed
public class Foo {
@Id
int id;
}
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months
[Hibernate-JIRA] Created: (HHH-3843) @Audited and @ManyToMany relation problem - after modyfing an Entity: org.hibernate.NonUniqueObjectException with message: "a different object with the same identifier value was already associated with the session ...
by Michał Maryniak (JIRA)
@Audited and @ManyToMany relation problem - after modyfing an Entity: org.hibernate.NonUniqueObjectException with message: "a different object with the same identifier value was already associated with the session ...
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: HHH-3843
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3843
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.1
Environment: envers.jar 1.2.0, Hibernate 3.3.1, postgresql-8.3, jboss-4.2.3
Reporter: Michał Maryniak
Attachments: enverse.7z
There is a problem with unidirectional @ManyToMany relation.
This case is different than the one with inheritance: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3830.
The example is trival and code is as simple as it can be.
A single Person can have many roles, and one Role can by assigned to many Person entities.
@Entity
@Audited
public class Person implements Serializable {
(...)
@ManyToMany
public List<Role> getRoles() {
return roles;
}
(...)
}
and
@Entity
@Audited
public class Role implements Serializable {
(...)
}
And here comes a use case:
1) I create role 'admin'
2) I create role 'user'
3) I create person 'john' and add him a role 'admin'
4) I edit 'john' and add him second role 'user'
and I got an exception:
org.hibernate.NonUniqueObjectException with message: "a different object with the same identifier value was already associated with the session: [Person_Role_AUD#{roles_id=1, Person_id=5, REV=DefaultRevisionEntity(id = 7, revisionDate = 2009-04-01 10:46:32)}]"
If I add one role and remove the second one, or if I only remove a role - an Exception does not occur.
I attached a zip file with this simple SEAM project generated by seam-gen 2.1.1 GA.
I haven't included jar files, but project requires jar's "generated" with seam-gen (2.1.1) and following jar's have been replaced with new ones:
2008-06-13 13:09 313˙898 dom4j.jar 1.6.1
2009-03-23 13:01 285˙158 envers.jar 1.2.0-hibernate-3.3
2008-08-20 11:27 279˙714 hibernate-annotations.jar 3.4.0.GA
2008-08-20 11:31 66˙993 hibernate-commons-annotations.jar 3.1.0.GA
2008-08-20 12:19 119˙292 hibernate-entitymanager.jar 3.4.0.GA
2008-12-04 14:39 304˙236 hibernate-search.jar 3.1.0.GA
2008-09-10 14:01 62˙574 hibernate-validator.jar 3.1.0.GA
2008-09-10 13:27 2˙766˙130 hibernate.jar from hibernate-distribution-3.3.1.GA-dist
2008-06-13 13:09 13˙236 jta.jar 1.1 (from hibernate-distribution-3.3.1.GA-dist)
2008-12-04 14:41 818˙961 lucene-core.jar 2.4.0 701827 - 2008-10-05 16:44:37
2008-08-19 20:40 17˙384 slf4j-api.jar 1.5.2
If you wish - I can attach a file with my oryginal jar - but it would be a realy big file ;-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months
[Hibernate-JIRA] Created: (HSEARCH-949) Update online documentation
by Hardy Ferentschik (JIRA)
Update online documentation
---------------------------
Key: HSEARCH-949
URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-949
Project: Hibernate Search
Issue Type: Task
Components: documentation
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.0
In articular the architecture and configuration chapters need updating after the extensive 4.0 refactoring.
The idea is to move the _IndexManager_ into the center.
from hibernate-dev mailing list
{quote}
Here is how I think we could arrange the content (correct me from wrong).
The basic idea is that
the IndexManager moves into focus.
I think this is also already implied by the following:
"The default IndexManager implementation is named transactional. This is
the one mostly referred to in this documentation,
unless stated otherwise, and is highly configurable as you can select
different implementations for the reader strategy,
back ends and Directory Providers"
For me the architecture is not as follows:
* each entity can be indexed into one (ore more) Lucene index
* each Lucene index has a IndexManager
* the index manager gives access to directory and reader provider as well
as the backend to be used
* when using properties of the form org.hibernate.search.<index-name>.xyz
you are effectively configuring the
IndexManager for the specified index
* properties of the form org.hibernate.search.default.xyz are default values which apply for any index manager if
not overridden explicitly
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months
[Hibernate-JIRA] Created: (HHH-6698) Query Parameters Not Bound Correctly
by Erich Heard (JIRA)
Query Parameters Not Bound Correctly
------------------------------------
Key: HHH-6698
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6698
Project: Hibernate Core
Issue Type: Bug
Components: query-hql, query-sql
Affects Versions: 3.6.0
Environment: Hibernate 3.6.0, Windows, Oracle 10g and MySQL 5.1
Reporter: Erich Heard
When an entity has a compound key made up of, in part, another entity's compound key, it seems that Hibernate does not bind parameters to the correct columns in SQL translated from HQL. It seems that the routine used to build the SQL statement via Antlr can list primary key columns in a different order than the routine that builds parameter values via reflection. Bascially, you end up with a condition like:
PK_COL_1 = ? and
PK_COL_2 = ?
and the bound values are for :pkCol2 and :pkCol1 respectively. Depending on how an HQL query is written, you can actually get the query translator to build a join this way:
TABLE1.PK_COL_1 = TABLE2.PK_COL_2 and
TABLE1.PK_COL_2 = TABLE2.PK_COL_1
Depending on the data type, this can either cause an error or an empty result set. I did a good bit of debugging, but did not find an easy solution that didn't break something else worse. I did find that explicitly setting @JoinColumn.referencedColumnName in the child ID class did force things to work correctly against Oracle but MySQL is syntactically different enough that it does not work there. I will attach an example shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 5 months