June 2012 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-6100) Bug fix related to CriteriaQuery (JPA) when using XML mappings

by JOUFFRE Nelly (JIRA)

Bug fix related to CriteriaQuery (JPA) when using XML mappings -------------------------------------------------------------- Key: HHH-6100 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6100 Project: Hibernate Core Issue Type: Patch Affects Versions: 3.6.2 Environment: hibernate-(core, entitymanager...)-3.6.2.Final hibernate-jpa-2.0-api-1.0.0.Final MySQL 5.1 Spring 3.0.5.RELEASE Reporter: JOUFFRE Nelly Priority: Critical Hi, I use XML mapping and wanted to implement the following query using CriteriaQuery. CriteriaBuilder cb = entityManager.getCriteriaBuilder(); CriteriaQuery<MyClass> cq = cb.createQuery(MyClass.class); Root<MyClass> objRoot = cq.from(MyClass.class); List<MyClass> results = entityManager.createQuery(cq).getResultList(); (Actually my query is more complex than that but it was the first step.) The first bug was that query generated the following jpql select generatedAlias0 from null as generatedAlias0 This was because the org.hibernate.mapping.PersistentClass.jpaEntityName attribute was not set Once I fixed it if tried to add a WHERE clause which was cq.where(cb.equal(objRoot.get("embeddablePkId").get("embeddablePkIdAttribute"), "valueToSearch")); which resulted into a NullPointerException because the org.hibernate.mapping.RootClass.declaredIdentifierProperty attribute was not set for simple and embeddable PK Theses 2 attributes are well set but only when using annotation mappings because they are set via the AnnotationBinder. In my case, with XML mapping, it calls the HbmBinder so these attributes are never set. Here are my bug fixes, hope this help. Cheers, $ git diff diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/HbmBinder.java b/hib index dd0e14a..4cacb8e 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/HbmBinder.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/HbmBinder.java @@ -451,6 +451,7 @@ public final class HbmBinder { prop.setValue( id ); bindProperty( idNode, prop, mappings, inheritedMetas ); entity.setIdentifierProperty( prop ); + entity.setDeclaredIdentifierProperty( prop ); } // TODO: @@ -484,6 +485,7 @@ public final class HbmBinder { prop.setValue( id ); bindProperty( idNode, prop, mappings, inheritedMetas ); entity.setIdentifierProperty( prop ); + entity.setDeclaredIdentifierProperty( prop ); } makeIdentifier( idNode, id, mappings ); @@ -564,6 +566,7 @@ public final class HbmBinder { throw new MappingException( "Unable to determine entity } persistentClass.setEntityName( entityName ); + persistentClass.setJpaEntityName( entityName ); bindPojoRepresentation( node, persistentClass, mappings, inherit bindDom4jRepresentation( node, persistentClass, mappings, inheri (END) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

7
14
0 / 0

[Hibernate-JIRA] Created: (HHH-6204) JoinColumn on non key field fails to populate collection

by Chris Sams (JIRA)

JoinColumn on non key field fails to populate collection -------------------------------------------------------- Key: HHH-6204 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6204 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 4.0.0.Alpha3, 3.6.4, 4.0.0.Alpha2, 3.6.3, 4.0.0.Alpha1, 3.6.2, 3.6.1, 3.6.0, 3.6.0.CR2, 3.6.0.CR1, 3.6.0.Beta4, 3.6.0.Beta3, 3.6.0.Beta2, 3.6.0.Beta1, 3.3.2 Environment: EAP 5 (hibernate 3.3.2), hibernate 3.6.x, 4.0.x , probably eap4 as well Reporter: Chris Sams Attachments: CompositeKeyExample.zip To duplicate the issue, create three tables in a database with no declared primary or foreign keys. Map entities to two of the tables. One of these entities has a primitive @Id; the other has an @EmbeddedId. Both entities contain an additional field used to join with the third table and populate a collection. This works with the entity that has a primitive @Id but for the entity with @EmbeddedId, trying to do anything with the collection after calling the getter results in: javax.ejb.EJBException: org.hibernate.PropertyAccessException: could not get a field value by reflection getter of jboss.example.DoesNotWorkPk.id1 at org.jboss.ejb3.tx.Ejb3TxPolicy.handleExceptionInOurTx(Ejb3TxPolicy.java:77) .... Caused by: org.hibernate.PropertyAccessException: could not get a field value by reflection getter of jboss.example.DoesNotWorkPk.id1 at org.hibernate.property.DirectPropertyAccessor$DirectGetter.get(DirectPropertyAccessor.java:58) .... Caused by: java.lang.IllegalArgumentException: Can not set java.lang.String field jboss.example.DoesNotWorkPk.id1 to jboss.example.DoesNotWork at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:146) I've attached a sample project. The relevant files are Works.java, DoesNotWork.java, and DoesNotWorkPk.java There's also data.sql along with the java files to populate a mysql db, but I think any DB will do. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

3
8
0 / 0

[Hibernate-JIRA] Created: (HHH-6877) Multiple LEFT OUTER JOIN subcriterias filters middle level children

by Mattias Jiderhamn (JIRA)

Multiple LEFT OUTER JOIN subcriterias filters middle level children ------------------------------------------------------------------- Key: HHH-6877 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6877 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.6.4 Reporter: Mattias Jiderhamn Priority: Minor The fix for HHH-2049 was only partial, as it will still filter LEFT OUTER JOIN:ed children on levels without any restrictions. See https://hibernate.onjira.com/browse/HHH-2049?focusedCommentId=42499&page=... for more details. Pull request includes test case and fix. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

3
6
0 / 0

[Hibernate-JIRA] Created: (OGM-172) Create indexes for identifier columns that are not '_id'

by Emmanuel Bernard (JIRA)

Create indexes for identifier columns that are not '_id' -------------------------------------------------------- Key: OGM-172 URL: https://hibernate.onjira.com/browse/OGM-172 Project: Hibernate OGM Issue Type: Improvement Reporter: Emmanuel Bernard At DatastoreProvider bootstrap we could make sure indexes exist or otherwise create them for all columns involved in a lookup. ie the identifier columns for entities, associations and sequences. This is related to OGM-156 and arguably a better approach. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

3
8
0 / 0

[Hibernate-JIRA] Created: (OGM-182) Support Neo4j as Datastore

by Pawel Kozlowski (JIRA)

Support Neo4j as Datastore -------------------------- Key: OGM-182 URL: https://hibernate.onjira.com/browse/OGM-182 Project: Hibernate OGM Issue Type: New Feature Reporter: Pawel Kozlowski Integrate Neo4J as a datastore for Hibernate OGM. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-2851) ParameterTranslationsImpl fails to correctly determine parameter type

by Alex Savitsky (JIRA)

ParameterTranslationsImpl fails to correctly determine parameter type --------------------------------------------------------------------- Key: HHH-2851 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2851 Project: Hibernate3 Issue Type: Bug Components: query-hql Affects Versions: 3.2.5 Reporter: Alex Savitsky Priority: Minor For the conditions in the form "(:param IS NULL OR alias.someField = :param)", the HQL parses would not correctly determine the type of param, unless the conditions are swapped like "(alias.someField = :param OR :param IS NULL)". The reason is that NamedParamTempHolder classes are created for all parameter entries, in the order they appear in the query. The first occurrence (:param IS NULL) would have its expectedType set to null, and the second occurrence would use the param holder created by the first occurrence, without checking whether it can improve it in any way (which it can - the expectedType for second occurrence is correctly determined to be Long). Proposed fix would be to check for this particular condition, enhancing paramHolder if possible, with new information: old code: if ( paramHolder == null ) { paramHolder = new NamedParamTempHolder(); paramHolder.name = namedSpec.getName(); paramHolder.type = namedSpec.getExpectedType(); namedParameterMap.put( namedSpec.getName(), paramHolder ); } new code: if ( paramHolder == null ) { paramHolder = new NamedParamTempHolder(); paramHolder.name = namedSpec.getName(); paramHolder.type = namedSpec.getExpectedType(); namedParameterMap.put( namedSpec.getName(), paramHolder ); + } else if (paramHolder.getExpectedType() == null && namedSpec.getExpectedType() != null) { + paramHolder.type = namedSpec.getExpectedType(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 8 months

6
10
0 / 0

[Hibernate-JIRA] Created: (HHH-7275) {h-schema} tag is not replaced in discriminator formula

by Glen Leskinen (JIRA)

{h-schema} tag is not replaced in discriminator formula ------------------------------------------------------- Key: HHH-7275 URL: https://hibernate.onjira.com/browse/HHH-7275 Project: Hibernate ORM Issue Type: Bug Reporter: Glen Leskinen It is currently possible to embed {h-schema} in sql defined in <sql-query> tags and have the place holder be replaced by the value of the default_schema property. However, we can place native sql in discriminator formulas and {h-schema} is not replaced there. <discriminator formula="(select d.defn_type_name from {h-schema}defn d where d.defn_id = defn_id)" type="string" /> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-900) faceting with manytoone relationship give wrong faceting count

by pragnesh (JIRA)

faceting with manytoone relationship give wrong faceting count -------------------------------------------------------------- Key: HSEARCH-900 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-900 Project: Hibernate Search Issue Type: Bug Components: query Affects Versions: 4.0.0.Alpha1, 3.4.1.Final, 3.4.0.Final Environment: mysql 5.1.41, linux Reporter: pragnesh Attachments: facet_test.zip faceting with manytoone realtionship give wrong faceting count, although it show correct faceting item, I have create minimal test in hibernate search codebase. Please look into attached zip file,drop java file into corrosponding package and test it. related hibernate forum discussion -> https://forum.hibernate.org/viewtopic.php?f=9&t=1012464 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

5
12
0 / 0

[Hibernate-JIRA] Created: (HHH-2394) Support filter tag in subclass

by Welkin Hu (JIRA)

Support filter tag in subclass ------------------------------ Key: HHH-2394 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2394 Project: Hibernate3 Type: Improvement Components: core Versions: 3.0 beta 4 Reporter: Welkin Hu Assigned to: Steve Ebersole Fix For: 3.0 rc 1 According to a user: http://forum.hibernate.org/viewtopic.php?p=2229539#2229539 It's not possible to get a filter to apply to a subclass. This is Bad ;-) Steve, is that correct? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

7
9
0 / 0

[Hibernate-JIRA] Created: (HBX-1123) Reveng foreign-key map to non-primary key column produces incorrect mapping file

by Michael Sabin (JIRA)

Reveng foreign-key map to non-primary key column produces incorrect mapping file -------------------------------------------------------------------------------- Key: HBX-1123 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1123 Project: Hibernate Tools Issue Type: Bug Affects Versions: 3.2.4 Beta1 Environment: Eclipse Platform Version: 3.4.2 Build id: M20090211-1700 Hibernate Tools 3.2.4.GA-R200903141626-H5 Windows XP Pro SP3 JRE 6 Tested on Oracle 10g and Apache Derby Reporter: Michael Sabin Priority: Minor Attachments: CodeGenCfg1.png, CodeGenCfg2.png Creating a mapping from a column in one table to a non-primary key column in another table produces incorrect mapping file missing a property-ref to the non-primary key. How to reproduce using Apache Derby: Create a database and connect to the database. jdbc:derby://localhost:1527/myDB;create=true;user=me;password=mine Create these tables in the myDB database, in the ME schema. create table vehicles ( make_id integer, model_id integer, name varchar(50), PRIMARY KEY (make_id, model_id) ); create table owners ( owner_id integer PRIMARY KEY, favorite_make_id integer, name varchar(20) ); -- optional content insert into vehicles values (1, 10, 'Chevrolet Corvette'); insert into vehicles values (2, 11, 'Ford Focus'); insert into vehicles values (3, 12, 'Honda Accord'); insert into vehicles values (4, 13, 'Toyota Camry'); insert into owners values (50, 3, 'Jim'); insert into owners values (51, 1, 'Alex'); insert into owners values (52, 4, 'Sue'); insert into owners values (53, 1, 'Casey'); Create this Hibernate Configuration file. <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE hibernate-configuration PUBLIC "-//Hibernate/Hibernate Configuration DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-configuration-3.0.dtd"> <hibernate-configuration> <session-factory> <property name="hibernate.connection.driver_class">org.apache.derby.jdbc.EmbeddedDriver</property> <property name="hibernate.connection.url">jdbc:derby://localhost:1527/myDB</property> <property name="hibernate.connection.username">me</property> <property name="hibernate.connection.password">mine</property> <property name="hibernate.dialect">org.hibernate.dialect.DerbyDialect</property> <property name="hibernate.current_session_context_class">thread</property> <property name="hibernate.default_schema">ME</property> <property name="hibernate.show_sql">true</property> </session-factory> </hibernate-configuration> Setup a Hibernate Console Configuration with the configuration above and connection to the Derby database. Create this Hibernate reverse engineering configuration <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE hibernate-reverse-engineering PUBLIC "-//Hibernate/Hibernate Reverse Engineering DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-reverse-engineering-3.0.dtd" > <hibernate-reverse-engineering> <table-filter match-name="OWNERS"/> <table-filter match-name="VEHICLES"/> <table name="VEHICLES"> <foreign-key foreign-table="OWNERS"> <column-ref local-column="MAKE_ID" foreign-column="FAVORITE_MAKE_ID" /> </foreign-key> </table> </hibernate-reverse-engineering> Setup a Hibernate Code Generation configuration like in the attached images. Running the Code Generation configuration will produce this Vehicles.hbm.xml mapping file. <?xml version="1.0"?> <!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd"> <hibernate-mapping> <class name="reveng.Vehicles" table="VEHICLES"> <composite-id name="id" class="reveng.VehiclesId"> <key-property name="makeId" type="int"> <column name="MAKE_ID" /> </key-property> <key-property name="modelId" type="int"> <column name="MODEL_ID" /> </key-property> </composite-id> <many-to-one name="owners" class="reveng.Owners" update="false" insert="false" fetch="select"> <column name="MAKE_ID" not-null="true" /> </many-to-one> <property name="name" type="string"> <column name="NAME" length="50" /> </property> </class> </hibernate-mapping> The many-to-one tag should have this additional attribute: property-ref="favoriteMakeId" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 9 months

2
1
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2012