March 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-4830) Test Hibernate Search regularly against Hibernate ORM 6.3.0-SNAPSHOT

by Automation for Jira (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16405) Eager fields are not fetched when using ScrollableResults

by Orlando Pirlog (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16405) Eager fields are not fetched when using ScrollableResults

by Orlando Pirlog (JIRA)

Orlando Pirlog ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d5277e... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDRmMTRjZWZk... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16405?atlOrigin=eyJpIjoiNDRmMT... ) HHH-16405 ( https://hibernate.atlassian.net/browse/HHH-16405?atlOrigin=eyJpIjoiNDRmMT... ) Eager fields are not fetched when using ScrollableResults ( https://hibernate.atlassian.net/browse/HHH-16405?atlOrigin=eyJpIjoiNDRmMT... ) Issue Type: Bug Affects Versions: 5.3.11, 5.6.15 Assignee: Unassigned Components: hibernate-core Created: 30/Mar/2023 07:31 AM Priority: Major Reporter: Orlando Pirlog ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d5277e... ) Let’s consider that we have two entities: Course and Student, where Student has many Course(s), a one-to-many relation like in the below example: @Entity @Table(name = "courses") public class Course implements Serializable { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) @Column(name = "course_id", unique = true, nullable = false) protected Integer id; ... } @Entity @Table(name = "students") public class Student { @Id @Column(unique = true, nullable = false) private Integer studentId; @OneToMany(fetch = FetchType.EAGER, cascade = CascadeType.ALL) private List<Course> courses = new ArrayList<>(); ... } Please note that the courses field in Student is eagerly fetched. Starting from these entities we’ve generated some entries in the database: sudentRepo.save(createStudentWithCourses(1, 1, 2)); sudentRepo.save(createStudentWithCourses(2, 3, 4)); Later, we want to retrieve these entities and we have two options: Option #1 - Everything works as expected we have students with courses. @Test public void test_whenUsingList_WorksAsExpected_WithAnyHibernate5_3_11_plus() throws HibernateException { //obtain session factory SessionFactory sessionFactory = factory.unwrap(SessionFactory.class); //open session Session session = sessionFactory.openSession(); //Obtain students via list() List<Student> studentList = session .createQuery("from org.example.Student") .list(); //close session session.close(); //expecting to have at least 1 student at index 0 Student student = studentList.get(0); //expecting to have a course with id 1 Assert.assertEquals(1, student.getCourses().get(0).getId().intValue()); } Option #2 - Doesn’t work as expected starting with version 5.3.11.Final. We have students… but no courses linked to them. @Test public void test_whenUsingScroll_FailsWithLazyInitializationException_StartingWithHibernate5_3_11() throws HibernateException { //obtain session factory SessionFactory sessionFactory = factory.unwrap(SessionFactory.class); //open session Session session = sessionFactory.openSession(); //Obtain students via ScrollableResults ScrollableResults scroll = session .createQuery("from org.example.Student") .scroll(ScrollMode.FORWARD_ONLY); ScrollableResultsIterator<Student> iterator = new ScrollableResultsIterator(scroll); Spliterator spliterator = Spliterators.spliteratorUnknownSize(iterator, 256); Stream<Student> stream = StreamSupport.stream(spliterator, false); List<Student> studentList = stream.collect(Collectors.toList()); //close session session.close(); //expecting to have at least 1 student at index 0 Student student = studentList.get(0); //expecting to have a course with id 1 Assert.assertEquals(1, student.getCourses().get(0).getId().intValue()); //But what happens is that the following exception is thrown //org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: org.example.Student.courses, could not initialize proxy - no Session } When we need to use the second option, due to performance reasons, we are not able to obtain entities with their EAGER fields fetched and we think this behaviour should be corrected. Note: (We hope we will not influence your judgment related to this task…) Debugging inside hibernate code, we’ve found that once with the changes related to https://hibernate.atlassian.net/browse/HHH-11147 the following line was added in org.hibernate.internal. ScrollableResultsImpl # prepareCurrentRow : private void prepareCurrentRow(boolean underlyingScrollSuccessful) { ... persistenceContext.beforeLoad(); ... } which further resulted in having a StatefulPersistenceContext # loadCounter equal with 1, and when StatefulPersistenceContext # initializeNonLazyCollections is invoked nothing is executed due to the first check if ( loadCounter == 0 ) {... Attached a set of two tests (in AppTest) highlighting the problem. ( https://hibernate.atlassian.net/browse/HHH-16405#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16405#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16350) PreLoadEvent listeners always receive PreLoadEvent with null state

by Jones (JIRA)

Jones ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16350 ( https://hibernate.atlassian.net/browse/HHH-16350?atlOrigin=eyJpIjoiNDU2Mj... ) Re: PreLoadEvent listeners always receive PreLoadEvent with null state ( https://hibernate.atlassian.net/browse/HHH-16350?atlOrigin=eyJpIjoiNDU2Mj... ) Thanks for solving this issue. But in my case I do need to keep an initial snapshot state of a loaded entity in a general way without performance or memory impact and PreLoadEvent was the simplest way for doing that. Probably I’ll switch back to PreLoadEvent once this fix is released. I would be good to have similar thing in PostLoadEvent but I’m not sure how feasible that would be. ( https://hibernate.atlassian.net/browse/HHH-16350#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16350#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16350) PreLoadEvent listeners always receive PreLoadEvent with null state

by Marco Belladelli (JIRA)

Marco Belladelli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=637b480... ) *commented* on HHH-16350 ( https://hibernate.atlassian.net/browse/HHH-16350?atlOrigin=eyJpIjoiZjNhY2... ) Re: PreLoadEvent listeners always receive PreLoadEvent with null state ( https://hibernate.atlassian.net/browse/HHH-16350?atlOrigin=eyJpIjoiZjNhY2... ) Jones ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) , after my change you should be able to access the state object in the pre-load event with no performance impact. Adding something like state in the PostLoadEvent interface is not that useful IMO, since the getEntity() method will return an initialized entity instance which already contains all its property values. I don’t know why you need the state as an object array, but I would suggest accessing the data directly from the entity instance (i.e. using getters), rather than calling persister.getValues() which is expensive. I'd suggest also taking a look at JPA lifecycle callback ( https://jakarta.ee/specifications/persistence/3.1/jakarta-persistence-spe... ) methods once again. ( https://hibernate.atlassian.net/browse/HHH-16350#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16350#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16350) PreLoadEvent listeners always receive PreLoadEvent with null state

by Christian Beikov (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HSEARCH-4831) Fix Hibernate Search tests against latest ORM 6.2/6.3

by Automation for Jira (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HHH-16402) Fix default window frame mode to be RANGE instead of ROWS

by Christian Beikov (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HSEARCH-4831) Fix Hibernate Search tests against latest ORM 6.2/6.3

by Yoann Rodière (JIRA)

1 year, 1 month

1
0
0 / 0

[JIRA] (HSEARCH-4831) Fix Hibernate Search tests against latest ORM 6.2/6.3

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiNGY0YTFm... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4831?atlOrigin=eyJpIjoiNGY... ) HSEARCH-4831 ( https://hibernate.atlassian.net/browse/HSEARCH-4831?atlOrigin=eyJpIjoiNGY... ) Fix Hibernate Search tests against latest ORM 6.2/6.3 ( https://hibernate.atlassian.net/browse/HSEARCH-4831?atlOrigin=eyJpIjoiNGY... ) Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: build, tests Created: 30/Mar/2023 05:36 AM Fix Versions: 6.1.9.Final, 6.2.0.Beta1 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Zulip: > > > > Yoann Rodiere: FWIW some change that occurred at most ~17 hours ago led to > failures in the Hibernate Search testsuite against ORM 6.2.0-SNAPSHOT. I'm > going to investigate; hopefully it's just something that I need to fix in > Search itself. > > > > Yoann Rodiere: Ha. It's actually an assertion that changed ORM's behavior > when running tests (so with assertions enabled): https://github.com/hibernate/hibernate-orm/blob/53b3ea6b3b8b5c65e0e076a5f... > > My test in Search was asserting that if a getter throws an > exception/error, Search will report it a certain way. Since ORM now calls > that getter before Search does, ORM wraps that exception/error and the > reported exception/error is different... > So... no big deal. I'll try to adapt my test to make sure the > exception/error is thrown only when Hibernate Search calls that getter, > not when ORM does. > > > > Yoann Rodiere: (related: https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/t... > ) > > ( https://hibernate.atlassian.net/browse/HSEARCH-4831#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4831#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )

1 year, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues March 2023