May 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16537) Wrong SQL generated when root join is not used in sub-query

by Jones (JIRA)

Jones ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiM2RjZWYwOGVm... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16537?atlOrigin=eyJpIjoiM2RjZW... ) HHH-16537 ( https://hibernate.atlassian.net/browse/HHH-16537?atlOrigin=eyJpIjoiM2RjZW... ) Wrong SQL generated when root join is not used in sub-query ( https://hibernate.atlassian.net/browse/HHH-16537?atlOrigin=eyJpIjoiM2RjZW... ) Issue Type: Bug Affects Versions: 6.2.2 Assignee: Unassigned Components: query-hql Created: 02/May/2023 02:57 AM Priority: Major Reporter: Jones ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given * Join with alias in root query * sub-query using same join path but not using the defined alias When * executing HQL Then * Wrong SQL is generated @Entity @Table(name = "REFERENCED_ENTITY" ) public class ReferencedEntity { @Id @GeneratedValue(strategy = GenerationType.AUTO) @Column(name = "ID" ) Integer id; @Column(name = "foo" ) Integer foo; } @Entity @Table(name = "ENTITY_A" ) public class EntityA { @Id @GeneratedValue(strategy = GenerationType.AUTO) @Column(name = "ID" ) Integer id; @JoinColumn(name = "ENTITY_B" ) @ManyToOne EntityB entityB; } @Entity @Table(name = "ENTITY_B" ) public class EntityB { @Id @GeneratedValue(strategy = GenerationType.AUTO) @Column(name = "ID" ) Integer id; @Column(name = "REF_NUMBER" ) Integer reference; } @Test public void hhhXXXXTest() throws Exception { try (Session s = openSession()) { Transaction tx = s.beginTransaction(); ReferencedEntity ref1 = new ReferencedEntity(); ref1.foo = 1; ReferencedEntity ref2 = new ReferencedEntity(); ref2.foo = 2; s.persist(ref1); s.persist(ref2); EntityA entityA1 = new EntityA(); EntityB entityB1 = new EntityB(); entityA1.entityB = entityB1; entityB1.reference = ref1.id; s.persist(entityB1); s.persist(entityA1); EntityA entityA2 = new EntityA(); EntityB entityB2 = new EntityB(); entityA2.entityB = entityB2; entityB2.reference = ref2.id; s.persist(entityB2); s.persist(entityA2); tx.commit(); } try (Session s = openSession()) { Query<EntityA> query = s.createQuery( "select a from EntityA a join a.entityB ab " // + " where 0 < (select count(*) from ReferencedEntity r where r.foo = 1 and r.id = a.entityB.reference)" , EntityA.class); List<EntityA> actual = query.getResultList(); assertThat(actual).hasSize(1); } } The generated SQL is wrong since e3_0 has no reference to root query and the test fails: select e1_0.ID, e1_0.ENTITY_B from ENTITY_A e1_0 join ENTITY_B e2_0 on e2_0.ID=e1_0.ENTITY_B where 0<( select count (*) from REFERENCED_ENTITY r1_0, ENTITY_B e3_0 where r1_0.foo=1 and r1_0.ID=e3_0.REF_NUMBER ) Changing the HQL to use the join alias from root query works fine: try (Session s = openSession()) { Query<EntityA> query = s.createQuery( "select a from EntityA a join a.entityB ab " // + " where 0 < (select count(*) from ReferencedEntity r where r.foo = 1 and r.id = ab.reference)" , EntityA.class); List<EntityA> actual = query.getResultList(); assertThat(actual).hasSize(1); } I decided to report this case since the original HQL works fine on latest hibernate 5.6 series Test case to be attached ( https://hibernate.atlassian.net/browse/HHH-16537#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16537#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HHH-16533) Sybase cast, literal and truncation doesn't work with jConnect driver

by Christian Beikov (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-16526) Query toHqlString() loses function arguments

by Christian Beikov (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-16536) annotation to specify the name of an Oracle array type or Postgres enum type

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMmM5ZWY2ZWQz... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16536?atlOrigin=eyJpIjoiMmM5ZW... ) HHH-16536 ( https://hibernate.atlassian.net/browse/HHH-16536?atlOrigin=eyJpIjoiMmM5ZW... ) annotation to specify the name of an Oracle array type or Postgres enum type ( https://hibernate.atlassian.net/browse/HHH-16536?atlOrigin=eyJpIjoiMmM5ZW... ) Issue Type: Improvement Assignee: Unassigned Components: hibernate-core Created: 02/May/2023 01:32 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) It would be nice to be able to customize the name of the UDT we generate for an Oracle varray type or Postgres enum type. This is a lot like the @Struct annotation, except these UDTs aren’t “structs”. ( https://hibernate.atlassian.net/browse/HHH-16536#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16536#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HHH-16535) annotation for SQL array length

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTgyNWRiZmVm... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16535?atlOrigin=eyJpIjoiNTgyNW... ) HHH-16535 ( https://hibernate.atlassian.net/browse/HHH-16535?atlOrigin=eyJpIjoiNTgyNW... ) annotation for SQL array length ( https://hibernate.atlassian.net/browse/HHH-16535?atlOrigin=eyJpIjoiNTgyNW... ) Issue Type: Improvement Assignee: Unassigned Components: hibernate-core Created: 02/May/2023 01:25 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) SQL array types accept a maximum length, and Oracle varray types require them. Currently we have no annotation which allows the length of an array type to be specified. We can’t use @Column(length=...) because that’s interpreted as the length of the element type. ( https://hibernate.atlassian.net/browse/HHH-16535#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16535#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HSEARCH-4847) Move getting started guides to separate documents

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiOGIyZGU5... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4847?atlOrigin=eyJpIjoiOGI... ) HSEARCH-4847 ( https://hibernate.atlassian.net/browse/HSEARCH-4847?atlOrigin=eyJpIjoiOGI... ) Move getting started guides to separate documents ( https://hibernate.atlassian.net/browse/HSEARCH-4847?atlOrigin=eyJpIjoiOGI... ) Issue Type: Task Assignee: Unassigned Components: documentation Created: 01/May/2023 23:59 PM Fix Versions: 6.2-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Because that’s apparently a best-practice to separate tutorials from reference documentation, to avoid overwhelming readers with a massive reference when they’re only after a short introduction. Todo: * Split the documentation * Move the asciidoc for “ Getting started with the Hibernate ORM integration” and “Getting started with the Standalone POJO Mapper” to separate directories/files in the source (we need two separate guides). * Adapt pom.xml to actually generate those documents * Adapt the distribution module to copy those documents (if it doesn’t already work; it may be copying all generated documentation already) * Keep a (very short) “Getting started” section in the reference documentation, which will basically be the first two paragraphs we currently have ( https://docs.jboss.org/hibernate/search/6.2/reference/en-US/html_single/#... ) , adapted to just point to the two getting started guides. * Make sure all the anchors we had in there will point to that “Getting started” section. * Convert links from the reference to the getting started guides (and vice-versa) to cross-references using xref ( https://docs.asciidoctor.org/asciidoc/latest/macros/inter-document-xref/ ). * Check the result * Check that the new documents (both HTML and PDF) are correctly included in the distribution ZIP. * Check that links from the reference to the getting started guides (and vice-versa) work correctly: * In the distrubiton ZIP (at least the HTML version; the PDF probably won’t work). * After being deployed to docs.jboss.org ( http://docs.jboss.org ) (not sure how we can check that; we don’t want to erase existing documentation during our tests…) * Remind Yoann to adapt the website to point to those docs when we next release Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH-4847#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4847#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HV-1946) PathImpl.createCopy() only performs a shallow copy

by Jay Gorrell (JIRA)

Jay Gorrell ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=622a122... ) *created* an issue Hibernate Validator ( https://hibernate.atlassian.net/browse/HV?atlOrigin=eyJpIjoiM2U0OTVmZTM3N... ) / Bug ( https://hibernate.atlassian.net/browse/HV-1946?atlOrigin=eyJpIjoiM2U0OTVm... ) HV-1946 ( https://hibernate.atlassian.net/browse/HV-1946?atlOrigin=eyJpIjoiM2U0OTVm... ) PathImpl.createCopy() only performs a shallow copy ( https://hibernate.atlassian.net/browse/HV-1946?atlOrigin=eyJpIjoiM2U0OTVm... ) Issue Type: Bug Affects Versions: 6.0.23.Final Assignee: Unassigned Attachments: JTextArrayValueExtractor.java, PathProblemTest.java Components: engine Created: 01/May/2023 17:55 PM Environment: JDK zulu8.68.0.21-ca-jdk8.0.362-win_x64 Hibernate validator versions: hibernate-validator-6.0.23.Final.jar, hibernate-validator-6.2.5.Final.jar Priority: Major Reporter: Jay Gorrell ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=622a122... ) hen calling Validator.validateValue() with a class containing an array field with a single Pattern validation on the entire array which creates violations, the index in the path of the validations is only correct for the last item in the array. The index for the violations on other elements is always set to the index of the last element. I spent some time debugging this and found the PathImpl.createCopy(), which calls the copy constructor PathImpl(PathImpl path), is only doing a shallow copy of the values. The validation for each element in the array is using the same instance of the nodeList property in PathImpl instead of a different one for each validation. This happens because the copy constructor does not create a new list, but uses the existing one. The code that changes the currentLeafNode values is then update that list which ends up in each violation path. I believe the fix to be on line 351 of PathImpl in the 6.0.23.Final code would be to replace that line with this one.: nodeList = new ArrayList<path.nodeList>() // Need null check for path.nodeList? ( https://hibernate.atlassian.net/browse/HV-1946#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1946#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HHH-16526) Query toHqlString() loses function arguments

by Alessio Stalla (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-16125) array types on Oracle / enumerated types on Postgres

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16125 ( https://hibernate.atlassian.net/browse/HHH-16125?atlOrigin=eyJpIjoiNWM5YW... ) Re: array types on Oracle / enumerated types on Postgres ( https://hibernate.atlassian.net/browse/HHH-16125?atlOrigin=eyJpIjoiNWM5YW... ) This is now mostly done (though there’s still some details to finish off). This was actually way harder than anticipated, and the PRs were rather big, but the good news is I cleaned up a bunch of cruft so that other new things should be much easier to do in the future. ( https://hibernate.atlassian.net/browse/HHH-16125#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16125#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:07bd2b7 )

1 year

1
0
0 / 0

[JIRA] (HHH-16125) array types on Oracle / enumerated types on Postgres

by Gavin King (JIRA)

1 year

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues May 2023