[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HHH-5352) Misleading replacement of commas with cross joins

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5352?page=c... ] Patras Vlad edited comment on HHH-5352 at 1/18/11 7:22 AM: ----------------------------------------------------------- When HHH-1480 was implemented it is obvious that {{org.hibernate.test.hql.HQLTest}} would have failed. So the developer added {{public static boolean REGRESSION_STYLE_CROSS_JOINS = false;}} to {{org.hibernate.hql.ast.SqlGenerator}}. This is set to {{true}} in {{prepareTest}} and to {{false}} in {{cleanupTest}}. If you want {{HQLTest}} to fail just set {{REGRESSION_STYLE_CROSS_JOINS}} to {{false}} again, it's only purpose is to make {{HQLTest}} pass. Even the test case considers "cross join" and comma to be equivalent by ignoring the change (it tells the query generator to use commas again just for testing purposes). There is no test that actually checks if the generated sql returns the same thing after the change. For this purpose I modified {{org.hibernate.test.orphan.OrphanTest}} (it has suitable entities). The important bit is: {code} SqlGenerator.REGRESSION_STYLE_CROSS_JOINS = true; session = openSession(); t = session.beginTransaction(); //when REGRESSION_STYLE_CROSS_JOINS is true, commas in hql are translated to commas is SQl and this will work as expected. //the condition "where 1=1" is added so the queries are different, otherwise the next one will be taken from cache. log.info("Running with comma"); assertEquals(2, session.createQuery("from Product, Mail m right join m.user where 1=1").list().size()); t.commit(); session.close(); SqlGenerator.REGRESSION_STYLE_CROSS_JOINS = false; session = openSession(); t = session.beginTransaction(); //when REGRESSION_STYLE_CROSS_JOINS is true, commas in hql are translated a dialect specific string, usually "cross join" //this fails on H2 with "unsupported outer join condition" - it seems H2 doesn't even support this //on MySQL and MS Sql the assert will fail because the query only returns one result log.info("Running with cross join"); assertEquals(2, session.createQuery("from Product, Mail m right join m.user where 2=2").list().size()); t.commit(); session.close(); {code} It is obvious from the test that when creating sql the old way ({{REGRESSION_STYLE_CROSS_JOINS}} is {{true}}) everything works as expected. But when replacing commas with "cross join" ({{REGRESSION_STYLE_CROSS_JOINS}} is {{false}}), the query dosn't return the expected results and even crashes on HyperDB 2. Note that a patch with the changes is attached. was (Author: senoctar): When HHH-1480 was implemented it is obvious that {{org.hibernate.test.hql.HQLTest}} would have failed. So the developer added {{public static boolean REGRESSION_STYLE_CROSS_JOINS = false;}} to {{org.hibernate.hql.ast.SqlGenerator}}. This is set to {{true}} in {{prepareTest}} and to {{false}} in {{cleanupTest}}. If you want {{HQLTest}} to fail just set {{REGRESSION_STYLE_CROSS_JOINS}} to {{false}} again, it's only purpose is to make {{HQLTest}} pass. Even the test case considers "cross join" and comma to be equivalent by ignoring the change (it tells the query generator to use commas again just for testing purposes). There is no test that actually checks if the generated sql returns the same thing after the change. For this purpose I modified {{org.hibernate.test.orphan.OrphanTest}} (it has suitable entities). The important bit is: {code} SqlGenerator.REGRESSION_STYLE_CROSS_JOINS = true; session = openSession(); t = session.beginTransaction(); log.info("Running with comma"); //when REGRESSION_STYLE_CROSS_JOINS is true, commas in hql are translated to commas is SQl and this will work as expected. //the condition "where 1=1" is added so the queries are different, otherwise the next one will be taken from cache. assertEquals(2, session.createQuery("from Product, Mail m right join m.user where 1=1").list().size()); t.commit(); session.close(); SqlGenerator.REGRESSION_STYLE_CROSS_JOINS = false; session = openSession(); t = session.beginTransaction(); //when REGRESSION_STYLE_CROSS_JOINS is true, commas in hql are translated a dialect specific string, usually "cross join" //this fails on H2 with "unsupported outer join condition" - it seems H2 doesn't even support this //on MySQL and MS Sql the assert will fail because the query only returns one result log.info("Running with cross join"); assertEquals(2, session.createQuery("from Product, Mail m right join m.user where 2=2").list().size()); t.commit(); session.close(); {code} It is obvious from the test that when creating sql the old way ({{REGRESSION_STYLE_CROSS_JOINS}} is {{true}}) everything works as expected. But when replacing commas with "cross join" ({{REGRESSION_STYLE_CROSS_JOINS}} is {{false}}), the query dosn't return the expected results and even crashes on HyperDB 2. Note that a patch with the changes is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira