[hibernate-issues] [JIRA] (HSEARCH-4719) Factorize all code related to POJO tree processing

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMGYxYzcw... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) HSEARCH-4719 ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) Factorize all code related to POJO tree processing ( https://hibernate.atlassian.net/browse/HSEARCH-4719?atlOrigin=eyJpIjoiMGY... ) Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: mapper-pojo-base Created: 12/Oct/2022 07:49 AM Fix Versions: 7.x-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) There is a lot (and I mean a LOT) of duplicated code between all three tree processing facilities: * PojoIndexingProcessorNode * PojoImplicitReindexingResolverNode * PojoImplicitReindexingAssociationInverseSideResolverNode Those are all basically about going through a tree of objects and applying operations to some of them. We’ve already started standardizing that processing with org.hibernate.search.mapper.pojo.extractor.impl.ContainerExtractorHolder#wrap / ValueProcessor (used in PojoIndexingProcessorContainerElementNode and PojoImplicitReindexingResolverContainerElementNode in particular). Maybe we could go one step further and provide generic implementations of value processors that extract a property or apply a typecast? Then we’d use that for all three tree processing facilities, the only specific parts being operations applied to nodes to mark them for reindexin/etc. ( https://hibernate.atlassian.net/browse/HSEARCH-4719#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4719#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100208- sha1:399748d )