[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2783) The Element Wrapper Java module has a number of methods, mainly the add method is incorrect.

The Element Wrapper Java module has a number of methods, mainly the add method is incorrect. -------------------------------------------------------------------------------------------- Key: HHH-2783 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2783 Project: Hibernate3 Issue Type: Bug Affects Versions: 3.2.4 Environment: 3.2 Oracle Reporter: Jay Schrock The WrapperElement class has an instance attribute called "element". This class also has a number of methods of which their signature has a parameter also called element. In a number of these methods the name conflicts with the instance attribute and incorrect behavior. In particular the add method has a parameter called element. In the implementation of the add method, there is a call element.add( element). This is incorrect and produces bad XML results and also causes recursive elements in the XML... What should happen is that the key "this" should be used to indicate that the instance attributes "element" should be used. I believe the implementation should be this.element.add( element). Also one needs to look at a number of other methods that also may have this problem.... thanks, Jay Schrock