[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3439) Change o.h.cfg.Mappings to not require constructor
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3439?page=c...
]
Max Rydahl Andersen commented on HHH-3439:
------------------------------------------
I looked at my usage of Mappings and in tools I do not extend the class. I just use it in
custom secondpass for reverse engineering to access and manipulate via the public api on
it..
For code generation I "just" uses whatever Configuration is passed to me and
don't do any magic.
p.s. It took me a while to realize we were talking about Mappings and not Mapping (which i
do have custom implementation of in reverse engineering ,)
Change o.h.cfg.Mappings to not require constructor
--------------------------------------------------
Key: HHH-3439
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3439
Project: Hibernate3
Issue Type: Improvement
Components: metamodel
Reporter: Steve Ebersole
Assignee: Steve Ebersole
Fix For: 3.4
Mappings requiring passing all the mapping queues into its constructor causes
interoperability issues with other components (annotations e.g.) because they generally
extend Mappings to add extra information. Therefore we introduce an incompatibility
whenever we add a new mapping attribute because we are currently forced to change the
signature of the Mappings constructor.
A better approach is to make Mappings an interface with an impl that defined as an inner
class to o.h.cfg.Configuration so that it can expose access to the queues directly from
there. Annotations, etc can than simply extend that Mappings impl.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira