[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HHH-5363) DetachedCriteria getCriteriaImpl() method should be protected instead of default

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5363?page=c... ] Tobias Seelinger edited comment on HHH-5363 at 7/8/10 11:20 AM: ---------------------------------------------------------------- An Unit Test checking the desired state: {code} import java.lang.reflect.Method; import java.lang.reflect.Modifier; import org.hibernate.criterion.DetachedCriteria; import junit.framework.TestCase; public class HHH5363Test extends TestCase { public void test_getCriteriaImplIsProtected() throws SecurityException, NoSuchMethodException { Method method = DetachedCriteria.class.getDeclaredMethod("getCriteriaImpl", null); int modifiers = method.getModifiers(); assertTrue("DetachedCriteria.getCriteriaImpl() is not protected or public.", Modifier.isProtected(modifiers) || Modifier.isPublic(modifiers)); } } {code} was (Author: takashi): An Unit Test checking the desired state: import java.lang.reflect.Method; import java.lang.reflect.Modifier; import org.hibernate.criterion.DetachedCriteria; import junit.framework.TestCase; public class HHH5363Test extends TestCase { public void test_getCriteriaImplIsProtected() throws SecurityException, NoSuchMethodException { Method method = DetachedCriteria.class.getDeclaredMethod("getCriteriaImpl", null); int modifiers = method.getModifiers(); assertTrue("DetachedCriteria.getCriteriaImpl() is not protected or public.", Modifier.isProtected(modifiers) || Modifier.isPublic(modifiers)); } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira