[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933?page=c...
]
Steve Ebersole commented on HHH-2933:
-------------------------------------
to answer your specific questions:
1) You asked about the current methods on DialectFactory. I don't not consider
DialectFactory as part of the public API. I'll leave the methods as deprecated for
3.2 and 3.3, but remove them on trunk (3.4)
2) I could have been convinced to use passing in DatabaseMetaData instead of Connection.
But it sounds like you convinced yourself to use Connection...
3) Yes, I prefer that DialectResolver return the Dialect instance. The reason being a
longer term goal of possibly allowing Dialects to be non-static and therefore allowing
Dialect Resolver to "configure" the Dialect it returns based on the Connection.
externalize automatic resolution of Dialect (Tomoto Shimizu Washio)
-------------------------------------------------------------------
Key: HHH-2933
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933
Project: Hibernate Core
Issue Type: Patch
Components: core
Affects Versions: 3.2.5
Reporter: Mikael Kopteff
Assignee: Steve Ebersole
Fix For: 3.2.x, 3.3.x, 3.4
Attachments: dialect_registration.zip, dialect_registration_rev2.zip
Introducing DialectResolver!
Much better approach to resolving JDBC Connection information to Dialect allowing users
to define custom behavior
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira