[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-1030) Mixed eol chars in generated pojos
[
http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c...
]
Simon Toens commented on HBX-1030:
----------------------------------
Yes, that would be even "more" correct. Well, I am on Windows right now, and
the pojo uses "\n", except for the import statements. So actually the imports
use the correct eol char and the rest of the pojo is wrong :). I am guessing the
"\n"s come from the freemarker templates? At least the templates also use
"\n".
Still, seems easiest to always just use "\n". Most windows editors seem fine
with that these days. Except Notepad. Do you guys want to support Notepad? :)
Mixed eol chars in generated pojos
----------------------------------
Key: HBX-1030
URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030
Project: Hibernate Tools
Issue Type: Bug
Components: hbm2java
Affects Versions: 3.2.0.GA
Environment: java
Reporter: Simon Toens
Priority: Minor
Attachments: eol.patch
org.hibernate.tool.hbm2x.pojo.ImportContextImpl hardcodes "\r\n" as eol
characters for import statements. This is kind of lame, and a problem when using svn with
svn:eol-style=native:
$ svn add revengtest/
...
A revengtest/src//test/Actor.hbm.xml
svn: File 'revengtest/src/test/Actor.java' has inconsistent new lines
svn: Inconsistent line ending style
Since the rest of the generated pojo uses "\n", why not just use that?
Attached is the trivial patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira