[hibernate-issues] [Hibernate-JIRA] Commented: (EJB-361) Query#setParameter(int position, Object value) wrong implementation

[ http://opensource.atlassian.com/projects/hibernate/browse/EJB-361?page=co... ] John Sublette commented on EJB-361: ----------------------------------- I just ran into what looks like this problem also. I tracked it down to the QueryImpl.isPositionalParameter() function. It looks to me like the comments don't match the code. According to the code, the following queryStrings should return: "SELECT Foo FROM Foo WHERE Foo.param1 = :value" TRUE (index == -1, Should have been false, right?) "SELECT Foo FROM Foo WHERE Foo.param1 = ?" FALSE (found index is last char, Should have been true, right?) "SELECT Foo FROM Foo WHERE Foo.param1 = ?1" TRUE (found index is followed by a digit) I noticed this problem when I tried using a query similar to the first (by name) but was trying to set the parameters by index (similar to Fabrice Daugan). It looks like it would work correctly if the return values were swapped for the first two cases. private boolean isPositionalParameter() { 256 if (isPositional == null) { 257 //compute it 258 String queryString = query.getQueryString(); 259 int index = queryString.indexOf( '?' ); 260 //there is a ? and the following char is a digit 261 if (index == -1) { 262 //no ? 263 isPositional = true; 264 } 265 else if ( index == queryString.length() - 1 ) { 266 // "... ?" 267 isPositional = false; 268 } 269 else { 270 isPositional = Character.isDigit( queryString.charAt( index + 1 ) ); 271 } 272 } 273 return isPositional; 274 } 275 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira