[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz updated HHH-7113: --------------------------------- Attachment: EnhancedTestCaseModifieableNaturalId.jar Please ignore the previous attachement, just consider this -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz edited comment on HHH-7113 at 2/27/12 1:56 AM: --------------------------------------------------------------- Hi, the workaround above fails to work on NaturalId's in class-hierarchies. The problem is following: -the NaturalId-cache of the perstistent context is split up in caches per entity-persister, good so far. -when inserting or deleting an entity object the entity-persister of the concrete object class is considered -when loading an entity object by NaturalId the entity-persister of the declared object class is considered The concrete and the declared class may be different classes in class-hierarchies: // class C extends CC , CC declares NaturalId name C c = (C) session.byNaturalId(C.class).using("name", "test").load(); assertTrue (c instanceof CC); Please consider the attached testcase EnhancedTestCaseModifieableNaturalId.jar and ignore the previous attachement was (Author: pb00067): Hi, the workaround above fails to work on NaturalId's in class-hierarchies. The problem is following: -the NaturalId-cache of the perstistent context is split up in caches per entity-persister, good so far. -when inserting or deleting an entity object the entity-persister of the concrete(!) object class is considered -when loading an entity object by NaturalId the entity-persister of the declared(!) object class is considered The concrete and the declared class may be different classes in class-hierarchies: // class C extends CC , CC declares NaturalId name C c = (C) session.byNaturalId(C.class).using("name", "test").load(); assertTrue (c instanceof CC); Please consider the attached testcase EnhancedTestCaseModifieableNaturalId -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz edited comment on HHH-7113 at 2/27/12 3:49 AM: --------------------------------------------------------------- Hi, the workaround above fails to work on NaturalId's in class-hierarchies. The problem is following: -the NaturalId-cache of the persistent context is split up in caches per entity-persister, good so far. -when inserting or deleting an entity object, the entity-persister of the object's concrete class is considered. -when loading an entity object by NaturalId , the entity-persister of the declaring class is considered. Concrete and declaring classes can be different in class-hierarchies, as the declaring class may be a super class of the concrete class: // class CC extends C Class declaring= C.class; // declares NaturalId name C c = (C) session.byNaturalId(C.class).using("name", "test").load(); assertTrue (c instanceof CC); Please consider the attached testcase EnhancedTestCaseModifieableNaturalId.jar and ignore the previous attachement was (Author: pb00067): Hi, the workaround above fails to work on NaturalId's in class-hierarchies. The problem is following: -the NaturalId-cache of the perstistent context is split up in caches per entity-persister, good so far. -when inserting or deleting an entity object, the entity-persister of the concrete object class is considered. -when loading an entity object by NaturalId , the entity-persister of the declared object class is considered. Concrete and declared classes can be different in class-hierarchies, as the declared class may be a super class of the concrete class: // class C extends CC , CC declares NaturalId name Class declaredClass = C.class; C c = (C) session.byNaturalId(C.class).using("name", "test").load(); assertTrue (c instanceof CC); Please consider the attached testcase EnhancedTestCaseModifieableNaturalId.jar and ignore the previous attachement -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz edited comment on HHH-7113 at 2/27/12 9:48 AM: --------------------------------------------------------------- In my opinion the naturalIdResolutionCacheMap must always be filled using the persister of the declaring class (= the highest class in hierarchy which satisfies the given naturalIdValues), see following example: class A @NaturalId key1 class AA extends A @NaturalId key2 class AAA extends AA --------------------------- assertTrue (session.bySimpleNaturalId(A.class).load(key1) instanceof AAA); // this is possible, //persister of A should be considered for caching: naturalIdResolutionCacheMap.put( persisterA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); // also this is possible, //persister of AA should be considered for caching: naturalIdResolutionCacheMap.put( persisterAA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AAA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); //this should produce a in-memory-hit in the NaturalId cache of persisterAA Thus, similiar to StatefulPersistenceContext#validateNaturalId(EntityPersister persister, Object[] naturalIdValues) we will need a method which returns the correct persister for caching, something like following: private EntityPersister findProperEntityPersisterForNaturalIdValues(EntityPersister persister, Object[] naturalIdValues) { EntityPersister ret = persister; while (persister.hasPersisterForSuperClass()) { try { validateNaturalId(ret.getPersisterForSuperClass(),naturalIdValues); ret = ret.getPersisterForSuperClass(); } catch (IllegalArgumentException i) { break; } } return ret; } -------------------------------------------------------------------------------------------------- Then modify the puts into naturalIdResolutionCacheMap as follows: naturalIdResolutionCacheMap.put(findProperEntityPersisterForNaturalIdValues(persister,naturalIdValues), entityNaturalIdResolutionCache ); was (Author: pb00067): In my opinion the naturalIdResolutionCacheMap must always be filled using the persister of the declaring class, see following example: Class A NaturalId key1 Class AA extends A NaturalId key2 Class AAA extends AA --------------------------- assertTrue (session.bySimpleNaturalId(A.class).load(key1) instanceof AAA); // this is possible, //persister of A should be considered for caching: naturalIdResolutionCacheMap.put( persisterA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AA.class).using("key1", "1").using("key2", "9").load() instanceof AAA); // also this is possible, //persister of AA should be considered for caching: naturalIdResolutionCacheMap.put( persisterAA, entityNaturalIdResolutionCache ); Thus, similiar to StatefulPersistenceContext#validateNaturalId(EntityPersister persister, Object[] naturalIdValues) we will need a method which returns the correct persister for caching, something like following: private EntityPersister findProperEntityPersisterForNaturalIdValues(EntityPersister persister, Object[] naturalIdValues) { EntityPersister ret = persister; while (persister.hasPersisterForSuperClass()) { try { validateNaturalId(ret.getPersisterForSuperClass(),naturalIdValues); ret = ret.getPersisterForSuperClass(); } catch (IllegalArgumentException i) { break; } } return ret; } -------------------------------------------------------------------------------------------------- Then modify the puts into naturalIdResolutionCacheMap as follows: naturalIdResolutionCacheMap.put(findProperEntityPersisterForNaturalIdValues(persister,naturalIdValues), entityNaturalIdResolutionCache ); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Guenther Demetz edited comment on HHH-7113 at 2/28/12 9:28 AM: --------------------------------------------------------------- In my opinion the naturalIdResolutionCacheMap must always be filled using the persister of the declaring class (= the highest class in hierarchy which satisfies the given naturalIdValues), see following example: class A @NaturalId key1 class AA extends A @NaturalId key2 class AAA extends AA --------------------------- assertTrue (session.bySimpleNaturalId(A.class).load(key1) instanceof AAA); // this is possible, //persister of class A should be cache-key: naturalIdResolutionCacheMap.put( persisterA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); // also this is possible, //persister of class AA should be cache-key: naturalIdResolutionCacheMap.put( persisterAA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AAA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); //this should produce a in-memory-hit in the NaturalId-cache of persisterAA Thus, similiar to StatefulPersistenceContext#validateNaturalId(EntityPersister persister, Object[] naturalIdValues) we will need a method which returns the correct persister for NaturalId-caching, something like following: private EntityPersister findProperEntityPersisterForNaturalIdValues(EntityPersister persister, Object[] naturalIdValues) { EntityPersister ret = persister; while (persister.hasSuperClassPersister()) { try { validateNaturalId(ret.getSuperClassPersister(),naturalIdValues); ret = ret.getPersisterForSuperClass(); } catch (IllegalArgumentException i) { break; } } return ret; } --- Then modify the puts into naturalIdResolutionCacheMap as follows: naturalIdResolutionCacheMap.put(findProperEntityPersisterForNaturalIdValues(persister,naturalIdValues), entityNaturalIdResolutionCache ); --------------------------------------------- Next thing to consider are updates and deletions. In the example above the instance AAA finally is cached 2 times in NaturalIdCache: once with key1 in the cache of persisterA and another time with key1+key2 in the cache of persisterAA. Thus when deleting instance AAA or updating key1 in the AAA instance, both cache entries have to be synchronized. was (Author: pb00067): In my opinion the naturalIdResolutionCacheMap must always be filled using the persister of the declaring class (= the highest class in hierarchy which satisfies the given naturalIdValues), see following example: class A @NaturalId key1 class AA extends A @NaturalId key2 class AAA extends AA --------------------------- assertTrue (session.bySimpleNaturalId(A.class).load(key1) instanceof AAA); // this is possible, //persister of class A should be cache-key: naturalIdResolutionCacheMap.put( persisterA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); // also this is possible, //persister of class AA should be cache-key: naturalIdResolutionCacheMap.put( persisterAA, entityNaturalIdResolutionCache ); assertTrue (session.byNaturalId(AAA.class).using("key1", key1).using("key2", key2).load() instanceof AAA); //this should produce a in-memory-hit in the NaturalId-cache of persisterAA Thus, similiar to StatefulPersistenceContext#validateNaturalId(EntityPersister persister, Object[] naturalIdValues) we will need a method which returns the correct persister for NaturalId-caching, something like following: private EntityPersister findProperEntityPersisterForNaturalIdValues(EntityPersister persister, Object[] naturalIdValues) { EntityPersister ret = persister; while (persister.hasSuperClassPersister()) { try { validateNaturalId(ret.getSuperClassPersister(),naturalIdValues); ret = ret.getPersisterForSuperClass(); } catch (IllegalArgumentException i) { break; } } return ret; } -------------------------------------------------------------------------------------------------- Then modify the puts into naturalIdResolutionCacheMap as follows: naturalIdResolutionCacheMap.put(findProperEntityPersisterForNaturalIdValues(persister,naturalIdValues), entityNaturalIdResolutionCache ); Next thing to consider are updated and deletions. In the example above the instance AAA finally is cached 2 times in NaturalIdCache: once with key1 in the cache of persisterA and another time with key1+key2 in the cache of persisterAA. Thus when deleting instance AAA or updating key1 in the AAA instance, both cache entries have to be synchronized. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-7113?page=com.atlassian.jira.plug... ] Steve Ebersole closed HHH-7113. ------------------------------- Resolution: Rejected See HHH-7129 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira