[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-466?page=all ] Mark Hobson updated ANN-466: ---------------------------- Attachment: patch.txt Checking the HSQLDB documention, it appears that by default it ignores column length violations. The attached patch sets the sql.enforce_strict_size property to true, which now causes the above test to fail under HSQLDB. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-466?page=co... ] Mark Hobson commented on ANN-466: --------------------------------- Interesting way to fix a problem by removing the test :) Seriously though, this is a bit of a problem for entities whose unqualified classnames are longer than 31 characters. What was the reasoning behind ANN-321 and ANN-223 which substantially increased the probability of violating the discriminator column length? I assume this was the outcome of an EJB spec-related discussion, in which case does the spec describe what should happen in such circumstances? Obvious solutions that I can see to this problem are: 1) Increase the default discriminator column length to >31, e.g. 255. This is really no hardship to most databases. 2) Truncate the entity name to the default discriminator column length to avoid SQL errors at insert time. Entities that would share the same truncated names could be checked for at configuration time and a suitable exception thrown. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-466?page=co... ] Max Rydahl Andersen commented on ANN-466: ----------------------------------------- i guess we have another candidate for hbmlint then .... why was the limit set to 31 anyway ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-466?page=co... ] Mark Hobson commented on ANN-466: --------------------------------- I can see the reasons for deterministic configuration and spec-compliance. How can this issue not get lost in JIRA but be raised for future consideration in the spec? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-466?page=co... ] Mark Hobson commented on ANN-466: --------------------------------- Thanks, sent feedback. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira