[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c... ] Simon Toens commented on HBX-1030: ---------------------------------- Yes, that would be even "more" correct. Well, I am on Windows right now, and the pojo uses "\n", except for the import statements. So actually the imports use the correct eol char and the rest of the pojo is wrong :). I am guessing the "\n"s come from the freemarker templates? At least the templates also use "\n". Still, seems easiest to always just use "\n". Most windows editors seem fine with that these days. Except Notepad. Do you guys want to support Notepad? :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c... ] Dmitry Geraskov commented on HBX-1030: -------------------------------------- Is the problem that exporters do not use the same line separator? In this case sysEOL patch do not resolve problem. And we need to update all our exporters to use system line separator. The eol patch can be short-time solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c... ] Max Rydahl Andersen updated HBX-1030: ------------------------------------- Issue Type: Patch (was: Bug) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c... ] Dmitry Geraskov commented on HBX-1030: -------------------------------------- BTW, IMHO the best solution do not use line delimiters at all! Look at the example: ------ String contents = "java.lang.String str;System.out.println();System.out.println();"; //generate code without line delimiters CodeFormatter codeFormatter = ToolFactory.createCodeFormatter(null); IDocument doc = new Document(contents); TextEdit edit = codeFormatter.format(CodeFormatter.K_UNKNOWN, doc.get(), 0, doc.get().length(), 0, null); edit.apply(doc); String newcontents = doc.get(); ------- Using the code we get fine formatted code with system line delimiter. I cheked - code formatter replaces all line delimiters to only one (system delimiter), even if you used your own in "contents" string. I see only 2 probably disadvantages: - File contents is not wrote to the file immediately and saved in the memory - I do not now productive time of code formatting for big files (I hope time is acceptable) And there are many advantages, for ex.: - fix problem with line delimiter - fine formatted code - may be it use user preferences(I am not shure) - better approach Just an idea, hope to listen you thoughts about it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1030?page=c... ] Simon Toens commented on HBX-1030: ---------------------------------- Dmitry, you may be right that my "patch" doesn't fix all instances of this problem. It is working fine for me, but I definitely may have missed something. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira