[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Sebastian Bolz updated HHH-3824: -------------------------------- Attachment: hibernate-3.5.0-beta-3-core.patch hibernate-3.5.0-beta-3-annotations.patch Hi, I have tried to work on a fix on my own and have found a possible solution for the 3.5.0-beta branch. You find attached the two patches for the affected modules (core and annotations). The fix was tested for JPA annotation mappings and JPA XML mappings. The Hibernate XML mappings does not seem to need a fix, since there we would have to map a one-to-one as a many-to-one with unique=true and that already works fine. Please let me know, if I can do anything more to speed the process of verification and committing of the fix. Cheers, Sebastian -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] santosh padhi commented on HHH-3824: ------------------------------------ I tried to join two entities using OneToOne on non promary key column, it did not give me any error but when I saw the code generated it used the primary key to join. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Sharath Reddy commented on HHH-3824: ------------------------------------ This seems to work for me, testing against branch 3.5. I created classes similar to those provided by Satish, the reporter of this issue: @Entity class Item { @Id @GeneratedValue Long id; @Column String sku; @OneToOne(optional=true) @JoinColumn(name = "sku", referencedColumnName = "sku", insertable=false, updatable=false) Inventory inventory; } @Entity public class Inventory implements Serializable { @Id @GeneratedValue Long id; @Column String sku; @Column Long quantity; } Note that, as mentioned in the Hibernate docs, this class implements Serializable. This is a requirement when there is a join to a non-primary key column. Test case: public void testOneToOneJoinByNonprimaryKeyColumn() { Session s = openSession(new JoinCounter(1)); Transaction tx = s.beginTransaction(); Item item = new Item(); item.sku = "SKU"; Inventory inventory = new Inventory(); inventory.quantity = 1000L; inventory.sku = "SKU"; s.persist(inventory ); s.persist(item); s.flush(); s.clear(); item = ( Item ) s.get( Item.class, item.id ); assertNotNull( item ); assertNotNull( item.inventory ); assertEquals( "SKU", item.inventory.sku ); s.flush(); s.clear(); tx.rollback(); s.close(); } Generated SQL: select item0_.id as id0_1_, item0_.sku as sku0_1_, inventory1_.id as id1_0_, inventory1_.quantity as quantity1_0_, inventory1_.sku as sku1_0_ from Item item0_ left outer join Inventory inventory1_ on item0_.sku=inventory1_.sku where item0_.id=? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Gail Badner commented on HHH-3824: ---------------------------------- Sharath, can this be resolved as "Cannot Reproduce"? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Sharath Reddy reassigned HHH-3824: ---------------------------------- Assignee: Sharath Reddy -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Vladimir V commented on HHH-3824: --------------------------------- hibernate distribution 3.6.0.Final Issue still here. Ignores "referencedColumnName" and always try`s to fetch using primary key; @Entity @DiscriminatorValue("3") //@Table InformingLinks public class InformingLink_z extends InformingLink {} @Entity public class Informing { @OneToOne(cascade = CascadeType.ALL,fetch = FetchType.EAGER) @JoinColumn(name="n",referencedColumnName = "n1") InformingLink_z informingLink; } createQuery("from Informing o left outer join fetch o.informingLink") generates "select * from Informing i left outer join InformingLinks il on i.n=il.n" must be "=il.n1 and DiscriminatorValue=3" same error for createQuery("from Informing") -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3824?page=c... ] Trevor Baker updated HHH-3824: ------------------------------ Attachment: HHH-3824.zip Hi, I've attached a test case to highlight this issue. Just run: mvn test Really the issue should be renamed to @OneToOne( mappedBy ) ignores mappedBy's @JoinColumn( referenceColumnName ) You'll see: Hibernate: select parent2x0_.id as id10_1_, parent2x0_.uniqueId as uniqueId10_1_, child2x1_.id as id11_0_, child2x1_.parentIdFK as parentIdFK11_0_ from Parent2 parent2x0_ left outer join Child2 child2x1_ on *parent2x0_.id=child2x1_.parentIdFK* where parent2x0_.uniqueId=? This is because in org.hibernate.type.OneToOneType the lhs is always the PK. thanks, Trev -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira