Yoann Rodière (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) *created* an issue
Hibernate Search (
https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMjlkMWY1...
) / Task (
https://hibernate.atlassian.net/browse/HSEARCH-4674?atlOrigin=eyJpIjoiMjl...
) HSEARCH-4674 (
https://hibernate.atlassian.net/browse/HSEARCH-4674?atlOrigin=eyJpIjoiMjl...
) Move to Testcontainers to start Elasticsearch/OpenSearch/databases/etc. (
https://hibernate.atlassian.net/browse/HSEARCH-4674?atlOrigin=eyJpIjoiMjl...
)
Issue Type: Task Assignee: Unassigned Components: build, integration, tests Created:
17/Aug/2022 05:23 AM Fix Versions: 6.3-backlog Priority: Major Reporter: Yoann Rodière (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
)
We would probably be able to integrate a TestContainers rule into our various
SetupHelpers, making sure that the appropriate containers (database, Elasticsearch, …) are
started before tests start.
org.hibernate.search.util.impl.integrationtest.common.rule.BackendConfiguration#testRule
would be particularly relevant when it comes to Elasticsearch.
This would also have the advantage of speeding up the build, as there’s a way to have
TestContainers start each container only once for the whole build (using Ryuk).
See also this comment (
https://hibernate.atlassian.net/browse/HSEARCH-4643?focusedCommentId=109767 ) :
testcontainers could help with dependency upgrades (though no certainty here).
There might be a few blockers, mainly support for the databases we need in TestContainers;
I know that TestContainers' Elasticsearch support wasn’t compatible with OpenSearch
(it rejected any image that’s not the official Elasticsearch one) last time I checked.
(
https://hibernate.atlassian.net/browse/HSEARCH-4674#add-comment?atlOrigin...
) Add Comment (
https://hibernate.atlassian.net/browse/HSEARCH-4674#add-comment?atlOrigin...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:f005d5a )