Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZDFmMjU2... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-3882?atlOrigin=eyJpIjoiZDF... ) HSEARCH-3882 ( https://hibernate.atlassian.net/browse/HSEARCH-3882?atlOrigin=eyJpIjoiZDF... ) Add tests for explicit nested predicates containing all predicates ( https://hibernate.atlassian.net/browse/HSEARCH-3882?atlOrigin=eyJpIjoiZDF... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Currently we only test with the match predicate as inner predicate. See NestedSearchPredicateIT. Ideally we would test all predicates, including in particular the ID predicate, which I'm not totally sure would work. In order to do that, we will probably need some abstraction over the inner predicate, similar to what we did with {{ AggregationDescriptor }} in {{ SingleFieldAggregationBaseIT }} . That abstraction could also help facting boost tests (HSEARCH-3506) and other tests we duplicated everywhere, such as tests around field incompatibility in multi-index searches ( {{ org.hibernate.search.integrationtest.backend.tck.search.predicate.MatchSearchPredicateIT#multiFields_withDslConverter_dslConverterEnabled }} , ...). ( https://hibernate.atlassian.net/browse/HSEARCH-3882#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3882#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:c7667cc )