[Hibernate-JIRA] Created: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
5:10 a.m.
Multi-Level cascading of unsaved instances with bidirectional associations fails with
TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:45 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner commented on HHH-5299:
----------------------------------
Is this still an issue using 3.5.3?
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Carl-Eric Menzel commented on HHH-5299:
---------------------------------------
Yes, I get the same exception when trying with hibernate-core and hibernate-entitymanager
both on 3.5.3.
Side Note: Where can I see what hibernate versions are included in a particular version of
JBossAS? I'm guessing we'd need a new version of AS to upgrade to a new Hibernate
version. I'm not at work today, so I don't know the exact version, but we're
using some version of JBossAS5 right now.
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Carl-Eric Menzel commented on HHH-5299:
---------------------------------------
Is there an estimate on when this can be fixed? Or is there some problem with the patch I
supplied?
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:04 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner updated HHH-5299:
-----------------------------
Affects Version/s: 3.5.4
3.6.0.Beta1
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:02 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Anders Wallgren commented on HHH-5299:
--------------------------------------
I just ran into this -- thanks for the patch!
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:16 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Robin Palotai commented on HHH-5299:
------------------------------------
Is this still an issue with 3.6.2? I run into a situation where a "Bottom"-like
entity doesn't get managed, but only if I run a Jpa+Hibernate transaction before
attempting the pure Hibernate transaction. (But maybe in this case, using Hibernate as the
Jpa provider misconfigures something causing error for pure Hibernate use).
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:08 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner commented on HHH-5299:
----------------------------------
I'm seeing the test pass when tweaked to be core-only and it fails using entity
manager.
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:28 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner resolved HHH-5299.
------------------------------
Resolution: Duplicate
Assignee: Gail Badner
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Carl-Eric Menzel commented on HHH-5299:
---------------------------------------
I haven't had time to test it yet, but the patch in HHH-1870 doesn't seem to me to
be a good way to address this.
Also, this issue is not *fixed* by HHH-1870 either, since that is still unresolved and
points to Hibernate 4, so that looks more like a "won't fix" to me.
I'm going to check this with core-only instead of entity manager, though I can't
really see how that would affect this particular bug.
In any case, I'd appreciate it if someone could have a look at this patch I provided
last year and hopefully apply it to a 3.x release.
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 p.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner reopened HHH-5299:
------------------------------
I agree HHH-1870 is not a fix for this. I must have mis-typed.
Looking at this again...
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:25 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner updated HHH-5299:
-----------------------------
Component/s: (was: core)
entity-manager
Fix Version/s: 4.1.0
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner updated HHH-5299:
-----------------------------
Fix Version/s: 3.6.10
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException
--------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:45 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner resolved HHH-5299.
------------------------------
Resolution: Fixed
Fixed in master and 3.6 branch.
Thanks for the test and fix!
Gail
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:45 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299?page=c...
]
Gail Badner updated HHH-5299:
-----------------------------
Summary: Multi-Level cascading of unsaved instances with bidirectional associations
fails with TransientObjectException (Carl-Eric Menzel) (was: Multi-Level cascading of
unsaved instances with bidirectional associations fails with TransientObjectException)
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
https://hibernate.onjira.com/browse/HHH-5299?page=com.atlassian.jira.plug...
]
Strong Liu commented on HHH-5299:
---------------------------------
https://issues.jboss.org/browse/JBPAPP-8076
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: https://hibernate.onjira.com/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
https://hibernate.onjira.com/browse/HHH-5299?page=com.atlassian.jira.plug...
]
Gail Badner closed HHH-5299.
----------------------------
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: https://hibernate.onjira.com/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
https://hibernate.onjira.com/browse/HHH-5299?page=com.atlassian.jira.plug...
]
Zbyněk Roubalík commented on HHH-5299:
--------------------------------------
Test for this issue is failing on MS SQL Server 2008, because the test uses reserved
keyword 'TOP' as a name for a table.
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: https://hibernate.onjira.com/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5299) Multi-Level cascading of unsaved instances with bidirectional associations fails with TransientObjectException (Carl-Eric Menzel)
[
https://hibernate.onjira.com/browse/HHH-5299?page=com.atlassian.jira.plug...
]
Zbyněk Roubalík commented on HHH-5299:
--------------------------------------
Please ignore previous comment, this problem was already fixed.
Multi-Level cascading of unsaved instances with bidirectional
associations fails with TransientObjectException (Carl-Eric Menzel)
---------------------------------------------------------------------------------------------------------------------------------
Key: HHH-5299
URL: https://hibernate.onjira.com/browse/HHH-5299
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Affects Versions: 3.3.2, 3.5.4, 3.6.0.Beta1
Environment: Tested with OracleXE and H2DB, Hibernate Core 3.3.2, Hibernate
Entity Manager 3.4.0
Reporter: Carl-Eric Menzel
Assignee: Gail Badner
Priority: Critical
Fix For: 3.6.10, 4.1.0
Attachments: 0001-fixed-no-cascading-check-to-also-accept-entities-wit.patch,
cascadetest.zip
Given the following classes (pseudocode, full source in the attached zipfile):
Top {
@OneToMany(cascade = { CascadeType.ALL }, mappedBy = "top")
List<Middle> middles
}
Middle {
@ManyToOne
Top top
@OneToOne(cascade = { CascadeType.ALL })
@JoinColumn(name = "BOTTOM_ID")
Bottom bottom
}
Bottom {
@OneToOne(mappedBy = "bottom")
Middle middle
}
The following code fails on the second flush with a TransientObjectException:
Top top = new Top();
em.persist(top);
em.flush();
// top is now attached, status MANAGED
Middle middle = new Middle(1l);
middle.setBottom(new Bottom());
top.addMiddle(middle);
Middle middle2 = new Middle(2l);
middle2.setBottom(new Bottom());
top.addMiddle(middle2);
// both middles and bottoms are transient but should be saved by cascade
em.flush(); // boom!
The relevant part of the error is:
org.hibernate.TransientObjectException: object references an unsaved transient instance -
save the transient instance before flushing: test.Bottom.middle -> test.Middle
at org.hibernate.engine.CascadingAction$9.noCascade(CascadingAction.java:376)
at org.hibernate.engine.Cascade.cascade(Cascade.java:163)
The same code works without exception when using EclipseLink instead of Hibernate
EntityManager, so I am assuming that the test code is valid.
Some debugging revealed that CascadingAction.PERSIST_ON_FLUSH.noCascade() checks the
inverse association from Bottom to Middle. It then calls a private method isInManagedState
to verify that this association does not reference an unsaved instance. It does this by
checking the entities EntityEntry.getStatus() value, which it expects to be MANAGED or
READ_ONLY. At this time, however, the Middle instance is in the middle (no pun intended)
of its own cascading save cycle and therefore its status is SAVING. This, to me, seems to
be a valid session-attached status, so isInManagedState() should also accept this state.
The attached patch against Hibernate Core 3.3.2 implements just that, and this change
makes the above example code work as expected. The Hibernate test suite did not complain,
so I am reasonably sure I did not break anything else.
See also the attached cascadetest.zip for a ready-to-use testcase that demonstrates the
error with Hibernate Core 3.3.2. Change the dependency in the supplied pom.xml to a
patched version of Hibernate Core, and the test will no longer fail.
Carl-Eric Menzel
C1 SetCon GmbH
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4603
days inactive
5232
days old
hibernate-issues@lists.jboss.org
18 comments
6 participants
participants (6)
-
Anders Wallgren (JIRA) -
Carl-Eric Menzel (JIRA)
-
Gail Badner (JIRA)
-
Robin Palotai (JIRA)
-
Strong Liu (JIRA)
-
Zbyněk Roubalík (JIRA)