[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6271?page=c... ] Hardy Ferentschik reassigned HHH-6271: -------------------------------------- Assignee: Hardy Ferentschik -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6271?page=c... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- The error messages: {noformat} 08:55:17,762 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-2) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,614 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-3) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,707 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-7) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,855 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-1) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,614 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-6) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,614 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-8) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,614 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-5) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. 08:55:17,614 ERROR [org.hibernate.internal.util.xml.ErrorLogger] (MSC service thread 1-4) HHH00196:Error parsing XML (2) : cvc-complex-type.3.1: Value '1.0' of attribute 'version' of element 'entity-mappings' is not valid with respect to the corresponding attribute use. Attribute 'version' has a fixed value of '2.0'. {noformat} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6271?page=c... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- As Steve already pointed out, this issue is obsolete. The current code (Beta1) has support for orm.xml version 1 and 2. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6271?page=c... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- I also added some tests to _OrmXmlParserTests_ to make sure it works. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Strong Liu reopened HHH-6271: ----------------------------- https://issues.jboss.org/browse/JBPAPP-8398 this is not obsolete for hibernate 4.x, since we have moved new metamodel into 5. so, i'm reopening this issue, but feel free assign it to me if you don't have time, thanks -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- One approach could be to just not log an error: {code} public void error(SAXParseException error) { //LOG.parsingXmlError(error.getLineNumber(), error.getMessage()); // if error has not been set yet, keep the first error if ( this.error == null ) { this.error = error; } } {code} If there was an error we will later wrap the error anyways in a _MappingException_. I pushed this approach to https://github.com/hferentschik/hibernate-orm/tree/HHH-6271. Thoughts? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Strong Liu commented on HHH-6271: --------------------------------- what happens if it is an invalid orm2 xml? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- good catch. I XMLHelper.ErrorLogger and unified it with the standalone _ErrorLogger_. Like in the error logger in XMLHelper I keep now track of all errors, so that I can log them deferred. This should be a better approach. WDYT? (still same branch) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Hardy Ferentschik commented on HHH-6271: ---------------------------------------- I will create a pull request. Just want to try one more thing. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-6271?page=com.atlassian.jira.plug... ] Strong Liu resolved HHH-6271. ----------------------------- Resolution: Fixed Fix Version/s: 4.1.2 thanks guys -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira