6:32 a.m.
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.x
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:51 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Kevin Pollet updated HV-479:
----------------------------
Fix Version/s: (was: 4.x)
4.3.0.next
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:45 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Hardy Ferentschik commented on HV-479:
--------------------------------------
Maybe if we switched to
[ConcurrentWeakKeyHashMap|https://github.com/infinispan/infinispan/blob/ma...]
as used by Infinispan and Netty!?
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:47 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Kevin Pollet commented on HV-479:
---------------------------------
IMO, a concurrent map is better for a cache. I'm also wondering if it will work as
expected because the cached meta-data holds a reference to the key. Maybe using a
{{WeakReference}} will work but I'm not sure. I think we need further investigations.
In the WeakHashMap javadoc:
{quote}
The value objects in a WeakHashMap are held by ordinary strong references. Thus care
should be taken to ensure that value objects do not strongly refer to their own keys,
either directly or indirectly, since that will prevent the keys from being discarded
{quote}
BTW, is this the better strategy? Why not use an other strategy like LRU or LFU?
If we use another strategy do we allow the user to configure it (Configuration object
and/or property) or use it's own implementation?
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Hardy Ferentschik commented on HV-479:
--------------------------------------
Another option is
[SoftLimitMRUCache|https://github.com/hibernate/hibernate-search/blob/mast...]
which is used in Hibernate Core and Search. I don't think this class is thread-safe
yet, but it might be a good starting point.
Adding some more sophisticated caching allows us to give the user some control over the
size of the cache. That might be a good idea.
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Hardy Ferentschik edited comment on HV-479 at 12/12/11 9:17 AM:
----------------------------------------------------------------
See
[comment|https://hibernate.onjira.com/browse/HV-460?focusedCommentId=44157...]
on HV-460
was (Author: hardy.ferentschik):
See
[comment|https://hibernate.onjira.com/browse/HV-460?focusedCommentId=44157...]
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:56 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Hardy Ferentschik updated HV-479:
---------------------------------
Suitable for new contributors: [Yes, likely]
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
New subject: [Hibernate-JIRA] Assigned: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-479?page=com...
]
Hardy Ferentschik reassigned HV-479:
------------------------------------
Assignee: Hardy Ferentschik
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:57 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
https://hibernate.onjira.com/browse/HV-479?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-479:
--------------------------------------
Added _SoftLimitMRUCache_ to HV. At the moment I am not exposing strong and soft ref count
for configuration, but it could be done -
https://github.com/hferentschik/hibernate-validator/tree/HV-479
Thoughts?
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: https://hibernate.onjira.com/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.3.0.Alpha1
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:48 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
https://hibernate.onjira.com/browse/HV-479?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik updated HV-479:
---------------------------------
Fix Version/s: (was: 4.3.0.Alpha1)
4.3.0.next
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: https://hibernate.onjira.com/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.3.0.next
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:57 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
https://hibernate.onjira.com/browse/HV-479?page=com.atlassian.jira.plugin...
]
Gunnar Morling resolved HV-479.
-------------------------------
Resolution: Fixed
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: https://hibernate.onjira.com/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.3.0.Beta1
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-479) Implement an eviction strategy for BeanMetaDataCache
[
https://hibernate.onjira.com/browse/HV-479?page=com.atlassian.jira.plugin...
]
Hardy Ferentschik commented on HV-479:
--------------------------------------
It might be worth to look at _org.jboss.logmanager.ConcurrentReferenceHashMap_
Implement an eviction strategy for BeanMetaDataCache
----------------------------------------------------
Key: HV-479
URL: https://hibernate.onjira.com/browse/HV-479
Project: Hibernate Validator
Issue Type: Improvement
Components: engine
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.3.0.Beta1
In {{BeanMetaDataCache}} we have a map from {{Class}} to {{BeanMetaDataImpl}}. Currently
there is no eviction strategy for this cache meaning entries will never be removed once
they were added to the cache and the {{ValidatorFactoryImpl}} holding the cache exists.
In particular this means that the concerned class objects never can be garbage-collected.
This might cause problems in long-running applications (especially as there is typically
one long-living {{ValidatorFactory}} instance per application). Maybe {{WeakHashMap}} or
similar might be useful here.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4574
days inactive
4871
days old
hibernate-issues@lists.jboss.org
11 comments
3 participants
participants (3)
-
Gunnar Morling (JIRA) -
Hardy Ferentschik (JIRA)
-
Kevin Pollet (JIRA)