11:40 a.m.
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Attachments: one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID" generated="never"
insert="false" lazy="false" name="id" type="long"
update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Duncan Kinnear commented on HHH-3853:
-------------------------------------
We are having the same problem with annotations in 3.5.4.
We just upgraded to 3.5.4 from 3.3.2 (Core).
We have an entity class called PerOrg (short for Person/Organisation) which has
relationships to several optional 'role' entities. These relationships are
one-to-one based on the primary key (an assigned string 'id').
Each relationship is defined in the 'PerOrg' class similar to the following:
@OneToOne(fetch = FetchType.EAGER, optional = true)
@PrimaryKeyJoinColumn
@Updated
private Supplier supplier;
In the previous version of Hibernate, this was fine, but with the new version the schema
update fails because it tries to add a foreign key constraint between PerOrg and the
related roles. Of course this fails because no PerOrg has ALL the roles associated with
it.
We have reverted the version of Hibernate back for just now, but we'd like to know why
this is happening in the new version.
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Attachments: one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:08 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Gail Badner reassigned HHH-3853:
--------------------------------
Assignee: Adam Warski
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:25 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Fabio adriano Lisboa Gomes commented on HHH-3853:
-------------------------------------------------
Up to version 3.5.3 of Hibernate, OneToOne optional relationships based on primary key
functioned perfectly.
From version 3.5.4,3.5.5 and 3.5.6, hibernate tries to load all
associations, even if they do not exist, resulting in the error below
*org.hibernate.ObjectNotFoundException: No row with the given identifier exists*
Following model that illustrates the problem. A person can be a professor or student or
both.
public class Person
{
@OneToOne (cascade = CascadeType.ALL, optional = true)
@PrimaryKeyJoinColumn
@Nullable
public getProfessor Professor(){
return teacher;
}
@OneToOne (cascade = CascadeType.ALL, optional = true)
@PrimaryKeyJoinColumn
@Nullable
public Alumnus getStudent(){
return student;
}
}
A workaround is to assign empty objects when person has no role.
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Shawn Clowater commented on HHH-3853:
-------------------------------------
This is as good a place as any to throw my 2 cents in. This appears to have broken during
the fix of HHH-5109. Under that change the AnnotationBinder was changed from
final boolean mandatory = !ann.optional() || forcePersist;
to final boolean mandatory = !ann.optional() || forcePersist || trueOneToOne;
which essentially forces the association to mandatory regardless of whether or not it is
specified as optional or not.
I've managed to get it to work by changing the @PrimaryKeyColumn on the owning side to
a OneToOne(mappedBy) reference but I suspect that may have some other effect down the line
for me although it looks like using the mappedBy will do the same thing eventually in the
case of the OneToOne mapping except that it appears I'll take an extra hit on
SessionFactory configuration time.
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:41 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Pierrick HYMBERT updated HHH-3853:
----------------------------------
Attachment: hibernate-envers-pkjc.patch
Please find attached Test case and a (simple) patch proposal to support
@OneToOne+@PrimaryKeyJoinColumn
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: hibernate-envers-pkjc.patch, one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Gail Badner commented on HHH-3853:
----------------------------------
Shawn, you are spot on about when and how core was broken. I'm covering the core fix
in HHH-4982.
Pierrick, does your patch work without the change to core?
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: hibernate-envers-pkjc.patch, one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Pierrick HYMBERT commented on HHH-3853:
---------------------------------------
@Gail Of course ;-)
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate Core
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Adam Warski
Attachments: hibernate-envers-pkjc.patch, one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853?page=c...
]
Lukasz Antoniak resolved HHH-3853.
----------------------------------
Resolution: Fixed
Fix Version/s: 4.1.0
Assignee: Lukasz Antoniak (was: Adam Warski)
This issue has been solved together with HHH-6825 by applying pull request
https://github.com/hibernate/hibernate-orm/pull/246.
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3853
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Lukasz Antoniak
Fix For: 4.1.0
Attachments: hibernate-envers-pkjc.patch, one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:22 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-3853) one-to-one mapping doesn support Primary Key Association
[
https://hibernate.onjira.com/browse/HHH-3853?page=com.atlassian.jira.plug...
]
Steve Ebersole closed HHH-3853.
-------------------------------
Closing for 4.1 release
one-to-one mapping doesn support Primary Key Association
--------------------------------------------------------
Key: HHH-3853
URL: https://hibernate.onjira.com/browse/HHH-3853
Project: Hibernate ORM
Issue Type: Bug
Components: envers
Environment: Hibernate - core 3.4.0-SNAPSHOT, Hibernate - envers (trunk build
from today)
Reporter: Amar Singh
Assignee: Lukasz Antoniak
Fix For: 4.1.0
Attachments: hibernate-envers-pkjc.patch, one-to-one-pk.zip
one-to-one mapping with primary key association doesn't seem to be working. Eg.
Code:
<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD
3.0//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping
package="org.hibernate.envers.test.integration.onetoone.bidirectional"
default-lazy="false">
<class name="BidirectionalRefIngPK"
table="BIDIRECTIONAL_REFERENCING_ENTITY">
<id name="id" type="long"
column="BIDIRECTIONAL_REFERENCING_ID" >
<generator class="foreign">
<param name="property">reference</param>
</generator>
</id>
<property name="data"/>
<property column="BIDIRECTIONAL_REFERENCING_ID"
generated="never" insert="false" lazy="false"
name="id" type="long" update="false"/>
<one-to-one name="reference" cascade="save-update"
class="BidirectionalRefEdPK" constrained="true" />
</class>
<class name="BidirectionalRefEdPK"
table="BIDIRECTIONAL_REFERENCED_ENTITY">
<id name="longId" type="long"
column="BIDIRECTIONAL_REFERENCED_ID">
<generator class="native"/>
</id>
<property name="data"/>
<one-to-one name="referencing" cascade="all"
class="BidirectionalRefIngPK" />
</class>
</hibernate-mapping>
When we try to load a BidirectionalRefIngPK, the underlying query invokes
RelatedAuditExpression and since its not a foreign-key based one-to-one association the
loading fails in method addToQuery of RelatedAuditExpression at line 52
(relatedEntity==null) with the following exception:
Code:
"This criterion can only be used on a property that is a relation to another
property."
TO REPRODUCE
~~~~~~~~~~~~~
Please find a zip file attached which has four files:
- BidirectionalPrimaryAssociation.java (actual testng test case)
- BidirectionalRefEdPK.java (Entity 1)
- BidirectionalRefIngPK.java (Entity 2)
- mappings.hbm.xml
Please put the three java files in its package
(org.hibernate.envers.test.integration.onetoone.bidirectional) and the mapping file in
src/test/resources.
Now when you run envers tests you should see the failure.
Thanks for this great component !
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4615
days inactive
5652
days old
hibernate-issues@lists.jboss.org
9 comments
8 participants
participants (8)
-
Amar Singh (JIRA) -
Duncan Kinnear (JIRA)
-
Fabio adriano Lisboa Gomes (JIRA)
-
Gail Badner (JIRA)
-
Lukasz Antoniak (JIRA)
-
Pierrick HYMBERT (JIRA)
-
Shawn Clowater (JIRA)
-
Steve Ebersole (JIRA)