[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-791?page=all ] Max Rydahl Andersen closed HBX-791: ----------------------------------- Fix Version: 3.2beta9 Resolution: Fixed Thanks. Applied (with unittest) 2 questions: 1) How did you actually get hbm2doc to output generics code ? (I had to fix a bug in DocExporter that always set jdk5 to false) 2) I would really appreciate if you could add some basic tests for the features you are adding (I did it for this one in DocExporter) I will still accept your fixes with open arms without unittests, but it takes longer without a unittest since I then have to either test it manually or create a test for the features) But thanks again! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-791?page=co... ] Max Rydahl Andersen commented on HBX-791: ----------------------------------------- 1) woot ? why is maven using these *nonpublic* api's directly ? god damnit! 2) DocExporterTest is at least a good beginning ;) I still haven't been able to reproduce test failures you report ;( -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-791?page=co... ] Max Rydahl Andersen commented on HBX-791: ----------------------------------------- 1) The Exporter API is public, the subclasses are not what I would call public. The ant tasks are kept in sync with changes and they do not use DocExporter.setJdk5() which i were surprised to find in the class anyhow. And the maven plugin doesn't seem to have support for jdbcconfiguration, annotationconfiguration, ejb3configuration etc. which also annoys me that they are using some arbitrary combination without thought of why it is so in the ant tasks. 2) ok -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-791?page=co... ] Max Rydahl Andersen commented on HBX-791: ----------------------------------------- I can't be on that list - would overload my mail box ;) The maintainer should contact me directly or via hibernate-dev to know what he should and should not rely on. Feel free to tell them that. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira