5:20 a.m.
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint is
good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know how
to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Ken Egervari commented on HV-230:
---------------------------------
Okay, I implemented a proof of concept of how this works, however some of the code is
application specific. This suggests that come configuration would be required. Right now,
this is tied to spring specifically, but I'm sure this could be done without Spring as
well.
At the top of my domain class, I have this constraint:
@QueryConstraint( hql = "from UserAccount where emailAddress = :emailAddress and id
!= :id",
message = "{userAccount.email.unique}")
public class UserAccount extends DomainObject {
...
}
The annotation code looks like this - I practically xerox'd it from your
documentation:
@ValidatorClass( QueryConstraintValidator.class )
@Target( ElementType.TYPE )
@Retention( RetentionPolicy.RUNTIME )
@Documented
public @interface QueryConstraint {
String hql() default "";
String message() default "{validator.query}";
}
The QueryConstraintValidator looks like this below. Now, I commented it to death to
explain that this is just a proof of concept. The implementation in Hibernate Validator
would be much different, to generify how it works.
public class QueryConstraintValidator implements Validator<QueryConstraint>,
PropertyConstraint {
private String hql;
public void initialize( QueryConstraint parameters ) {
hql = parameters.hql();
}
public void apply( Property property ) {
}
public boolean isValid( Object value ) {
if( value == null ) return true;
if( !( value instanceof DomainObject ) ) return false;
// I doubt I really have to cast to my application specific domain class, since we are
just
// using reflection anyway. I am doing it in my case since I mistakenly put
@QueryConstraint
// on the email address, not thinking that only the email was being passed (stupid me)
DomainObject domainObject = ( DomainObject ) value;
// Again, if you were to use this in your library, you probably would not want to use
this
// Spring-specific BeanWrapper, but rather, you would use your own way of getting
values
// through reflection.
final BeanWrapper beanWrapper = new BeanWrapperImpl( domainObject );
// This is the easiest way for me to get a session factory from here. I have no idea
// how to get it in an easier way. If Hibernate validator could hook into Hibernate and
// auto-wire the session factory during configuration (as a spring bean, or something
// like that), then this would be much more trivial to do. Perhaps have a
SessionFactoryAware
// interface one the validator, or make a specific HibernateValidator class to extend
from.
SessionFactory sessionFactory =
( SessionFactory ) ApplicationContextProvider.getBean( "sessionFactory" );
// Opening a stateless session seemed like the best way to handle this type of
// feature... because it's not within spring transactions or in the environment.
Really,
// this is a low risk operation. It doesn't need to be a in transaction, does it? If
it does,
// then we need that functionality ot auto-magically work ;)
Query query = sessionFactory.openStatelessSession().createQuery( hql );
// The idea is to get the parameter names from inside the hql query, and then bind them
via
// the bean wrapper. If the parameter names are misspelled, it will bomb, but this is
just
// a proof of concept. I'm sure you guys have much more sophisticated hql parsers to
get this
// information reliably and to throw the correct exception. In this case,
getParameterNames()
// simply returns [ "emailAddress", "id" ] for my example.
for( String parameterName : HqlParser.getParameterNames( hql ) ) {
query.setParameter( parameterName, beanWrapper.getPropertyValue( parameterName ) );
}
// Basically if the query does not result a value, then it is good. If it returns 1 or
// more results, then it fails. Perhaps this can be customized using parameters in the
// annotation, but let's just keep this simple for now.
return query.list().size() == 0;
}
}
I dunno if you can make good use of this. I hope so. I hope you like this idea and can
somehow make it work, in Hibernate Validator, or in a sub-project that makes it work with
Hibernate. Thanks for listening.
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik updated HV-230:
---------------------------------
Fix Version/s: 4.1.0
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
Fix For: 4.1.0
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Ken Egervari commented on HV-230:
---------------------------------
Cool!
Here's an updated version I'm using for 4.0.0rc1:
{code}
public class QueryConstraintValidator implements
ConstraintValidator<QueryConstraint,DomainObject> {
/* Fields */
private static Logger logger =
LoggerFactory.getLogger( QueryConstraintValidator.class );
private String hql;
private boolean enabled;
/* Services */
public void initialize( QueryConstraint queryConstraint ) {
this.hql = queryConstraint.hql();
this.enabled = queryConstraint.enabled();
}
public boolean isValid( DomainObject domainObject ) {
return isValid( domainObject, null );
}
public boolean isValid( DomainObject domainObject, ConstraintValidatorContext context )
{
BeanWrapper beanWrapper = new BeanWrapperImpl( domainObject );
SessionFactory sessionFactory =
( SessionFactory ) ApplicationContextProvider.getBean( "sessionFactory" );
if( enabled && sessionFactory != null ) {
logger.debug( "Enabled - Validating constraint with: " );
logger.debug( hql );
Session session = sessionFactory.openSession();
Transaction tx = session.beginTransaction();
Query query = session.createQuery(
HqlParser.removePeriodsFromParameterNames( hql )
);
for( String parameterName : HqlParser.getParameterNames( hql ) ) {
query.setParameter(
HqlParser.removePeriodsFromParameterName( parameterName ),
beanWrapper.getPropertyValue( parameterName )
);
}
boolean result = (Long) query.uniqueResult() == 0;
logger.debug( "isValid is returning: " + result );
tx.commit();
session.close();
return result;
}
return true;
}
}
{code}
And here's the annotation:
{code}
@Constraint( validatedBy = QueryConstraintValidator.class )
@Target( ElementType.TYPE )
@Retention( RetentionPolicy.RUNTIME )
@Documented
public @interface QueryConstraint {
String hql() default "";
String message() default "{validator.query}";
boolean enabled() default true;
Class<?>[] groups() default {};
Class<? extends Payload>[] payload() default {};
}
{code}
Of course all of this is spring-aware, but I'm sure my suggestions about extending
base classes or implementing an interface and what not would replace that ;)
Thanks Hardy!
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
Fix For: 4.1.0
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:22 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik updated HV-230:
---------------------------------
Component/s: validators
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
Fix For: 4.1.0
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:57 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik updated HV-230:
---------------------------------
Attachment: HV-230.patch
Attaching a patch which shows how a {{@Unique}} constraint could be implemented using the
"open temporary session on top of current session's connection" approach.
Included in the patch is a {{SessionAwareConstraintValidatorFactory}}. We could add a
check into {{BeanValidationEventListener.validate}} to see which type the current factory
is and if it is the {{SessionAwareConstraintValidatorFactory}} inject the
{{SessionFactory}} automatically.
The reason I am not committing this patch yet is that introducing the {{@Unique}} creates
some problems. Most importantly there might be [phantom
reads|http://en.wikipedia.org/wiki/Isolation_%28database_systems%29#Repea...].
If we add {{@Unique}} as custom constraint we need to make sure that we add appropriate
warning notes to the documentation.
The alternative is to provide the sample code on the Validator
[wiki|http://community.jboss.org/en/hibernate/validator]
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Priority: Critical
Fix For: 4.1.0
Attachments: HV-230.patch
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:41 a.m.
New subject: [Hibernate-JIRA] Assigned: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik reassigned HV-230:
------------------------------------
Assignee: Hardy Ferentschik
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Assignee: Hardy Ferentschik
Priority: Critical
Fix For: 4.1.0
Attachments: HV-230.patch
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:55 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik resolved HV-230.
----------------------------------
Resolution: Fixed
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Assignee: Hardy Ferentschik
Priority: Critical
Fix For: 4.1.0
Attachments: HV-230.patch
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:55 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Hardy Ferentschik commented on HV-230:
--------------------------------------
Decided to go for the wiki option for now -
http://community.jboss.org/wiki/AccessingtheHibernateSessionwithinaConstr...
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 3.1.0.GA
Reporter: Ken Egervari
Assignee: Hardy Ferentschik
Priority: Critical
Fix For: 4.1.0
Attachments: HV-230.patch
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-230) Database Connective or @Unique
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-230?page=com...
]
Chris Wilson commented on HV-230:
---------------------------------
If you came to this page looking for an implementation of @Unique, you might like to check
out
http://blog.aptivate.org/2010/11/26/hibernate-ejb-and-the-unique-constraint/
and
http://community.jboss.org/wiki/AccessingtheHibernateSessionwithinaConstr...
Database Connective or @Unique
------------------------------
Key: HV-230
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-230
Project: Hibernate Validator
Issue Type: New Feature
Components: validators
Affects Versions: 4.0.0.Alpha1
Reporter: Ken Egervari
Assignee: Hardy Ferentschik
Priority: Critical
Fix For: 4.1.0.Beta2
Attachments: HV-230.patch
I find a common validation use case is checking to see if a field is unique to all those
in the table, such as emails, isbns, usernames, keywords, etc. these fields may not be the
primary key, but still need to be unique.
It would be fantastic if hibernate validator implemented this.
This is a common problem though because the domain class will need to have access the
database. I dunno if there's an easy way to wire in a copy of sessionFactory to make
this easy to write.
Perhaps something like this:
@Query( "select user from User user where user.emailAddress = :this.emailAddress and
user.id != :this.id", message = "That Email is already being used by another
user in the system" )
private String emailAddress;
Basically the idea is that if @Query returns no results, then the validation constraint
is good, and if returns more than 1 result, then it fails. Kind of like
simpleJdbcTemplate.queryForMap() does within the Spring testing framework. That method
causes the test to fail if no row is returned, because it expects 1 result.
If it were possible to just say
@Unique
private String emailAddress;
That would be extremely concise and would save people a ton of time.
Of course, this requires some interoperability with Hibernate... but I think that's a
good thing, no?
Thanks for taking this into consideration. I'd appreciate an email letting me know
how to do this in a clean way in 3.1.0 GA as it is as well if you would. Thank you.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4966
days inactive
5398
days old
hibernate-issues@lists.jboss.org
9 comments
3 participants
participants (3)
-
Chris Wilson (JIRA) -
Hardy Ferentschik (JIRA)
-
Ken Egervari (JIRA)