[Hibernate-JIRA] Created: (HSEARCH-397) Allow classes to be lazily added to the configuration

[Hibernate-JIRA] Created:...

Emmanuel Bernard (JIRA)

Tuesday, 8 September 2009 Tue, 8 Sep '09

7:13 a.m.

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Emmanuel Bernard (JIRA)

Tuesday, 8 September Tue, 8 Sep

7:13 a.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard updated HSEARCH-397: ------------------------------------- Fix Version/s: 3.3.0

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Sanne Grinovero (JIRA)

7:41 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Sanne Grinovero commented on HSEARCH-397: ----------------------------------------- yes, interesting. The configuration building was needing an update anyway: what do you think in making SearchFactoryImpl completely immutable, and replace the reference with a new one? To make it immutable we need a factory, and this factory could also have a method to create a new one basing on an existing one, just changing for example the indexed classes. (changing in the sense that the new one will have some differences with the previous, not changing the instance itself). After having built the new instance we could replace the existing in FullTextIndexEventListener, or wherever the reference should live. Introducing a factory for a SearchFactoryImpl is calling for some namechanges.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

8:06 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

8:13 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard commented on HSEARCH-397: ------------------------------------------ actually, the problem with your approach is that it requires to re reference the SF in whatever listener is using them. which can be pain. Maybe having a delegator SF that can do the switch would be preferable. BTW if we can remove classes from a SF, then sharing things like the indexing queue and the DProviders might be problematic. not sure

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Manik Surtani (JIRA)

8:17 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Manik Surtani commented on HSEARCH-397: --------------------------------------- Well the problem with swapping the SearchFactoryImpl is that you would need to stop all threads working on the old one while the ref is swapped. And this is an unnecessary synchronization point. What I was thinking of was more along the lines of making the internal configuration objects mutable and exposing a safe way to export these objects. E.g., if all configuration pertaining to a class type can be encapsulated in a single object, e.g., class ClassConfiguration { DocumentIndexBuilder db; DirectoryProvider dp; // etc } and we maintain a ConcurrentMap<Class, ClassConfiguration> which is looked up whenever you need to index anything. The ConcurrentMap could be constructed during SearchFactoryImpl construction, and any classes passed in to the SFI constructor can be used to initialize this map. Or this map would start empty if no classes are passed in. Lets call this map classConfigMap Then, on initForClass(Class c), the SFI would do: 0. if c not in classConfigMap: 1. Create ClassConfiguration. 2. init the DocumentIndexBuilder and add this to the ClassConfiguration 3. acquire a directoryInit lock // to ensure the same directory location isn't concurrently initialized 4. init DirectoryProvider and add to ClassConfiguration 5. Release directoryInit lock 6. classConfigMap.putIfAbsent(class, classConfig);

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

9:07 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard commented on HSEARCH-397: ------------------------------------------ "Well the problem with swapping the SearchFactoryImpl is that you would need to stop all threads working on the old one while the ref is swapped. And this is an unnecessary synchronization point. " Not necessarily if you reuse them.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Sanne Grinovero (JIRA)

Wednesday, 21 October Wed, 21 Oct

12:45 p.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Sanne Grinovero updated HSEARCH-397: ------------------------------------ Fix Version/s: (was: 3.3.0) 3.2.0 is needed for Infinispan's release, so I'm moving it to 3.2

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.2.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

1:09 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard commented on HSEARCH-397: ------------------------------------------ -1 this is not moving to 3.2 unless you are absolutely certain to carry it over by yourself. It's an important concurrency rework that we agreed to delay to post 3.2 last I talked to Manik

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.2.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

1:15 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard commented on HSEARCH-397: ------------------------------------------ and I would rather get us focus on the mass indexer and the query DSL over this feature which is providing a tiny little improvement over the Infinispan programmatic model.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.2.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Sanne Grinovero (JIRA)

1:17 p.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Sanne Grinovero updated HSEARCH-397: ------------------------------------ Fix Version/s: (was: 3.2.0) 3.3.0 Misunderstood the situation, sorry: reverting back to 3.3. I think I could do the change, it's the testing which is hard?

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

1:23 p.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard commented on HSEARCH-397: ------------------------------------------ it's more that we have to fight our battles. We already have: - mass indexer - the programmatic mapping aPI - the query DSL API And w eneed to finish them to release. We could even do a release with the first two, IMO. If we keep adding features wo releasing, it's pointless.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Manik Surtani (JIRA)

Thursday, 22 October Thu, 22 Oct

7:05 a.m.

New subject: [Hibernate-JIRA] Commented: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Manik Surtani commented on HSEARCH-397: --------------------------------------- I agree with Emmanuel; release early release often. This is only needed for the final query API in Infinispan which is targeted for Infinispan 4.1.0. For the current tech preview, the current workaround/restrictions are fine.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Assignee: Sanne Grinovero Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Sanne Grinovero (JIRA)

Friday, 21 May Fri, 21 May

11:40 a.m.

New subject: [Hibernate-JIRA] Assigned: (HSEARCH-397) Allow classes to be lazily added to the configuration

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Sanne Grinovero reassigned HSEARCH-397: --------------------------------------- Assignee: (was: Sanne Grinovero) I regret to unassign myself, but I think it's needed as I have no time for this in the next 4 weeks, while I think it would be important to be done as soon as possible.

...

Allow classes to be lazily added to the configuration ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

Wednesday, 30 June Wed, 30 Jun

8:11 a.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-397) Allow classes to be lazily added to the SearchFactory

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard updated HSEARCH-397: ------------------------------------- Summary: Allow classes to be lazily added to the SearchFactory (was: Allow classes to be lazily added to the configuration)

...

Allow classes to be lazily added to the SearchFactory ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Fix For: 3.3.0 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

Emmanuel Bernard (JIRA)

9:08 a.m.

New subject: [Hibernate-JIRA] Resolved: (HSEARCH-397) Allow classes to be lazily added to the SearchFactory

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard resolved HSEARCH-397. -------------------------------------- Resolution: Fixed Done SearchFactoryIntegrator.addClasses(A.class, B.class); SearchFactoryIntegrator is still experimental and primarily targeted at clients like Infinispan.

...

Emmanuel Bernard (JIRA)

Monday, 26 July Mon, 26 Jul

5:03 a.m.

New subject: [Hibernate-JIRA] Updated: (HSEARCH-397) Allow classes to be lazily added to the SearchFactory

[ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397?pag... ] Emmanuel Bernard updated HSEARCH-397: ------------------------------------- Fix Version/s: (was: 3.3.0) 3.3.0.Alpha1

...

Allow classes to be lazily added to the SearchFactory ----------------------------------------------------- Key: HSEARCH-397 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-397 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Fix For: 3.3.0.Alpha1 Assigning Sanne to pick his interest ;) Infinispan needs a way to add new classes lazily, ie after the SearchFactory initialization. Today's initialization cannot ensure that because we assume a single thread inits everything before freezing the state and then support multiple thread. We need to explore the idea of making the configuration mutable but not suffering too much of the thread-safety implications. We also should allow to remove a class from the configuration.

5187

days inactive

5508

days old

hibernate-issues@lists.jboss.org

Manage subscription

16 comments

3 participants

tags (0)

participants (3)

Emmanuel Bernard (JIRA)
Manik Surtani (JIRA)
Sanne Grinovero (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HSEARCH-397) Allow classes to be lazily added to the configuration