[
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-10?page=co...
]
Hardy Ferentschik commented on BVAL-10:
---------------------------------------
Great suggestions. When I was splitting out ValidatorParser I already had in my mind some
of these benefits, but was not sure how far we take things. I will do the renaming of the
class and start the other refactorings.
Turn ValidatorParser into a MetadataProvider
--------------------------------------------
Key: BVAL-10
URL:
http://opensource.atlassian.com/projects/hibernate/browse/BVAL-10
Project: Bean Validation
Issue Type: New Feature
Components: ri-general
Reporter: Emmanuel Bernard
Assignee: Hardy Ferentschik
You should turn parser into something more like a MetadataProvider.
I removed the getValidators() method from parser and moved it to ValidatorImpl. The
parser should not be aware of ValidatorImpl, nor Validator for that matter.
The MetadataProvider will be an interface anybody can implement. We will do the
annotation version as well as the XML version (and probably some kind of XML overriding
annotation version) but one can imagine a Script / Groovy DSLed version, a Programmatic
API version and so on.
I imagine a MetadataProvider instance can be passed during the building phase to the
ValidatorFactory. The same instance would then be shared for all Validators (kind of make
sense, you can't parse XML for every single ValdiatorImpl instantiation).
That woul mean the parser ode needs ot be reworked to be immutable (at least work in
concurrent calls)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira