4:01 a.m.
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:24 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Kevin Pollet updated HV-533:
----------------------------
Fix Version/s: 4.3.0.next
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
Fix For: 4.3.0.next
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:30 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Hardy Ferentschik resolved HV-533.
----------------------------------
Resolution: Won't Fix
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:30 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Hardy Ferentschik updated HV-533:
---------------------------------
Fix Version/s: (was: 4.3.0.next)
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:30 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Hardy Ferentschik commented on HV-533:
--------------------------------------
You are mixing annotation from two different domains. _@Column_ comes from the JPA
specification and _@Digits_ from the Bean Validation spec. In particular the latter does
not know anything about the former.
The javadocs for _@Digits_ is quite clear imo:
{quote}
/**
* @return maximum number of integral digits accepted for this number.
*/
int integer();
/**
* @return maximum number of fractional digits accepted for this number.
*/
int fraction();
{quote}
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:05 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Devesh Parekh commented on HV-533:
----------------------------------
The @Column annotation is mentioned in the JSR303 specification on the indicated page in
the bug description. The fact that the behavior of the @Digits annotation does not match
the behavior mentioned in the JSR303 specification is a bug. The annotation javadoc should
also be fixed.
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Hardy Ferentschik commented on HV-533:
--------------------------------------
To be clear, there is violation against the spec. The section you are referring to starts
with
{quote}
Ideas explored and not standardized
{quote}
Also, I don't think you can treat these two lines as mathematical equations you can
solve.
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:26 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Devesh Parekh commented on HV-533:
----------------------------------
Fair enough. How about this: it would be very useful to be able to specify a negative
number for fraction. For example, if you have a Money bean with a field for micros, it
would be useful to say that values representing fractions of a cent are not valid without
having to write a custom ConstraintValidator.
To allow this, the documentation should be cleared up to specify behavior for negative
values of @Digits.fraction (similar behavior to JPA's @Column.scale), and the
implementation should be fixed to deal with negative values. Alternatively, if we
don't want to allow negative values, the documentation should clearly state that. (I
dislike this alternative.)
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-533) @Digits.fraction should allow negative values
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-533?page=com...
]
Hardy Ferentschik commented on HV-533:
--------------------------------------
I still state that the spec is clear, in particular "maximum number of fractional
digits accepted for this number". This allows no negative numbers. We cannot change
this in Hibernate Validator. If you want to change the spec you need to create an issue in
[BVAL|https://hibernate.onjira.com/browse/BVAL] and argue with the Bean Validation expert
group.
@Digits.fraction should allow negative values
---------------------------------------------
Key: HV-533
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-533
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, validators
Affects Versions: 4.2.0.Final
Reporter: Devesh Parekh
There are really two bugs here:
1. The documentation for @Digits.fraction does not concretely say what should happen for
negative values, but the 1.0 final spec defines the correct behavior on page 133 with the
equation @Column.precision = @Digits.integer + @Digits.fraction. This suggests that
@Digits.fraction should be negative when @Column.scale is negative.
2. The implementation throws an IllegalArgumentException when @Digits.fraction is
negative.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4741
days inactive
4782
days old
hibernate-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Devesh Parekh (JIRA) -
Hardy Ferentschik (JIRA)
-
Kevin Pollet (JIRA)