[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Olivier Van Acker commented on HHH-3579: ---------------------------------------- These two classes add support, by extending UserType and IdentifierGenerator: package org.yourpackagename; public class UuidUserType implements UserType, Serializable { private UUID uuid; public UuidUserType() { super(); } public UuidUserType(UUID uuid) { this.uuid = uuid; } public void setUuid(UUID uuid) { this.uuid = uuid; } public UUID getUuid() { return uuid; } private static final String CAST_EXCEPTION_TEXT = " cannot be cast to a java.util.UUID."; /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#sqlTypes() */ public int[] sqlTypes() { return new int[]{Hibernate.BIG_DECIMAL.sqlType()}; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#returnedClass() */ public Class returnedClass() { return UuidUserType.class; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#equals(java.lang.Object, * java.lang.Object) */ public boolean equals(Object x, Object y) throws HibernateException { if (x == null && y == null) { return true; } else if (x == null || y == null) { return false; } if (!UuidUserType.class.isAssignableFrom(x.getClass())) { throw new HibernateException(x.getClass().toString() + CAST_EXCEPTION_TEXT); } else if (!UuidUserType.class.isAssignableFrom(y.getClass())) { throw new HibernateException(y.getClass().toString() + CAST_EXCEPTION_TEXT); } UUID a = ((UuidUserType) x).getUuid(); UUID b = ((UuidUserType) y).getUuid(); return a.equals(b); } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#hashCode(java.lang.Object) */ public int hashCode(Object x) throws HibernateException { if (!UuidUserType.class.isAssignableFrom(x.getClass())) { throw new HibernateException(x.getClass().toString() + CAST_EXCEPTION_TEXT); } UUID uuid = ((UuidUserType) x).getUuid(); return uuid.hashCode(); } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#nullSafeGet(java.sql.ResultSet, * java.lang.String[], java.lang.Object) */ public Object nullSafeGet(ResultSet resultSet, String[] names, Object owner) throws HibernateException, SQLException { Object value = resultSet.getObject(names[0]); if (value == null) { return null; } else { UuidUserType retValue = new UuidUserType(); PGobject pgObject = (PGobject) value; retValue.setUuid(UUID.fromString(pgObject.getValue())); return retValue; } } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#nullSafeSet(java.sql.PreparedStatement, * java.lang.Object, int) */ public void nullSafeSet(PreparedStatement preparedStatement, Object value, int index) throws HibernateException, SQLException { if (value == null) { preparedStatement.setNull(index, Types.NULL); return; } if (!UuidUserType.class.isAssignableFrom(value.getClass())) { throw new HibernateException(value.getClass().toString() + CAST_EXCEPTION_TEXT); } UUID uuidValue = ((UuidUserType) value).getUuid(); String uuidStringValue = uuidValue.toString(); preparedStatement.setObject(index, uuidValue, Types.OTHER); } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#deepCopy(java.lang.Object) */ public Object deepCopy(Object value) throws HibernateException { return (UuidUserType) value; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#isMutable() */ public boolean isMutable() { return false; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#disassemble(java.lang.Object) */ public Serializable disassemble(Object value) throws HibernateException { return (Serializable) value; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#assemble(java.io.Serializable, * java.lang.Object) */ public Object assemble(Serializable cached, Object owner) throws HibernateException { return cached; } /* * (non-Javadoc) * * @see org.hibernate.usertype.UserType#replace(java.lang.Object, * java.lang.Object, java.lang.Object) */ public Object replace(Object original, Object target, Object owner) throws HibernateException { return original; } /** * Returns the least significant 64 bits of this UUID's 128 bit value. * * @return */ @XmlElement public long getLeastSignificantBits() { return uuid.getLeastSignificantBits(); } /** * Returns the most significant 64 bits of this UUID's 128 bit value. * * @return */ public long getMostSignificantBits() { return uuid.getMostSignificantBits(); } public static UuidUserType fromString(String uuidString) { return new UuidUserType(UUID.fromString(uuidString)); } } [/sourcecode] Generator: package org.yourpackagename; public class UuidGenerator implements IdentifierGenerator { public Serializable generate(SessionImplementor session, Object object) throws HibernateException { return new UuidUserType(UUID.randomUUID()); } } And this is what the mapping file looks like: <hibernate-mapping default-cascade="none" default-access="property" default-lazy="false" auto-import="true"> <class name="org.yourpackagename.Example" table="example" select-before-update="true"> <id name="id" type="org.yourpackagename.UuidUserType"> <column name="Id" sql-type="uuid"/> <generator class="org.yourpackagename.UuidGenerator"/> </id> etc... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] David Driscoll updated HHH-3579: -------------------------------- Attachment: patch_HH_3579_PostgresSQLDialect.txt patch_HH_3579_NullableType.txt patch_HH_3579_Hibernate.txt I noticed that Hibernate did not have support for UUID as well. But, fortunately the guys over in NHibernate to implement UUID support for PostgreSQL. WIth the help of the NHibernate implementation , I have create a patches to support this in Hibernate. This is the first 3 of 5 patch files. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] David Driscoll commented on HHH-3579: ------------------------------------- Create a tutorial project for Unit Testing these patches in a web application environment using using Hibernate 3.5 (trunk), Spring Framework 3.0 (trunk), Spring's MVC, and Atomikos Transaction Manager 3.5.5, attached project to ticket HHH-4093. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole commented on HHH-3579: ------------------------------------- David, I am not sure I like the idea of binding Types.OTHER to "uuid". OTHER is a pretty broad catch all. Doesn't PostgreSQL provide a specific type code for their uuid datatype? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] David Driscoll commented on HHH-3579: ------------------------------------- Steve, I thinking switching the binding from Types.OTHER to Types.UUID makes sense. In Postgres the type name is uuid as well. I will test this change and let you know. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole commented on HHH-3579: ------------------------------------- mapping it to OTHER is an issue when doing schema export. The way your classes are right now, any Type reporting OTHER As it's SQL type will be created as UUID. Really OTHER is worthless in terms of export so in that sense it's arguable to go ahead and allow it. My preference though is that whenever we are talking about a specific database datatype we use the type code given that datatype by the database vendor. That being said, I think (1) the code constant should go on the dialect (this is all specific to postgresql after all) and (2) we will need 2 types (one specific to postgresql and mapping to it's uuid datatype, another generic one mapping to char) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole commented on HHH-3579: ------------------------------------- Well unfortunately I could not get much help on postgresql's irc channel. I did dig into the JDBC driver code as well as I could. AFAICT, the pertinent snippets appeared to be: {code:title=http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/jdbc/pgjdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java?rev=1.108&content-type=text/x-cvsweb-markup} protected Object internalGetObject(int columnIndex, Field field) throws SQLException { switch (getSQLType(columnIndex)) { ... default: String type = getPGType(columnIndex); ... if (type.equals("uuid")) return getUUID(getString(columnIndex)); ... } } /** * Newer JVMs will return a java.util.UUID object, but it isn't * available in older versions. */ protected Object getUUID(String data) throws SQLException { return data; } {code} and {code:title=http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/jdbc/pgjdbc/org/postgresql/jdbc3g/AbstractJdbc3gResultSet.java?rev=1.1&content-type=text/x-cvsweb-markup} protected Object getUUID(String data) throws SQLException { UUID uuid; try { uuid = UUID.fromString(data); } catch (java.lang.IllegalArgumentException iae) { throw new PSQLException(GT.tr("Invalid UUID data."), PSQLState.INVALID_PARAMETER_VALUE, iae); } return uuid; } {code} Bottom line, it does appear to map its UUID datatype to Types#OTHER. Ugh! Guess we will have to live with that. As an example of the potential clash in this approach, they also appear to do the same with a custom "refcursor" data type; so it is impossible for an app wanted to define types for both "uuid" and "recursor" and have schema export work. Also, "auto type discovery" in native sql query support would be messed up since only one or the other could be mapped. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole resolved HHH-3579. --------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] David Driscoll commented on HHH-3579: ------------------------------------- I successfully ran thru some tests with just 2 changes: set registerUnderJavaType to true, and needed to use a different setObject overload in method: getBinder(). I will attach a small patch file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole commented on HHH-3579: ------------------------------------- I just forgot the binding change. That I can accept. The other, not so much. The intention though is that *your* code can do this: {code} Configuration cfg = ...; cfg.registerTypeOverride( /* * Create a new PostgresUUIDType instance in order to register it as the default mapping for java.util.UUID. * * The other option is to manually specify to use this type for all UUID fields. */ new org.hibernate.type.PostgresUUIDType() { protected boolean registerUnderJavaType() { return true; } } ); {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3579?page=c... ] Steve Ebersole closed HHH-3579. ------------------------------- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira