[Hibernate-JIRA] Created: (HHH-3357) session.clear() takes too long

[Hibernate-JIRA] Created:...

Jay Erb (JIRA)

Wednesday, 25 June 2008 Wed, 25 Jun '08

3:50 p.m.

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate3 Issue Type: Improvement Components: core Affects Versions: 3.2.6, 3.2.5 Reporter: Jay Erb Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Gerald Glocker (JIRA)

Friday, 11 July Fri, 11 Jul

10:42 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Gerald Glocker commented on HHH-3357: ------------------------------------- Evict also takes very long when the session cache has many proxies. The reason is the same check whether the old session still uses the proxy. Generally it makes sense to perform this search in the old session because there is no guarantee that the proxy is also removed from the old session and not used any more. In the case of evict() and clear() the proxy is actually removed from the persistence context and we don't need the expensive check. For these reasons a better solution would rahter be to add in LazyInitializer a new method that sets the session to null without any other checks. The new method should be used only when we are sure that the proxies don't remain in the persistence context, thus by evict() and clear(). The proposed solution is implemented in the attached patch.

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate3 Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Gerald Glocker (JIRA)

10:44 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Gerald Glocker updated HHH-3357: -------------------------------- Attachment: LazyInitializerPatch.txt

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate3 Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Tim Downey (JIRA)

Thursday, 18 September Thu, 18 Sep

8:09 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Tim Downey commented on HHH-3357: --------------------------------- A simpler change may be to simply change line 115 of AbstractLazyInitializer from if (isConnectedToSession()) { to if (s != null && isConnectedToSession()) { Is there any downside to skipping the check if the new session is null? It seems harmless enough and definitely provides a major bump in performance if the session has a large number of objects within it.

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Alex Pires de Camargo (JIRA)

Wednesday, 5 November Wed, 5 Nov

2:06 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Alex Pires de Camargo commented on HHH-3357: -------------------------------------------- I'm having this problem too. See http://forum.hibernate.org/viewtopic.php?t=990508 I sounds like a side effect of a patch done for this bug fix: http://opensource.atlassian.com/projects/hibernate/browse/HHH-511 HHH-511

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Alex Pires de Camargo (JIRA)

2:39 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Jay Erb (JIRA)

3:10 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Jay Erb commented on HHH-3357: ------------------------------ I called it an improvement and not a bug because it does not crash the system or cause the system to get in an incorrect state. It is an improvement to the currently awful performance. However, I would argue that this improvement should be prioritized higher than some other bugs. If it is required that this issue be called a bug in order to prioritize it higher, I would agree that the issue type should be changed.

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Alex Pires de Camargo (JIRA)

3:27 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Alex Pires de Camargo commented on HHH-3357: -------------------------------------------- Its not just a performance improvement, the fix for HHH-511 generated this exponential search on clear (its linear for evict, exponential for clear). Session.clear should not take minutes to run in session with many proxies opened, in 3.2.3 or previous takes no time. I would open a bug for this, but as you have already reported the problem, I found better to add more info to your report. If you prefer I can open another ticket.

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Jay Erb (JIRA)

9:17 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Jay Erb updated HHH-3357: ------------------------- Issue Type: Bug (was: Improvement)

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Steve Ebersole (JIRA)

Wednesday, 7 January Wed, 7 Jan

4:18 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3357) session.clear() takes too long

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Steve Ebersole updated HHH-3357: -------------------------------- Issue Type: Improvement (was: Bug) It is an improvement

...

session.clear() takes too long ------------------------------ Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Steve Ebersole (JIRA)

4:32 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3357) improve performance of session.clear()

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Steve Ebersole updated HHH-3357: -------------------------------- Assignee: Steve Ebersole Fix Version/s: 3.4 3.3.x 3.2.x Summary: improve performance of session.clear() (was: session.clear() takes too long)

...

improve performance of session.clear() -------------------------------------- Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Assignee: Steve Ebersole Fix For: 3.2.x, 3.3.x, 3.4 Attachments: LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Steve Ebersole (JIRA)

5:18 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3357) improve performance of session.clear()

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Steve Ebersole updated HHH-3357: -------------------------------- Attachment: HHH-3357.patch Could one of y'all test this please?

...

improve performance of session.clear() -------------------------------------- Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Assignee: Steve Ebersole Fix For: 3.2.x, 3.3.x, 3.4 Attachments: HHH-3357.patch, LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Alex Pires de Camargo (JIRA)

Wednesday, 14 January Wed, 14 Jan

5:34 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3357) improve performance of session.clear()

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Alex Pires de Camargo commented on HHH-3357: -------------------------------------------- Tested with sucess!

...

improve performance of session.clear() -------------------------------------- Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Assignee: Steve Ebersole Fix For: 3.2.x, 3.3.x, 3.4 Attachments: HHH-3357.patch, LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

Steve Ebersole (JIRA)

Tuesday, 3 February Tue, 3 Feb

2:18 a.m.

New subject: [Hibernate-JIRA] Closed: (HHH-3357) improve performance of session.clear()

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357?page=c... ] Steve Ebersole closed HHH-3357. ------------------------------- Resolution: Fixed Thanks for following up Alex.

...

improve performance of session.clear() -------------------------------------- Key: HHH-3357 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3357 Project: Hibernate Core Issue Type: Improvement Components: core Affects Versions: 3.2.5, 3.2.6 Reporter: Jay Erb Assignee: Steve Ebersole Fix For: 3.2.x, 3.3.x, 3.4 Attachments: HHH-3357.patch, LazyInitializerPatch.txt Clearing a session that contains a large number of Proxies takes a very long time. The reason for this is that null is set on the LazyInitializer when clearing the StatefulPersistenceContext, whenever a new session is set on an AbstractLazyInitializer, a check is done to see if the AbstractLazyInitializer is still attached to its previous session (and correctly throws an exception if it is). This check performs a linear search through all Proxies in the PersistenceContext. Since we're setting the session to null, do we really need to do this expensive linear search? I propose we not perform the linear search if the session being set on the AbstractLazyInitializer is null.

5621

days inactive

5844

days old

hibernate-issues@lists.jboss.org

Manage subscription

13 comments

5 participants

tags (0)

participants (5)

Alex Pires de Camargo (JIRA)
Gerald Glocker (JIRA)
Jay Erb (JIRA)
Steve Ebersole (JIRA)
Tim Downey (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-3357) session.clear() takes too long