[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Adrian Hummel commented on HHH-5024: ------------------------------------ Yes. This is still an issue using 3.5.1-Final. The following error is logged during initialization: 20:49:50,578 ERROR MetadataContext.registerAttribute:413 - Unable to locate static metamodel field : org.foo.test.jpa2.hibernate.customer.CustomerId_#id Btw: the query used in the CustomerTest (see attached ZIP) should be replaced by the following query in order to let the test fail: Customer fetchedCustomer = em.createQuery(customerQuery.where(cb.equal(customerRoot.get(Customer_.customerId).get(CustomerId_.id), id.getId()))) .getSingleResult(); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Gail Badner commented on HHH-5024: ---------------------------------- Is this still an issue using 3.6.0? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Sai Hegde commented on HHH-5024: -------------------------------- This is still an issue with 3.6.1 Final. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Alexis Bataille commented on HHH-5024: -------------------------------------- Still an issue with 4.0.0.Final. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole updated HHH-5024: -------------------------------- Assignee: Steve Ebersole -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- Interestingly enough the attached test case actually passes! Thats because the MappedSuperclass is also the MappedSuperclass for an entity. Entities are processed before the embeddables, and are processed correctly. So by the time we get to the {{CustomerId}} embeddable here the {{AbstractIdentity_}} class has already been populated -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole updated HHH-5024: -------------------------------- Priority: Major (was: Critical) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- So this bug report is about misleading log message? Or does something really fail here? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Alexis Bataille commented on HHH-5024: -------------------------------------- The log message indicates that MetadataContext failed to feed the metadata static attribute "key" (in this test case). It's where the bug is (into MetadataContext.registerAttributes() method - see Stephan Bublava comment). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- I understand why the code where that message comes up is incorrect. However when I actually tried to write a test to demonstrate this the static metamodel classes actually got populated correctly. So, does the newly attached testcase illustrate a case where that does not happen with appropriate assertions? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- What I tried was also defining a composite id class, and that worked. So I will look at your test case and see whether it fails for me and what was different. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- I cannot accept copyrighted code. And this does not even seem to be copyrighted to you to be able to donate this or transfer copyright in the first place. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- Alexis, Justin. Thanks, I was able to get working test cases from your attachment/comments. We are discussing this on the developer mailing list. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Emeric Fillatre commented on HHH-5024: -------------------------------------- Thank you steve for working on this bug. If I may add something to you discussion, the problem does not only occur on embedded ID but on every embedded property declared on a mapped superclass. Every request based on Criteria API and on field from those embedded properties gets a null pointer exception -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Hardy Ferentschik commented on HHH-5024: ---------------------------------------- I was looking at the tests _org.hibernate.ejb.test.metagen.mappedsuperclass.idclass.MappedSuperclassWithEntityWithIdClassTest_ and _org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid.MappedSuperclassWithEmbeddedIdTest_ and there is problem with the metamodel getting populated, but where do you think the actual static classes are wrong? In _MappedSuperclassWithEntityWithIdClassTest_ we have the above mentioned _AbtractProduct_, _Product_ and _ProductId_ which result in: {code:title=AbstractProduct_.java|borderStyle=solid} package org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid; import javax.persistence.metamodel.SingularAttribute; import javax.persistence.metamodel.StaticMetamodel; @StaticMetamodel(AbstractProduct.class) public abstract class AbstractProduct_ { public static volatile SingularAttribute<AbstractProduct, ProductId> id; } {code} {code:title=Product_.java|borderStyle=solid} package org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid; import javax.persistence.metamodel.SingularAttribute; import javax.persistence.metamodel.StaticMetamodel; @StaticMetamodel(Product.class) public abstract class Product_ extends org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid.AbstractProduct_ { public static volatile SingularAttribute<Product, String> description; } {code} and {code:title=ProductId_.java|borderStyle=solid} package org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid; import javax.persistence.metamodel.SingularAttribute; import javax.persistence.metamodel.StaticMetamodel; @StaticMetamodel(ProductId.class) public abstract class ProductId_ { public static volatile SingularAttribute<ProductId, Integer> id; public static volatile SingularAttribute<ProductId, String> code; } {code} Just trying to find out whether this is a problem with the generated classes. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- Well you say you are looking at 2 different packages... I think in the {{org.hibernate.ejb.test.metagen.mappedsuperclass.idclass}} tests the generated model is clearly wrong. Those are the ones I listed in my previous comment. I think the generated model for {{org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid}} is actually OK. In my email to dev list I only ever referenced the {{org.hibernate.ejb.test.metagen.mappedsuperclass.idclass}} as illustrating a problem with metagen. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Hardy Ferentschik commented on HHH-5024: ---------------------------------------- {quote} I think the generated model for org.hibernate.ejb.test.metagen.mappedsuperclass.embeddedid is actually OK. {quote} Ok, then we are on the same line so far {quote} In my email to dev list I only ever referenced the org.hibernate.ejb.test.metagen.mappedsuperclass.idclass as illustrating a problem with metagen. {quote} Looking -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Hardy Ferentschik edited comment on HHH-5024 at 1/20/12 8:03 AM: ----------------------------------------------------------------- Ok, in _org.hibernate.ejb.test.metagen.mappedsuperclass.idclass_ we have: {code:title=AbstractAttribute.java|borderStyle=solid} @MappedSuperclass public abstract class AbstractAttribute implements Serializable { protected String key; protected String value; public AbstractAttribute() { super(); } public abstract String getOwner(); @Column(name = "attribute_key") public String getKey() { return key; } public void setKey(String key) { this.key = key; } @Column(name = "attribute_value") public String getValue() { return value; } public void setValue(String value) { this.value = value; } } {code} {code:title=AbstractAttribute_.java|borderStyle=solid} @StaticMetamodel(AbstractAttribute.class) public abstract class AbstractAttribute_ { public static volatile SingularAttribute<AbstractAttribute, String> value; public static volatile SingularAttribute<AbstractAttribute, String> owner; public static volatile SingularAttribute<AbstractAttribute, String> key; } {code} ---- {code:title=ProductAttribute.java|borderStyle=solid} @Entity @IdClass(value = ProductAttributeId.class) public class ProductAttribute extends AbstractAttribute implements Serializable { private String owner; public ProductAttribute(String key, String value, String product) { this.key = key; this.value = value; this.owner = product; } public ProductAttribute() { super(); } @Id @Column(name = "owner") public String getOwner() { return owner; } public void setOwner(String owner) { this.owner = owner; } @Id @Column(name = "attribute_key") public String getKey() { return key; } } {code} {code:title=ProductAttribute_.java|borderStyle=solid} @StaticMetamodel(ProductAttribute.class) public abstract class ProductAttribute_ extends org.hibernate.ejb.test.metagen.mappedsuperclass.idclass.AbstractAttribute_ { public static volatile SingularAttribute<ProductAttribute, String> owner; public static volatile SingularAttribute<ProductAttribute, String> key; } {code} ---- {code:title=AbstractAttributeId.java|borderStyle=solid} @MappedSuperclass public abstract class AbstractAttributeId implements Serializable { protected String key; public String getKey() { return key; } public void setKey(String key) { this.key = key; } } {code} {code:title=AbstractAttributeId_.java|borderStyle=solid} @StaticMetamodel(AbstractAttributeId.class) public abstract class AbstractAttributeId_ { public static volatile SingularAttribute<AbstractAttributeId, String> key; } {code} ---- {code:title=ProductAttributeId.java|borderStyle=solid} public class ProductAttributeId extends AbstractAttributeId { private String owner; public String getOwner() { return owner; } public void setOwner(String owner) { this.owner = owner; } @Override public int hashCode() { ... } @Override public boolean equals(Object obj) { ... } } {code} ---- What do you think is wrong in the metamodel classes? was (Author: hardy.ferentschik): Ok, in _org.hibernate.ejb.test.metagen.mappedsuperclass.idclass_ we have: {code:title=AbstractAttribute.java|borderStyle=solid}} @MappedSuperclass public abstract class AbstractAttribute implements Serializable { protected String key; protected String value; public AbstractAttribute() { super(); } public abstract String getOwner(); @Column(name = "attribute_key") public String getKey() { return key; } public void setKey(String key) { this.key = key; } @Column(name = "attribute_value") public String getValue() { return value; } public void setValue(String value) { this.value = value; } } {code} {code:title=AbstractAttribute_.java|borderStyle=solid}} @StaticMetamodel(AbstractAttribute.class) public abstract class AbstractAttribute_ { public static volatile SingularAttribute<AbstractAttribute, String> value; public static volatile SingularAttribute<AbstractAttribute, String> owner; public static volatile SingularAttribute<AbstractAttribute, String> key; } {code} ---- {code:title=ProductAttribute.java|borderStyle=solid}} @Entity @IdClass(value = ProductAttributeId.class) public class ProductAttribute extends AbstractAttribute implements Serializable { private String owner; public ProductAttribute(String key, String value, String product) { this.key = key; this.value = value; this.owner = product; } public ProductAttribute() { super(); } @Id @Column(name = "owner") public String getOwner() { return owner; } public void setOwner(String owner) { this.owner = owner; } @Id @Column(name = "attribute_key") public String getKey() { return key; } } {code} {code:title=ProductAttribute_.java|borderStyle=solid}} @StaticMetamodel(ProductAttribute.class) public abstract class ProductAttribute_ extends org.hibernate.ejb.test.metagen.mappedsuperclass.idclass.AbstractAttribute_ { public static volatile SingularAttribute<ProductAttribute, String> owner; public static volatile SingularAttribute<ProductAttribute, String> key; } {code} ---- {code:title=AbstractAttributeId.java|borderStyle=solid}} @MappedSuperclass public abstract class AbstractAttributeId implements Serializable { protected String key; public String getKey() { return key; } public void setKey(String key) { this.key = key; } } {code} {code:title=AbstractAttributeId_.java|borderStyle=solid}} @StaticMetamodel(AbstractAttributeId.class) public abstract class AbstractAttributeId_ { public static volatile SingularAttribute<AbstractAttributeId, String> key; } {code} ---- {code:title=ProductAttributeId.java|borderStyle=solid}} public class ProductAttributeId extends AbstractAttributeId { private String owner; public String getOwner() { return owner; } public void setOwner(String owner) { this.owner = owner; } @Override public int hashCode() { ... } @Override public boolean equals(Object obj) { ... } } {code} ---- What do you think is wrong in the metamodel classes? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5024?page=c... ] Steve Ebersole commented on HHH-5024: ------------------------------------- So the tests I created from these issues show what we think are 2 different "issues". First, the specific case Hardy and I were discussing above which came originally from Alexis. We both agree this is just incorrect mapping. Specifically, attributes defined on a {{MappedSuperclass}} can be "overridden" on an entity sub class, but the proper way to do that is to use ((AttributeOverrides)). And there is no spec provided way to say that a basic attribute defined on a {{MappedSuperclass}} become {{Id}} mappings on an entity sub class. Given that model, we think the correct way to map that to match the intent and meet the spec is to mark those 2 attributes as {{Transient}} on the {{MappedSuperclass}} like so: {code:title=AbstractAttribute.java|borderStyle=solid} @MappedSuperclass public abstract class AbstractAttribute implements Serializable { protected String key; protected String value; public AbstractAttribute() { super(); } @Transient public abstract String getOwner(); @Transient public String getKey() { return key; } public void setKey(String key) { this.key = key; } @Column(name = "attribute_value") public String getValue() { return value; } public void setValue(String value) { this.value = value; } } {code} The entity class stays as it was. And this works in terms of both the metamodel generator and Hibernate populating that static metamodel. ---- The second issue deals with "embeddable" classes defined on a {{MappedSuperclass}}. This holds true for both {{Embedded}} and {{EmbeddedId}}. The issue is the way in which support for {{MappedSuperclass}} was originally "bolted on" to the existing Hibernate {{PersistentClass}} mapping classes. Changing the {{getDeclaredField}} call to {{getField}} as suggested here is really just a band aid. But we will make that change for embeddable attributes for 4.1 as better solutions are already targeted for 5.0 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HHH-5024?page=com.atlassian.jira.plug... ] Strong Liu commented on HHH-5024: --------------------------------- https://issues.jboss.org/browse/JBPAPP-8074 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira