[Hibernate-JIRA] Created: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[Hibernate-JIRA] Created: (HV-463)...

[Hibernate-JIRA] Created: (HV-517)...

Igor Vaynberg (JIRA)

Thursday, 5 March 2009 Thu, 5 Mar '09

6:36 p.m.

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Igor Vaynberg (JIRA)

Thursday, 5 March Thu, 5 Mar

6:41 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ it should read "inaccessible by any collection methods that rely" not "inaccessible by any collection items that rely"

...

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Jeff Payne (JIRA)

7:36 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Jeff Payne commented on HHH-3799: --------------------------------- The test passes if you change the query to the following, eagerly fetching the container: Item item1 = (Item)session.createQuery( "FROM Item i LEFT JOIN FETCH i.container WHERE name=:name").setParameter( "name", "item1").uniqueResult();

...

Igor Vaynberg (JIRA)

7:45 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ looks like that changes document.items back to a lazy loaded collection, i want an eager fetch because i access the entity outside a hibernate session.

...

Igor Vaynberg (JIRA)

9:33 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ actually jeff is right, adding a left join fetch does help. i changed eager to lazy in my @onetomany while looking for a workaround and didnt notice.

...

Gail Badner (JIRA)

Friday, 6 March Fri, 6 Mar

12:38 a.m.

New subject: [Hibernate-JIRA] Resolved: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner resolved HHH-3799. ------------------------------ Assignee: Gail Badner Resolution: Rejected

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Igor Vaynberg (JIRA)

12:40 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ why was this rejected? is a LEFT JOIN FETCH a requirement in each hql query for any collection mapped as fetch=eager?

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Igor Vaynberg (JIRA)

12:42 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ to clarify, what jeff has pointed out is a *workaround*, not a solution. the unit test is valid i believe, unless you tell me otherwise.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

1:20 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Priority: Minor (was: Blocker) The workaround is easy to implement.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

1:20 a.m.

New subject: [Hibernate-JIRA] Reopened: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner reopened HHH-3799: ------------------------------

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Blocker Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Igor Vaynberg (JIRA)

1:29 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ i wouldnt necessarily agree that the workaround is easy to implement. the implementation is technically easy, but it sure as hell hard to find all the queries that have the potential to retrieve any entity that makes the affected container entity reachable. eg FROM Entity e LEFT JOIN FETCH e.foo.bar.baz.container where as before all you had was FROM Entity e

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

1:41 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner commented on HHH-3799: ---------------------------------- See http://www.hibernate.org/hib_docs/v3/reference/en-US/html_single/#queryhq... .

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Igor Vaynberg (JIRA)

2:36 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Igor Vaynberg commented on HHH-3799: ------------------------------------ here is an easier workaround, at least this one is localized to the collections affected, you can call this method in the getter before returning the collection or any time after its loaded. fun. private static void rebuildPersistentSet(PersistentSet urls) { try { Field set = urls.getClass().getDeclaredField("set"); set.setAccessible(true); Set<Object> s = (Set<Object>) set.get(urls); Set<?> temp = new HashSet<Object>(s); s.clear(); s.addAll(temp); } catch (Exception e) { e.printStackTrace(); } }

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Jeff Payne (JIRA)

7:11 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Jeff Payne commented on HHH-3799: --------------------------------- Seems like the real problem is that the general contract of the Collection methods is broken in this scenario. Object graph traversal is a commonly used mechanism. In fact, isn't that one of the reasons that mapping configs allow us to define a default fetch strategy, so that when the graph is traversed we can control how the associations are loaded? The workaround above should at least be part of the documentation as a workaround for known limitation. Also, the documentation section cited is concerned with how the joins in the query are written, explicitly vs. implicitly. This bug has to do with a collection association that isn't even mentioned in the query. The query-based workaround simply eagerly fetches the many-to-one association.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Dave Lindquist (JIRA)

Thursday, 12 March Thu, 12 Mar

5:37 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Dave Lindquist commented on HHH-3799: ------------------------------------- We've just run into this problem as well... Specifically, we have an object which contains a Set, loaded eagerly, and an attempt to do a 'contains' in that set fails. However, if we change our getter to say "return new HashSet(<instance-variable>)" instead, then things succeed (ie, forcing creation of a new set object). However, I have to disagree with the priority on this item -- this is NOT a minor item -- this is at LEAST a "major", if not a "critical" item.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Oliver Meyn (JIRA)

Wednesday, 21 October Wed, 21 Oct

10:12 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Oliver Meyn commented on HHH-3799: ---------------------------------- This is proving painful for us - we typically fetch an object, serialize it, and send it off via JMS. When an object that contains a collection gets deserialized on the other end, it goes boom due to this bug. So we're using the return new HashSet(originalSet) workaround which "solves" the messaging problem. But when work has to happen close to the db and the object (say User has a field called name, and has a collection of Addresses) gets updated (updating only name) Hibernate looks at the collection and sees an entirely new object, so deletes the old collection and writes a new one, even though the data (the Addresses) are all the same. This forces a bunch of unnecessary work in the db. So +1 on upgrading to Major.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Brian Schlining (JIRA)

Tuesday, 10 November Tue, 10 Nov

7:05 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Brian Schlining commented on HHH-3799: -------------------------------------- I agree with Oliver that this should be upgraded to major. I'm trying to use JPA/Hibernate and this bug has been clobbering me. I'm very hesitant to inject Hibernate specific workarounds when using JPA.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

George Nikolaidis (JIRA)

Wednesday, 13 January Wed, 13 Jan

5:55 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] George Nikolaidis commented on HHH-3799: ---------------------------------------- I am confirming the bug, also voting +1 for it's critical importance. Breaking the equals()/hashCode() contract has large-scale repercussions. Changing to FETCH strategy is NOT always an option.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

6:59 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: 3.5

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Fix For: 3.5 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Tuesday, 16 February Tue, 16 Feb

10:29 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.5.0-CR-2) 3.5.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Florimon van Putte (JIRA)

Friday, 19 February Fri, 19 Feb

2:02 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Florimon van Putte commented on HHH-3799: ----------------------------------------- I am also confirming the bug and voting +1. We have an entity with both multiple parent and multiple child relations to itself, and when we just load the whole graph, many child instances are missing, because our hashCode() and equals() depend on a field which isn't loaded yet by hibernate when it constructs the persistent sets. Because of this we have to make our hashCode() and equals() depend on the 'id' field only, which isn't an ideal situation either.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Wednesday, 14 April Wed, 14 Apr

1:09 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.5.1) 3.5.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Tuesday, 20 April Tue, 20 Apr

8:15 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Affects Version/s: 3.5.1

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Priority: Minor Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Wednesday, 21 April Wed, 21 Apr

10:23 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Priority: Major (was: Minor)

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Thursday, 22 April Thu, 22 Apr

12:14 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner commented on HHH-3799: ---------------------------------- As far as I can tell, this issue can only come up when a non-lazy (eagerly loaded) collection contains entities of a class that overrides Object.hashCode(). You should not see this problem if you don't override Object.hashCode(). For a discussion of when Hibernate requires equals() and hashCode() to be overridden, see http://docs.jboss.org/hibernate/stable/core/reference/en/html/persistent-... . It's worth mentioning that, if Hibernate does not require hashCode() and equals() to be overridden and your application does not specifically require it, you may not need to override them at all. I don't think it will be easy to come up with a fix that will work in all cases. I think it would be fairly straightforward to fix this issue for cases where hashCode() only depends on simple (non-association) properties. To illustrate a case where the fix would work, suppose: - A has a non-lazy, one-to-many association with B, a.bs - B has a non-lazy, many-to-one association with A, b.a - B has a simple string property, name - B overrides Object.hashCode() - B.hashCode() uses B.name to calculate the hash code; B.hashCode() does not use B.a in the calculation Basically, the fix I am proposing would be to initialize simple properties in a loading entity before initializing its associations. I'll provide more details about this partial fix and why it would work in another comment. I'd like to get an idea about how people are implementing hashCode(). If this would work for enough people, it might be worthwhile to implement this partial fix. Please let us know if your implementations of hashCode() only use simple (non-association) properties.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Shawn Clowater (JIRA)

1:22 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Shawn Clowater commented on HHH-3799: ------------------------------------- In our case we hash off a single uuid property that is persisted with our entity. When we create a new object we automatically generate the uuid so that we can identify the new object with its generated PK when it comes back from the server to the client. I voted for making the uuid our pk but users seem to hate having to do select * from table where id = '1f822e76-f219-462c-9574-874cf813b15d' rather than id = 4, go figure. So, your 'partial' fix would most likely be a full fix for us.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Paul Benedict (JIRA)

2:31 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Paul Benedict commented on HHH-3799: ------------------------------------ To the issue's original description, can hashCode() be delayed until the object is materialized? Probably not feasible, but can the object be rehashed upon materialziation?

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Oliver Meyn (JIRA)

3:39 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Oliver Meyn commented on HHH-3799: ---------------------------------- We don't explicitly override hashcode (nor equals), yet we are definitely experiencing the bug. I'm not sure what munging Mule and/or ActiveMQ might be doing under the covers (see my earlier comment), but I don't think it would affect us at this level.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Florimon van Putte (JIRA)

Monday, 26 April Mon, 26 Apr

9:56 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Florimon van Putte commented on HHH-3799: ----------------------------------------- Gail, our implementation of hashCode() indeed only uses simple (non-association) properties, in fact it uses a single String member ('code').

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Tuesday, 11 May Tue, 11 May

6:39 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: 3.6

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

7:23 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner commented on HHH-3799: ---------------------------------- I've added a "FailureExpected" test that reproduces this issue to trunk and Branch_3_5: org.hibernate.test.collection.set.PersistentSetNonLazyTest.testLoadChildCheckParentContainsChildCacheFailureExpected() The partial solution would probably involve making changes to: - TypeFactory.assemble(...) - various implementations of Type.assemble(...) In response to Paul's questions:

...

To the issue's original description, can hashCode() be delayed until the object is materialized?

I'm not sure, but this could be a chicken-and-egg problem.

...

Probably not feasible, but can the object be rehashed upon materialziation?

It may be possible to collect loaded entities in an EventCache then replace collection elements using CollectionType.replace(...), but I really have not looked into this. You can see examples of how these are used in DefaultMergeEventListener. It would help a lot if someone would take a shot at implementing a fix. Thanks, Gail

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Monday, 14 June Mon, 14 Jun

8:19 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.5.3) 3.5.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Monday, 12 July Mon, 12 Jul

6:32 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.5.4) 3.5.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Wednesday, 21 July Wed, 21 Jul

7:58 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.6.0.Beta1) 3.6.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Manish Khettry (JIRA)

Tuesday, 31 August Tue, 31 Aug

5:29 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Manish Khettry commented on HHH-3799: ------------------------------------- +1 that its critical to fix this bug. The hashCode/equals contract is just too critical to break, imho. Does the hibernate team agree that this is worth fixing?

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.5.x, 3.6.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Saturday, 25 September Sat, 25 Sep

5:05 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.6.0.CR2) (was: 3.5.x) 3.6.x

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.x Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Thursday, 14 October Thu, 14 Oct

4:29 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.6.0) 3.6.1

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.1 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Monday, 17 January Mon, 17 Jan

9:31 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.6.1) 3.6.next I agree this should be fixed. A patch would be most welcome.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.next Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Wednesday, 16 March Wed, 16 Mar

8:13 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.6.next) 3.6.3

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.3 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Steve Ebersole (JIRA)

Wednesday, 6 April Wed, 6 Apr

8:02 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Steve Ebersole updated HHH-3799: -------------------------------- Fix Version/s: (was: 3.6.3) 3.6.4

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.4 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Wednesday, 4 May Wed, 4 May

8:02 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.6.4) 4.0.0.Beta1 3.6.5

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Fix For: 3.6.5, 4.0.0.Beta1 Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

Gail Badner (JIRA)

Wednesday, 8 June Wed, 8 Jun

10:45 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] Gail Badner updated HHH-3799: ----------------------------- Fix Version/s: (was: 3.6.5) (was: 4.0.0.Beta1)

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

David Tarico (JIRA)

Monday, 8 August Mon, 8 Aug

7:47 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] David Tarico commented on HHH-3799: ----------------------------------- I'm also encountering this issue, and to answer Gail's question, in our case, equals/hashcode only use a single String, so the "partial fix" would resolve the problem.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

lance obermeyer (JIRA)

Tuesday, 13 December Tue, 13 Dec

5:04 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799?page=c... ] lance obermeyer commented on HHH-3799: -------------------------------------- Since this is still listed as open, I'll add my experience. I have encountered what looks like this issue as well. In my case the parent.hashCode() calls child.hashCode() where child is a @OneToMany association that is FetchType.EAGER. This is several levels down. My collection is materialized with HQL that includes "left outer join fetch parent.child" so I was expecting the data to be present before the call to child.hashCode(). I get this in the stack trace. org.hibernate.LazyInitializationException: illegal access to loading collection at org.hibernate.collection.AbstractPersistentCollection.initialize(AbstractPersistentCollection.java:363) at org.hibernate.collection.AbstractPersistentCollection.read(AbstractPersistentCollection.java:108) at org.hibernate.collection.PersistentSet.hashCode(PersistentSet.java:434) at [parent].hashCode(parent.java:307)

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3799 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

Thursday, 23 February Thu, 23 Feb

7:09 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- Seems to me PersistentSet is behaving in a manner consistent with the (express or implied) contract established by Java. By definition, if the result of hashCode() changes, the identity of the object changes. If non-ID items are included in hashCode() that can be null at one moment and not-null at another, or can change values in any other way, then any hash table implementation relying on hashCode will fail, because things will henceforth be assigned to the wrong buckets. The only option for correcting it is to remove the object and re-add it. Yes, eager loading shouldn't necessarily be subject to this problem, since Hibernate could in theory completely initialize the object before adding it to the PersistentSet, but I still think one is treading on very thin ice by including Hibernate-managed persistent, non-ID class members in the calculation of a hashCode at all, because the results would be unsatisfying even when you're lazily loading those members. (1) Initializing a PersistentSet would automatically also initialize all the proxies in the set. (2) If the Hibernate ID of an object is sufficient to establish its identity/uniqueness, then the Hibernate ID should also suffice for hashCode calculation. If not, I think you have an object identity bug waiting to happen elsewhere.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Shawn Clowater (JIRA)

7:30 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Shawn Clowater commented on HHH-3799: ------------------------------------- Nate, therein lies the rub. Even if you're using the ID as the hashcode/equals then the hashcode changes between a saved and unsaved entity (for a generated identifier). Removing and re-adding doesn't work quite right either. You can't remove an object where the hashCode changes from a set since the underlying store is a hashMap keyed off the hashcode so it can't be found using a set.remove(object) In our case we generate (and persist) a UUID to identify our objects so that we can marry them up from UI to our command layer and back again. This is separate from our PK since users get in the way and complain if they see an entity with a 32 char alphanumeric PK vs a long generated from a sequence. In a perfect world I'd use UUID identifiers that were assigned at object creation but alas. While I agree that it may be a slippery slope of keeping a hash of n number of mutable properties it shouldn't break eagerly loaded collections. As for the proxy thing I'd love to see the ability to specify an additional property as 'eager' w/o having to instrument all of the classes to get property by property lazy loading.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

7:58 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- Shawn, if I understand your scenario correctly, the PK is the Hibernate ID, and the UUID is a persistent, non-ID property. Why not use PK.hashCode() as the hashCode() of the containing object, and leave the UUID out of hashcode calculation? Wouldn't that make you immune to the problem described here? I think any challenges relating to the lack of an ID in an uninitialized entity are unrelated to this issue - please correct me if I'm mistaken.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

8 p.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark edited comment on HHH-3799 at 2/23/12 1:00 PM: ---------------------------------------------------------- Shawn, if I understand your scenario correctly, the PK is the Hibernate ID, and the UUID is a persistent, non-ID property. Why not use PK.hashCode() as the hashCode() of the containing object, and leave the UUID out of hashcode calculation? Wouldn't that make you immune to the problem described here? I think any challenges relating to the lack of an ID in an unsaved entity are unrelated to this issue - please correct me if I'm mistaken. was (Author: nate.clark): Shawn, if I understand your scenario correctly, the PK is the Hibernate ID, and the UUID is a persistent, non-ID property. Why not use PK.hashCode() as the hashCode() of the containing object, and leave the UUID out of hashcode calculation? Wouldn't that make you immune to the problem described here? I think any challenges relating to the lack of an ID in an uninitialized entity are unrelated to this issue - please correct me if I'm mistaken.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Shawn Clowater (JIRA)

8:38 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Shawn Clowater commented on HHH-3799: ------------------------------------- It's not directly the same but it's related to saying that using the PK would be the silver bullet. Simple test case demonstrating 2 of the issues off the top of my head that would cause grief with using a generated id. You would be forced to save the child before adding it to the parent in those cases. (if just using the PK as the hashcode/equals) {code} @Test public void cantAddMultipleUnsaved(){ B b = new B(); b.as.add(new A()); b.as.add(new A()); b.as.add(new A()); b.as.add(new A()); //fails - size is only 1 since unsaved entities hashed to the same value Assert.assertEquals(4, b.as.size()); } @Test public void saveThenCantRemove(){ B b = new B(); final A a = new A(); b.as.add(a); Assert.assertEquals(1, b.as.size()); b.as.remove(b); Assert.assertEquals(0, b.as.size()); b.as.add(a); Assert.assertEquals(1, b.as.size()); //pretend we have a session and save at this point a.id = (long) 8675309; b.as.remove(a); //fails since the hashcode changed Assert.assertEquals(0, b.as.size()); } public class A{ public Long id; @Override public boolean equals(Object o) { if (this == o) return true; if (!(o instanceof A)) return false; A a = (A) o; if (id != null ? !id.equals(a.id) : a.id != null) return false; return true; } @Override public int hashCode() { return id != null ? id.hashCode() : 0; } } public class B extends A{ public Set<A> as = new HashSet<A>(); } {code}

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

David Tarico (JIRA)

8:48 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] David Tarico commented on HHH-3799: ----------------------------------- I think the lack of an ID in an unsaved entity is exactly the problem here. The book "Java Persistence with Hibernate" by Christian Bauer and Gavin King talks in chapter 9 section 2.2 about implementing equality with a business key instead of the PK since the primary key is not assigned until the object is persisted. Like Shawn, we use one or more non-PK fields as the business key in the equals/hashcode so that we can use a set both before and after the objects are persisted and not worry about their identity changing and breaking the contract of a set. I think the issue here is that Hibernate simply cannot lazy load the entities in this PersistentSet and must hydrate them before adding them to the set. Perhaps it should be a configurable option if some users are using the ID and want the lazy loading, but when we've learned from authors on the Hibernate team not use the PK in equals/hashcode and have been doing this practice for many years, this definitely seems like an implementation bug with PersistentSet.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

8:53 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- Shawn, thanks for the example code. Briefly, if you have a problem calling save()/saveOrUpdate() before adding your objects, then maybe you should be managing the keys instead of letting Hibernate manage them. I'd be happy to continue this discussion off-JIRA, as this is a bit off topic. Please respond directly to my email.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

9:23 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- David, when Hibernate adds the object to the PersistentSet in the scenarios we're looking at, the actual Hibernate ID is indeed available (we know this because normal scenarios use it), and the persistent surrogate ID used in hashCode() is not available. Why not write hashCode() such that the Hibernate ID is used by preference, and the surrogate ID is only used as a fallback? So the hashCode() method in the example provided by Gail becomes: {code} @Override public int hashCode() { return 31 * result + (id != null ? id.hashCode() : name.hashCode()); } {code} Am I missing something that makes this approach unattractive?

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

David Tarico (JIRA)

Friday, 24 February Fri, 24 Feb

2:43 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] David Tarico commented on HHH-3799: ----------------------------------- In my scenario, objects have a name, which in the database is a non-nullable field and has a unique constraint, but it's not the primary key. The PK is an auto-generated integer. I need to fetch an already persisted set, and add a new item if it doesn't already exist. It seems natural to make equals/hashCode use the name for identity, and then use a set to avoid duplicates. The problem with your proposed hashCode is that it assumes either all the entities in the collection are persistend, or all are new and don't have an ID. Assume we have two objects, FOO and BAR, both which have the same name. FOO is persisted and in the set, but BAR is new and not yet in the set. If I do set.contains(BAR) it will return false, and if I do set.add(BAR) it will succesfully add BAR and have both FOO and BAR in the set, causing a unique constraint violation when persisted. Using a buisness key such as name is a common practice and is even the example given in Java Persistence with Hibernate in the section on "Object identity and equality" where they have a User with this example of hashCode: public int hashCode() { return username.hashCode(); } Our hashCode actually looks like public int hashCode() { if (name == null) { return 0; } else { return name.hashCode(); } } It took a couple developers more than a day to figure out why the set was not finding the elements that were already in it and allowing the addition of duplicates. We had to work around the problem by using a list instead of a set, and adding our own code to check for duplicates before adding an item. But in my opinion, that makes PersistentSet broken and unusable because it violates the contract of how hashCode() is expected to behave.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

4 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- Yeah, I thought you might have that problem with my suggested approach. I'm not saying it isn't a tough problem, once you go with an approach that allows for dual IDs, and I'm not trying to insist that there's nothing the Hibernate folks could improve in this area. But we should also be clear that the problem is not that PersistentSet "violates the contract of how hashCode() is expected to behave". In fact, you could say this problem is partly caused by PersistentSet following the hashCode() contract (not to say the right solution is to break the contract, either). I maintain that the core hashCode/hashtable behavior we're seeing can be reproduced with a vanilla HashSet. (And iirc, PersistentSet actually uses a HashSet internally to perform these lookups.) The real violation of the hashCode contract is in maintaining two IDs and hashing on one or the other depending on context. As I said above, you are in essence changing the identity of the object after the fact, something that hashtable implementations don't play nice with. The problem stems from combining this aspect of the hashCode contract with the usual Hibernate/database management of IDs, in which entities are endowed with IDs only when they are saved. These two ideas, while they are both valuable and useful, are not 100% compatible.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

David Tarico (JIRA)

4:30 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] David Tarico commented on HHH-3799: ----------------------------------- I believe this has turned into a philosophical discussion and is more appropriate for the forums. My intent was just to help the hibernate developers understand why this is a problem for people.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

5:48 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- I respect that. Like yang to your yin, my intent is to help people experiencing this problem to understand why this poses a problem that goes well beyond what Hibernate developers can solve for you. Though they might be able to provide a local patch for eager fetches that still work in spite of a hashCode contract broken by Hibernate users (albeit following the advice of Hibernate developers), they can not drive a stake through the heart of your problem, and you may see its negative impacts in other areas of your application. This concern is more than philosophical :)

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

6:02 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark commented on HHH-3799: --------------------------------- As a final comment on the hashCode/equals contracts before we relegate it to the forums, I think it's appropriate to reference this very relevant article by Odersky, Spoon and Venners: [http://www.artima.com/lejava/articles/equality.html] and note the relevance of Pitfalls #2 and #3.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Nate Clark (JIRA)

6:04 p.m.

New subject: [Hibernate-JIRA] Issue Comment Edited: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Nate Clark edited comment on HHH-3799 at 2/24/12 11:02 AM: ----------------------------------------------------------- As a final comment on the hashCode/equals contract before we relegate this topic to the forums, I think it's appropriate to reference this very relevant article by Odersky, Spoon and Venners: [http://www.artima.com/lejava/articles/equality.html] and note the relevance of Pitfalls #2 and #3. was (Author: nate.clark): As a final comment on the hashCode/equals contracts before we relegate it to the forums, I think it's appropriate to reference this very relevant article by Odersky, Spoon and Venners: [http://www.artima.com/lejava/articles/equality.html] and note the relevance of Pitfalls #2 and #3.

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

Bjarne Saebuck (JIRA)

Wednesday, 28 March Wed, 28 Mar

11:42 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly

[ https://hibernate.onjira.com/browse/HHH-3799?page=com.atlassian.jira.plug... ] Bjarne Saebuck commented on HHH-3799: ------------------------------------- +1 As somebody posted before we also have two different identifiers: The "normal" primary key which is a numeric sequence value and a generated GUID which is used on Java side to guaranty uniqueness of newly created objects after transfer them from client to server and vice versa. So the GUID is taken to generate the HashCode. On database side the GUID of course is a column with an unique constraint but we can not take this as primary key because the customer would have his problem with "handling" such a long id. At debugging we saw that first time hashCode is called, the id is already known but no other fields, so wouldn´t it solve the problem if we could tell hibernate to also load the GUID field (or what field ever...) when it loads the id so that GUID is known at the same time as the id and can be used to generate the hashcode? Is there already any way to do so?

...

PersistentSet does not honor hashcode/equals contract when loaded eagerly ------------------------------------------------------------------------- Key: HHH-3799 URL: https://hibernate.onjira.com/browse/HHH-3799 Project: Hibernate ORM Issue Type: Bug Components: core Affects Versions: 3.3.1, 3.5.1 Reporter: Igor Vaynberg Assignee: Gail Badner Attachments: test.zip when persistent set is loaded eagerly in some situations it calls hashcode on its items before their field values are populated and then uses this incorrect hashcode to store them in the set. this makes set items inaccessible by any collection items that rely on hashcode such as contains(), remove(), etc. attached is a simple maven test project that reproduces the error, unzip and mvn test to run the test.

-- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

4472

days inactive

5591

days old

hibernate-issues@lists.jboss.org

Manage subscription

58 comments

16 participants

tags (0)

participants (16)

Bjarne Saebuck (JIRA)
Brian Schlining (JIRA)
Dave Lindquist (JIRA)
David Tarico (JIRA)
Florimon van Putte (JIRA)
Gail Badner (JIRA)
George Nikolaidis (JIRA)
Igor Vaynberg (JIRA)
Jeff Payne (JIRA)
lance obermeyer (JIRA)
Manish Khettry (JIRA)
Nate Clark (JIRA)
Oliver Meyn (JIRA)
Paul Benedict (JIRA)
Shawn Clowater (JIRA)
Steve Ebersole (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-3799) PersistentSet does not honor hashcode/equals contract when loaded eagerly