[Hibernate-JIRA] Created: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
11:18 a.m.
Infinispan Hibernate RegionFactory doesn't allow user to have their own custom
CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If a
user has their own command factory and attempts to use hibernate there is a chance that it
will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno reassigned HHH-7166:
-------------------------------------
Assignee: Galder Zamarreno
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno updated HHH-7166:
----------------------------------
Fix Version/s: 4.1.2
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:52 a.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno resolved HHH-7166.
-----------------------------------
Resolution: Fixed
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:32 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
William Burns commented on HHH-7166:
------------------------------------
Galder,
Has the change to make the method return a
org.infinispan.transaction.lookup.TransactionManagerLookup instead dropped? Should I log
an improvement for that instead? Adding that change makes it a lot easier to extend the
class and change the lookup returned.
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno commented on HHH-7166:
---------------------------------------
Hmmm, I missed that, sorry. Your suggestion is right, but that'd mean changing the API
and I know others (i.e. AS7) extend it, so I'd rather not do that now and potentially
break others.
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:36 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
William Burns commented on HHH-7166:
------------------------------------
Java allows for method return type covariance, which would limit this breaking their code.
The only problem would be if they invoked the super method and assigned it to a variable
the is defined as the implementation class instead of the interface. But you would know
better if that is what they are doing.
Should I log an improvement for a later release then?
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:55 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno commented on HHH-7166:
---------------------------------------
Yeah, log something for later.
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:14 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
Galder Zamarreno commented on HHH-7166:
---------------------------------------
William, I'll have your suggestion included as part of
https://hibernate.onjira.com/browse/HHH-7179. AS7 guys are happy with it too.
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7166) Infinispan Hibernate RegionFactory doesn't allow user to have their own custom CommandFactory
[
https://hibernate.onjira.com/browse/HHH-7166?page=com.atlassian.jira.plug...
]
William Burns commented on HHH-7166:
------------------------------------
Awesome!
Thanks again, Galder.
Infinispan Hibernate RegionFactory doesn't allow user to have
their own custom CommandFactory
---------------------------------------------------------------------------------------------
Key: HHH-7166
URL: https://hibernate.onjira.com/browse/HHH-7166
Project: Hibernate ORM
Issue Type: Bug
Affects Versions: 4.1.1
Reporter: William Burns
Assignee: Galder Zamarreno
Fix For: 4.1.2
Attachments: 0001-Changed-command-factory-lookup-to-only-grab-the-hibe.patch
The hibernate infinispan module currently takes the first command factory returned.
{code}
// TODO: This is a hack, make it easier to retrieve in Infinispan!
return (CacheCommandFactory) ((Map)
globalCr.getComponent("org.infinispan.modules.command.factories"))
.values().iterator().next();
{code}
This assumes that the hibernate infinispan command factory is the only one provided. If
a user has their own command factory and attempts to use hibernate there is a chance that
it will grab the incorrect command factory eventually causing a ClassCastException.
I have attached a patch that contains a simple fix, where basically it iterates through
the factories and only pulls out the hibernate one.
There is also a small change that I changed the return type for the
TransactionManagerLookup to use the interface instead of the hibernate specific one. This
way it is easier for users to override the method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5125
days inactive
5143
days old
hibernate-issues@lists.jboss.org
9 comments
2 participants
participants (2)
-
Galder Zamarreno (JIRA) -
William Burns (JIRA)