Sanne Grinovero (
https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%...
) *commented* on HHH-13879 (
https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMWU0N2...
)
Re: Slow query log should use System#nanoTime not System#currentTimeMillis (
https://hibernate.atlassian.net/browse/HHH-13879?atlOrigin=eyJpIjoiMWU0N2...
)
no worries Vlad, I’m not expressing a concern over your patch. Just pointing out that it’s
not straight forward - as I said in my first sentence.
Regarding monotonic clocks - that’s precisely the problem, neither {{ currentTimeMillis
}} nor {{ nanoTime }} guarantee that. It doesn’t matter that the OS supports it, the JDK
is not exposing the same counter - however what it exactly does depends on the version of
the JVM, its vendor, and the OS.
I’m aware of NTP issues - it’s probably better to stick with nanoTime for short durations
- just worth keeping in mind that even so, it’s not bulletproof.
(
https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey...
) Add Comment (
https://hibernate.atlassian.net/browse/HHH-13879#add-comment?atlOrigin=ey...
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira....
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em...
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a269fed )